Spring/spring-batch
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fixed remaining warnings under main/java, added TODOs for IbatisDrivingQueryItemReader and MultipleColumnJdbcKeyCollector

Browse Source
This commit is contained in:
robokaso
2008-07-24 08:52:13 +00:00
parent 0fd9b3e4c6
commit a07daf3d3a
6 changed files with 26 additions and 43 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
spring-batch-infrastructure/src/test/java/org/springframework/batch/item/database/support/ColumnMapExecutionContextRowMapperTests.java
View File

@@ -5,12 +5,12 @@ package org.springframework.batch.item.database.support;
import java.sql.PreparedStatement;
import java.util.HashMap;
import java.util.LinkedHashMap;
import java.util.Map;
import junit.framework.TestCase;
import org.easymock.MockControl;
import org.springframework.core.CollectionFactory;
/**
* @author Lucas Ward
@@ -19,7 +19,7 @@ public class ColumnMapExecutionContextRowMapperTests extends TestCase {
private ColumnMapItemPreparedStatementSetter mapper;
private Map<Object, Object> key;
private Map<String, Object> key;
private MockControl psControl = MockControl.createControl(PreparedStatement.class);
private PreparedStatement ps;
@@ -31,35 +31,15 @@ public class ColumnMapExecutionContextRowMapperTests extends TestCase {
ps = (PreparedStatement)psControl.getMock();
mapper = new ColumnMapItemPreparedStatementSetter();
key = CollectionFactory.createLinkedCaseInsensitiveMapIfPossible(2);
key = new LinkedHashMap<String, Object>(2);
key.put("1", new Integer(1));
key.put("2", new Integer(2));
}
public void testSetValuesWithInvalidType() throws Exception {
try{
mapper.setValues(new Object(), ps);
fail();
}catch(IllegalArgumentException ex){
//expected
}
}
public void testCreateExecutionContextWithNull() throws Exception{
try{
mapper.setValues(ps, null);
fail();
}catch(IllegalArgumentException ex){
//expected
}
}
public void testCreateExecutionContextFromEmptyKeys() throws Exception {
psControl.replay();
mapper.setValues(new HashMap<Object, Object>(), ps);
mapper.setValues(new HashMap<String, Object>(), ps);
psControl.verify();
}