From a1b1ede35b08fea776bc620355f36d91aa7ab40f Mon Sep 17 00:00:00 2001
From: Mahmoud Ben Hassine <mbenhassine@vmware.com>
Date: Tue, 21 Nov 2023 10:20:00 +0100
Subject: [PATCH] Fix Javadoc in DefaultFieldSet and DefaultFieldSetFactory

Resolves #4494
---
 .../batch/item/file/transform/DefaultFieldSet.java | 14 +++++++-------
 .../file/transform/DefaultFieldSetFactory.java     | 11 ++++++-----
 2 files changed, 13 insertions(+), 12 deletions(-)

diff --git a/spring-batch-infrastructure/src/main/java/org/springframework/batch/item/file/transform/DefaultFieldSet.java b/spring-batch-infrastructure/src/main/java/org/springframework/batch/item/file/transform/DefaultFieldSet.java
index c0e833831..4ec95e4d5 100644
--- a/spring-batch-infrastructure/src/main/java/org/springframework/batch/item/file/transform/DefaultFieldSet.java
+++ b/spring-batch-infrastructure/src/main/java/org/springframework/batch/item/file/transform/DefaultFieldSet.java
@@ -33,9 +33,9 @@ import org.springframework.util.Assert;
 import org.springframework.util.StringUtils;
 
 /**
- * Default implementation of {@link FieldSet} using Java using Java primitive and standard
- * types and utilities. Strings are trimmed before parsing by default, and so are plain
- * String values.
+ * Default implementation of {@link FieldSet} using Java primitive and standard types and
+ * utilities. Strings are trimmed before parsing by default, and so are plain String
+ * values.
  *
  * @author Rob Harrop
  * @author Dave Syer
@@ -65,8 +65,8 @@ public class DefaultFieldSet implements FieldSet {
 	private List<String> names;
 
 	/**
-	 * The {@link NumberFormat} to use for parsing numbers. If unset the US locale will be
-	 * used ('.' as decimal place).
+	 * The {@link NumberFormat} to use for parsing numbers. If unset the {@link Locale#US}
+	 * will be used ('.' as decimal place).
 	 * @param numberFormat the {@link NumberFormat} to use for number parsing
 	 */
 	public final void setNumberFormat(NumberFormat numberFormat) {
@@ -78,8 +78,8 @@ public class DefaultFieldSet implements FieldSet {
 	}
 
 	/**
-	 * The {@link DateFormat} to use for parsing numbers. If unset the default pattern is
-	 * ISO standard <code>yyyy/MM/dd</code>.
+	 * The {@link DateFormat} to use for parsing dates. If unset the default pattern is
+	 * ISO standard <code>yyyy-MM-dd</code>.
 	 * @param dateFormat the {@link DateFormat} to use for date parsing
 	 */
 	public void setDateFormat(DateFormat dateFormat) {
diff --git a/spring-batch-infrastructure/src/main/java/org/springframework/batch/item/file/transform/DefaultFieldSetFactory.java b/spring-batch-infrastructure/src/main/java/org/springframework/batch/item/file/transform/DefaultFieldSetFactory.java
index 7ef0fca1b..a958f50a1 100644
--- a/spring-batch-infrastructure/src/main/java/org/springframework/batch/item/file/transform/DefaultFieldSetFactory.java
+++ b/spring-batch-infrastructure/src/main/java/org/springframework/batch/item/file/transform/DefaultFieldSetFactory.java
@@ -1,5 +1,5 @@
 /*
- * Copyright 2009-2012 the original author or authors.
+ * Copyright 2009-2023 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -23,6 +23,7 @@ import java.text.NumberFormat;
  * {@link FieldSet} required. Returns a {@link DefaultFieldSet} from both factory methods.
  *
  * @author Dave Syer
+ * @author Mahmoud Ben Hassine
  *
  */
 public class DefaultFieldSetFactory implements FieldSetFactory {
@@ -32,8 +33,8 @@ public class DefaultFieldSetFactory implements FieldSetFactory {
 	private NumberFormat numberFormat;
 
 	/**
-	 * The {@link NumberFormat} to use for parsing numbers. If unset the default locale
-	 * will be used.
+	 * The {@link NumberFormat} to use for parsing numbers. If unset then
+	 * {@link java.util.Locale#US} will be used.
 	 * @param numberFormat the {@link NumberFormat} to use for number parsing
 	 */
 	public void setNumberFormat(NumberFormat numberFormat) {
@@ -41,8 +42,8 @@ public class DefaultFieldSetFactory implements FieldSetFactory {
 	}
 
 	/**
-	 * The {@link DateFormat} to use for parsing numbers. If unset the default pattern is
-	 * ISO standard <code>yyyy/MM/dd</code>.
+	 * The {@link DateFormat} to use for parsing dates. If unset the default pattern is
+	 * ISO standard <code>yyyy-MM-dd</code>.
 	 * @param dateFormat the {@link DateFormat} to use for date parsing
 	 */
 	public void setDateFormat(DateFormat dateFormat) {