From a1c6bd488e2be97c5c8539ea5d2a31d3930f9bfd Mon Sep 17 00:00:00 2001 From: dsyer Date: Tue, 26 Feb 2008 14:34:29 +0000 Subject: [PATCH] Incomplete - task 84: Fix samples Expect exception in skip test --- .../batch/execution/step/ItemOrientedStepTests.java | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/spring-batch-execution/src/test/java/org/springframework/batch/execution/step/ItemOrientedStepTests.java b/spring-batch-execution/src/test/java/org/springframework/batch/execution/step/ItemOrientedStepTests.java index 081a4b2be..10722d7bc 100644 --- a/spring-batch-execution/src/test/java/org/springframework/batch/execution/step/ItemOrientedStepTests.java +++ b/spring-batch-execution/src/test/java/org/springframework/batch/execution/step/ItemOrientedStepTests.java @@ -40,6 +40,7 @@ import org.springframework.batch.execution.scope.StepScope; import org.springframework.batch.execution.scope.StepSynchronizationManager; import org.springframework.batch.execution.step.support.JobRepositorySupport; import org.springframework.batch.execution.step.support.LimitCheckingItemSkipPolicy; +import org.springframework.batch.execution.step.support.SkipLimitExceededException; import org.springframework.batch.execution.step.support.StepInterruptionPolicy; import org.springframework.batch.item.ExecutionContext; import org.springframework.batch.item.ItemReader; @@ -368,12 +369,17 @@ public class ItemOrientedStepTests extends TestCase { } public void testApplyConfigurationWithZeroSkipLimit() throws Exception { - itemOrientedStep.setItemSkipPolicy(new LimitCheckingItemSkipPolicy(0)); + itemOrientedStep.setItemSkipPolicy(new LimitCheckingItemSkipPolicy(0, Collections.singletonList(Exception.class))); itemOrientedStep.applyConfiguration(); JobExecution jobExecution = new JobExecution(jobInstance); StepExecution stepExecution = new StepExecution(itemOrientedStep, jobExecution); - assertEquals(false, itemOrientedStep.getItemSkipPolicy().shouldSkip(new RuntimeException(), + try { + assertEquals(false, itemOrientedStep.getItemSkipPolicy().shouldSkip(new RuntimeException(), stepExecution.createStepContribution())); + fail("Expected SkipLimitExceededException"); + } catch (SkipLimitExceededException e) { + // expected + } } public void testApplyConfigurationWithNonZeroSkipLimit() throws Exception {