Spring/spring-batch
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

IN PROGRESS - BATCH-601: Findbugs code audit

Browse Source
This commit is contained in:
robokaso
2008-04-24 14:02:39 +00:00
parent 11b094298d
commit a66bbd69c9
7 changed files with 15 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
spring-batch-infrastructure/src/test/java/org/springframework/batch/item/file/FlatFileItemReaderBasicTests.java
View File

@@ -319,7 +319,7 @@ public class FlatFileItemReaderBasicTests extends TestCase {
return str.indexOf(searchStr) != -1;
}
private class NonExistentResource extends AbstractResource {
private static class NonExistentResource extends AbstractResource {
public NonExistentResource() {
}

2
spring-batch-infrastructure/src/test/java/org/springframework/batch/item/file/FlatFileItemReaderCommonTests.java
View File

@@ -10,7 +10,7 @@ import org.springframework.core.io.Resource;
public class FlatFileItemReaderCommonTests extends CommonItemStreamItemReaderTests {
private final String FOOS = "1 \n 2 \n 3 \n 4 \n 5 \n";
private static final String FOOS = "1 \n 2 \n 3 \n 4 \n 5 \n";
protected ItemReader getItemReader() throws Exception {
FlatFileItemReader tested = new FlatFileItemReader();

10
spring-batch-infrastructure/src/test/java/org/springframework/batch/item/transform/ItemTransformerItemWriterFunctionalTests.java
View File

@@ -54,16 +54,16 @@ public class ItemTransformerItemWriterFunctionalTests extends TestCase {
itemTransformerItemWriter.write(new Foo());
}
public class Foo {
private static class Foo {
}
public class Bar {
private static class Bar {
public Bar(Foo foo) {
}
}
public class Foobar{
private static class Foobar{
public Foobar(Bar bar){}
}
@@ -85,7 +85,7 @@ public class ItemTransformerItemWriterFunctionalTests extends TestCase {
}
}
public class BarWriter implements ItemWriter{
private static class BarWriter implements ItemWriter{
public void write(Object item) throws Exception {
assertTrue(item instanceof Bar);
@@ -99,7 +99,7 @@ public class ItemTransformerItemWriterFunctionalTests extends TestCase {
}
public class FoobarWriter implements ItemWriter{
private static class FoobarWriter implements ItemWriter{
public void write(Object item) throws Exception {
assertTrue(item instanceof Foobar);

2
spring-batch-infrastructure/src/test/java/org/springframework/batch/item/xml/StaxEventItemReaderTests.java
View File

@@ -222,7 +222,7 @@ public class StaxEventItemReaderTests extends TestCase {
newSource.setOpenCalled(false);
// calling read again should require re-initialization because of close
try {
item = newSource.read();
newSource.read();
fail("Expected ReaderNotOpenException");
} catch (ReaderNotOpenException e) {
// expected

2
spring-batch-infrastructure/src/test/java/org/springframework/batch/retry/support/RetrySynchronizationManagerTests.java
View File

@@ -29,8 +29,6 @@ import org.springframework.batch.retry.support.RetryTemplate;
*/
public class RetrySynchronizationManagerTests extends TestCase {
int count = 0;
RetryTemplate template = new RetryTemplate();
protected void setUp() throws Exception {