Spring/spring-batch
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

RESOLVED - issue BATCH-1518: Add optimization for commit-interval=1

Browse Source
This commit is contained in:
dsyer
2010-03-01 10:21:57 +00:00
parent 598301de8d
commit b6aca5fa05
3 changed files with 40 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
spring-batch-core/src/test/java/org/springframework/batch/core/step/item/FaultTolerantChunkProcessorTests.java
View File

@@ -154,6 +154,30 @@ public class FaultTolerantChunkProcessorTests {
assertEquals(0, contribution.getFilterCount());
}
@Test
public void testWriteSkipOnExceptionWithTrivialChunk() throws Exception {
processor.setWriteSkipPolicy(new AlwaysSkipItemSkipPolicy());
processor.setItemWriter(new ItemWriter<String>() {
public void write(List<? extends String> items) throws Exception {
if (items.contains("fail")) {
throw new RuntimeException("Expected Exception!");
}
}
});
Chunk<String> inputs = new Chunk<String>(Arrays.asList("fail"));
try {
processor.process(contribution, inputs);
fail("Expected RuntimeException");
}
catch (RuntimeException e) {
assertEquals("Expected Exception!", e.getMessage());
}
processor.process(contribution, inputs);
assertEquals(1, contribution.getSkipCount());
assertEquals(0, contribution.getWriteCount());
assertEquals(0, contribution.getFilterCount());
}
@Test
public void testTransformWithExceptionAndNoRollback() throws Exception {
processor.setItemProcessor(new ItemProcessor<String, String>() {
@@ -200,11 +224,11 @@ public class FaultTolerantChunkProcessorTests {
assertEquals(1, chunk.getItems().size());
processor.process(contribution, chunk);
assertEquals(0, chunk.getItems().size());
// foo is written twice because the failure is detected on the second
// attempt when throttling
// foo is written once because it the failure is detected before it is
// committed the first time
assertEquals("[foo, bar]", list.toString());
// but the after listener is only called once, which is important
assertEquals(2, after.size());
// the after listener is called once per successful item, which is important
assertEquals("[foo, bar]", after.toString());
}
@Test

8
spring-batch-core/src/test/java/org/springframework/batch/core/step/item/FaultTolerantStepFactoryBeanRetryTests.java
View File

@@ -304,7 +304,7 @@ public class FaultTolerantStepFactoryBeanRetryTests {
assertEquals(expectedOutput, written);
assertEquals("[a, b, c, d, e, f, null]", provided.toString());
assertEquals("[a, b, b, b, b, b, b, c, d, d, d, d, d, d, e, f]", processed.toString());
assertEquals("[a, b, b, b, b, b, c, d, d, d, d, d, e, f]", processed.toString());
assertEquals("[b, d]", recovered.toString());
}
@@ -361,7 +361,7 @@ public class FaultTolerantStepFactoryBeanRetryTests {
assertEquals(7, provided.size());
// [a, b, c, a, b, c, a, b, c, a, b, c, a, b, c, a, b, c, d, e, f, d,
// e, f, d, e, f, d, e, f, d, e, f, d, e, f]
System.err.println(processed);
// System.err.println(processed);
assertEquals(36, processed.size());
// [b, d]
assertEquals(2, recovered.size());
@@ -405,7 +405,7 @@ public class FaultTolerantStepFactoryBeanRetryTests {
assertEquals(1, provided.size());
// the failed items are tried up to the limit (but only precisely so if
// the commit interval is 1)
assertEquals("[b, b, b, b, b]", processed.toString());
assertEquals("[b, b, b, b]", processed.toString());
// []
assertEquals(0, recovered.size());
assertEquals(1, stepExecution.getReadCount());
@@ -496,7 +496,7 @@ public class FaultTolerantStepFactoryBeanRetryTests {
assertEquals(0, stepExecution.getSkipCount());
// [b]
assertEquals(1, provided.size());
assertEquals("[b, b, b, b, b]", processed.toString());
assertEquals("[b, b, b, b]", processed.toString());
// []
assertEquals(0, recovered.size());
assertEquals(1, stepExecution.getReadCount());