Spring/spring-batch
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

BATCH-514:Additional small refactorings on Jdbc readers.

Browse Source
This commit is contained in:
lucasward
2008-03-27 04:37:58 +00:00
parent 2faea9d266
commit b876649cb9
3 changed files with 39 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
spring-batch-core/src/test/java/org/springframework/batch/core/resource/JdbcCursorItemReaderPreparedStatementIntegrationTests.java
View File

@@ -32,7 +32,7 @@ public class JdbcCursorItemReaderPreparedStatementIntegrationTests extends
itemReader.setMaxRows(100);
itemReader.setQueryTimeout(1000);
itemReader.setSaveState(true);
JobParametersPreparedStatementSetter pss = new JobParametersPreparedStatementSetter();
StepExecutionPreparedStatementSetter pss = new StepExecutionPreparedStatementSetter();
JobParameters jobParameters = new JobParametersBuilder().addLong("begin.id", new Long(1)).addLong("end.id", new Long(4)).toJobParameters();
JobInstance jobInstance = new JobInstance(new Long(1), jobParameters, new SimpleJob());
JobExecution jobExecution = new JobExecution(jobInstance, new Long(2));

31
spring-batch-core/src/test/java/org/springframework/batch/core/resource/JobParametersPreparedStatementSetterTests.java
View File

@@ -27,6 +27,7 @@ import org.springframework.batch.core.JobParametersBuilder;
import org.springframework.batch.core.StepExecution;
import org.springframework.batch.core.job.SimpleJob;
import org.springframework.batch.core.step.tasklet.TaskletStep;
import org.springframework.batch.item.ExecutionContext;
import org.springframework.jdbc.core.JdbcTemplate;
import org.springframework.jdbc.core.RowCallbackHandler;
import org.springframework.test.AbstractTransactionalDataSourceSpringContextTests;
@@ -38,7 +39,8 @@ import org.springframework.test.AbstractTransactionalDataSourceSpringContextTest
public class JobParametersPreparedStatementSetterTests extends AbstractTransactionalDataSourceSpringContextTests {
JdbcTemplate jdbcTemplate;
JobParametersPreparedStatementSetter pss;
StepExecutionPreparedStatementSetter pss;
StepExecution stepExecution;
protected String[] getConfigLocations() {
return new String[] { "data-source-context.xml" };
@@ -47,11 +49,11 @@ public class JobParametersPreparedStatementSetterTests extends AbstractTransacti
protected void onSetUpInTransaction() throws Exception {
super.onSetUpInTransaction();
pss = new JobParametersPreparedStatementSetter();
pss = new StepExecutionPreparedStatementSetter();
JobParameters jobParameters = new JobParametersBuilder().addLong("begin.id", new Long(1)).addLong("end.id", new Long(4)).toJobParameters();
JobInstance jobInstance = new JobInstance(new Long(1), jobParameters, new SimpleJob());
JobExecution jobExecution = new JobExecution(jobInstance, new Long(2));
StepExecution stepExecution = new StepExecution(new TaskletStep(), jobExecution, new Long(3) );
stepExecution = new StepExecution(new TaskletStep(), jobExecution, new Long(3) );
pss.beforeStep(stepExecution);
jdbcTemplate = getJdbcTemplate();
}
@@ -104,4 +106,27 @@ public class JobParametersPreparedStatementSetterTests extends AbstractTransacti
}
}
public void testMixedProperties(){
ExecutionContext executionContext = new ExecutionContext();
executionContext.putLong("begin.id", 2);
stepExecution.setExecutionContext(executionContext);
pss.beforeStep(stepExecution);
List parameterNames = new ArrayList();
parameterNames.add("begin.id");
parameterNames.add("end.id");
pss.setParameterKeys(parameterNames);
final List results = new ArrayList();
jdbcTemplate.query("SELECT NAME from T_FOOS where ID > ? and ID < ?", pss, new RowCallbackHandler(){
public void processRow(ResultSet rs) throws SQLException {
results.add(rs.getString(1));
}});
assertEquals(1, results.size());
assertEquals("bar3", results.get(0));
}
}