Spring/spring-batch
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

BATCH-1247: Move aggregation from Processor to LineAggregator

Browse Source
This commit is contained in:
dhgarrette
2009-05-22 06:28:43 +00:00
parent bf2d9af030
commit b9589158a7
2 changed files with 23 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

41
spring-batch-samples/src/main/java/org/springframework/batch/sample/domain/order/internal/OrderProcessor.java → spring-batch-samples/src/main/java/org/springframework/batch/sample/domain/order/internal/OrderLineAggregator.java
View File

@@ -16,11 +16,8 @@
package org.springframework.batch.sample.domain.order.internal;
import java.util.ArrayList;
import java.util.List;
import java.util.Map;
import org.springframework.batch.item.ItemProcessor;
import org.springframework.batch.item.file.transform.LineAggregator;
import org.springframework.batch.sample.domain.order.LineItem;
import org.springframework.batch.sample.domain.order.Order;
@@ -29,38 +26,36 @@ import org.springframework.batch.sample.domain.order.Order;
* Converts <code>Order</code> object to a list of strings.
*
* @author Dave Syer
* @author Dan Garrette
*/
public class OrderProcessor implements ItemProcessor<Order, List<String>> {
public class OrderLineAggregator implements LineAggregator<Order> {
private static final String LINE_SEPARATOR = System.getProperty("line.separator");
/**
* Aggregators for all types of lines in the output file
*/
private Map<String, LineAggregator<Object>> aggregators;
/**
* Converts information from an Order object to a collection of Strings for
* output.
*
* @throws Exception
*/
public List<String> process(Order order) throws Exception {
public String aggregate(Order order) {
StringBuilder result = new StringBuilder();
List<String> result = new ArrayList<String>();
result.add(aggregators.get("header").aggregate(order));
result.add(aggregators.get("customer").aggregate(order));
result.add(aggregators.get("address").aggregate(order));
result.add(aggregators.get("billing").aggregate(order));
result.append(aggregators.get("header").aggregate(order) + LINE_SEPARATOR);
result.append(aggregators.get("customer").aggregate(order) + LINE_SEPARATOR);
result.append(aggregators.get("address").aggregate(order) + LINE_SEPARATOR);
result.append(aggregators.get("billing").aggregate(order) + LINE_SEPARATOR);
for (LineItem lineItem : order.getLineItems()) {
result.add(aggregators.get("item").aggregate(lineItem));
result.append(aggregators.get("item").aggregate(lineItem) + LINE_SEPARATOR);
}
result.add(aggregators.get("footer").aggregate(order));
result.append(aggregators.get("footer").aggregate(order));
return result;
return result.toString();
}
/**
* Set aggregators for all types of lines in the output file
*
* @param aggregators
*/
public void setAggregators(Map<String, LineAggregator<Object>> aggregators) {
this.aggregators = aggregators;
}

17
spring-batch-samples/src/main/resources/jobs/multilineOrderJob.xml
View File

@@ -54,23 +54,16 @@
<bean id="orderItemFieldSetMapper" class="org.springframework.batch.sample.domain.order.internal.mapper.OrderItemFieldSetMapper" />
<bean id="shippingFieldSetMapper" class="org.springframework.batch.sample.domain.order.internal.mapper.ShippingFieldSetMapper" />
<bean id="processor" class="org.springframework.batch.item.support.CompositeItemProcessor">
<property name="itemProcessors">
<list>
<bean class="org.springframework.batch.item.validator.ValidatingItemProcessor">
<constructor-arg ref="validator" />
</bean>
<bean class="org.springframework.batch.sample.domain.order.internal.OrderProcessor">
<property name="aggregators" ref="outputAggregators"/>
</bean>
</list>
</property>
<bean id="processor" class="org.springframework.batch.item.validator.ValidatingItemProcessor">
<constructor-arg ref="validator" />
</bean>
<bean id="fileItemWriter" class="org.springframework.batch.item.file.FlatFileItemWriter">
<property name="resource" value="file:target/test-outputs/multilineOrderOutput.txt" />
<property name="lineAggregator">
<bean class="org.springframework.batch.item.file.transform.RecursiveCollectionLineAggregator" />
<bean class="org.springframework.batch.sample.domain.order.internal.OrderLineAggregator">
<property name="aggregators" ref="outputAggregators"/>
</bean>
</property>
</bean>