Spring/spring-batch
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

RESOLVED - BATCH-963: ExecutionContext modifications in ItemStream.close(ExecutionContext) are not persisted

Browse Source 
removed ExecutionContext argument from ItemStream.close() signature
This commit is contained in:
robokaso
2008-12-10 12:06:03 +00:00
parent fe5828d3e5
commit c795098827
47 changed files with 93 additions and 95 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
spring-batch-core/src/test/java/org/springframework/batch/core/configuration/xml/TestReader.java
View File

@@ -42,7 +42,7 @@ public class TestReader extends AbstractTestComponent implements ItemReader<Stri
return null;
}
public void close(ExecutionContext executionContext)
public void close()
throws ItemStreamException {
}

2
spring-batch-core/src/test/java/org/springframework/batch/core/partition/ExampleItemReader.java
View File

@@ -43,7 +43,7 @@ public class ExampleItemReader implements ItemReader<String>, ItemStream {
return input[index++];
}
public void close(ExecutionContext executionContext) throws ItemStreamException {
public void close() throws ItemStreamException {
}
public void open(ExecutionContext executionContext) throws ItemStreamException {

2
spring-batch-core/src/test/java/org/springframework/batch/core/step/item/TaskletStepExceptionTests.java
View File

@@ -159,7 +159,7 @@ public class TaskletStepExceptionTests {
final RuntimeException exception = new RuntimeException();
taskletStep.setStreams(new ItemStream[] { new ItemStreamSupport() {
@Override
public void close(ExecutionContext executionContext) throws ItemStreamException {
public void close() throws ItemStreamException {
throw exception;
}
} });

6
spring-batch-core/src/test/java/org/springframework/batch/core/step/tasklet/TaskletStepTests.java
View File

@@ -656,7 +656,7 @@ public class TaskletStepTests {
step.setJobRepository(new JobRepositorySupport());
step.setStreams(new ItemStream[] { new ItemStreamSupport() {
public void close(ExecutionContext executionContext) throws ItemStreamException {
public void close() throws ItemStreamException {
throw new RuntimeException("Bar");
}
} });
@@ -679,8 +679,8 @@ public class TaskletStepTests {
public void testStatusForCloseFailedException() throws Exception {
MockRestartableItemReader itemReader = new MockRestartableItemReader() {
public void close(ExecutionContext executionContext) throws ItemStreamException {
super.close(executionContext);
public void close() throws ItemStreamException {
super.close();
// Simulate failure on rollback when stream resets
throw new RuntimeException("Bar");
}