Spring/spring-batch
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

BATCH-713: FlatFileItemWriter now requires open to be called before write. There are also some additional clarifying test cases to the tokenizer tests.

Browse Source
This commit is contained in:
lucasward
2008-07-03 18:36:52 +00:00
parent 9c57a5c569
commit cb3f23e4c5
5 changed files with 105 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
spring-batch-infrastructure/src/test/java/org/springframework/batch/item/file/FlatFileItemWriterTests.java
View File

@@ -103,6 +103,24 @@ public class FlatFileItemWriterTests extends TestCase {
return reader.readLine();
}
public void testWriteWithMultipleOpen() throws Exception{
writer.open(executionContext);
writer.write("test1");
writer.flush();
writer.open(executionContext);
writer.write("test2");
writer.flush();
assertEquals("test1", readLine());
assertEquals("test2", readLine());
}
public void testOpenTwice(){
//opening the writer twice should cause no issues
writer.open(executionContext);
writer.open(executionContext);
}
/**
* Regular usage of <code>write(String)</code> method
@@ -131,6 +149,7 @@ public class FlatFileItemWriterTests extends TestCase {
}
});
Object data = new Object();
writer.open(executionContext);
writer.write(data);
writer.flush();
String lineFromFile = readLine();
@@ -150,6 +169,7 @@ public class FlatFileItemWriterTests extends TestCase {
}
});
Object data = new Object();
writer.open(executionContext);
writer.write(data);
writer.flush();
String lineFromFile = readLine();
@@ -168,6 +188,7 @@ public class FlatFileItemWriterTests extends TestCase {
return new DefaultFieldSet(new String[] { "FOO:" + data });
}
});
writer.open(executionContext);
writer.write(TEST_STRING);
writer.flush();
String lineFromFile = readLine();
@@ -181,6 +202,7 @@ public class FlatFileItemWriterTests extends TestCase {
*/
public void testWriteRecord() throws Exception {
String args = "1";
writer.open(executionContext);
writer.write(args);
writer.flush();
String lineFromFile = readLine();
@@ -189,6 +211,7 @@ public class FlatFileItemWriterTests extends TestCase {
public void testWriteRecordWithrecordSeparator() throws Exception {
writer.setLineSeparator("|");
writer.open(executionContext);
writer.write("1");
writer.write("2");
writer.flush();
@@ -197,6 +220,7 @@ public class FlatFileItemWriterTests extends TestCase {
}
public void testRollback() throws Exception {
writer.open(executionContext);
writer.write("testLine1");
// rollback
rollback();
@@ -207,6 +231,7 @@ public class FlatFileItemWriterTests extends TestCase {
}
public void testCommit() throws Exception {
writer.open(executionContext);
writer.write("testLine1");
// rollback
commit();

2
spring-batch-infrastructure/src/test/java/org/springframework/batch/item/file/transform/DelimitedLineTokenizerTests.java
View File

@@ -178,6 +178,4 @@ public class DelimitedLineTokenizerTests extends TestCase {
assertEquals(4, line.getFieldCount());
assertEquals("", line.readString(2));
}
}

9
spring-batch-infrastructure/src/test/java/org/springframework/batch/item/file/transform/FixedLengthTokenizerTests.java
View File

@@ -35,6 +35,15 @@ public class FixedLengthTokenizerTests extends TestCase {
FieldSet tokens = tokenizer.tokenize("");
assertEquals(0, tokens.getFieldCount());
}
public void testTokenizeSmallerStringThanRanges() {
tokenizer.setColumns(new Range[] {new Range(1,5),new Range(6,10),new Range(11,15)});
FieldSet tokens = tokenizer.tokenize("12345");
assertEquals(3, tokens.getFieldCount());
assertEquals("12345", tokens.readString(0));
assertEquals("", tokens.readString(1));
assertEquals("", tokens.readString(2));
}
public void testTokenizeNullString() {
tokenizer.setColumns(new Range[] {new Range(1,5),new Range(6,10),new Range(11,15)});