Spring/spring-batch
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

RESOLVED - BATCH-650: Use FORWARD_ONLY as scroll mode in HibernateCursorItemReader

Browse Source 
added item buffer and made the cursor forward-only (+ had to fix samples using stateful items with rollback)
This commit is contained in:
robokaso
2008-06-04 13:43:00 +00:00
parent c21032332b
commit d377e4c5c3
7 changed files with 95 additions and 55 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
spring-batch-samples/src/main/java/org/springframework/batch/sample/domain/CustomerCredit.java
View File

@@ -52,8 +52,12 @@ public class CustomerCredit {
this.name = name;
}
public void increaseCreditBy(BigDecimal sum) {
this.credit = this.credit.add(sum);
public CustomerCredit increaseCreditBy(BigDecimal sum) {
CustomerCredit newCredit = new CustomerCredit();
newCredit.credit = this.credit.add(sum);
newCredit.name = this.name;
newCredit.id = this.id;
return newCredit;
}
public boolean equals(Object o) {

3
spring-batch-samples/src/main/java/org/springframework/batch/sample/item/writer/BatchSqlCustomerCreditIncreaseWriter.java
View File

@@ -45,8 +45,7 @@ public class BatchSqlCustomerCreditIncreaseWriter implements ItemWriter, Initial
* @see org.springframework.batch.item.processor.DelegatingItemWriter#doProcess(java.lang.Object)
*/
public void write(Object data) throws Exception {
CustomerCredit customerCredit = (CustomerCredit) data;
customerCredit.increaseCreditBy(FIXED_AMOUNT);
CustomerCredit customerCredit = ((CustomerCredit) data).increaseCreditBy(FIXED_AMOUNT);
delegate.write(customerCredit);
}

3
spring-batch-samples/src/main/java/org/springframework/batch/sample/item/writer/CustomerCreditIncreaseWriter.java
View File

@@ -29,8 +29,7 @@ public class CustomerCreditIncreaseWriter extends AbstractItemWriter {
* @see org.springframework.batch.item.processor.DelegatingItemWriter#doProcess(java.lang.Object)
*/
public void write(Object data) throws Exception {
CustomerCredit customerCredit = (CustomerCredit) data;
customerCredit.increaseCreditBy(FIXED_AMOUNT);
CustomerCredit customerCredit = ((CustomerCredit) data).increaseCreditBy(FIXED_AMOUNT);
customerCreditDao.writeCredit(customerCredit);
}

3
spring-batch-samples/src/test/java/org/springframework/batch/sample/AbstractCustomerCreditIncreaseTests.java
View File

@@ -108,10 +108,13 @@ public abstract class AbstractCustomerCreditIncreaseTests extends AbstractValida
public Object mapRow(ResultSet rs, int rowNum) throws SQLException {
final BigDecimal creditBeforeUpdate = (BigDecimal) creditsBeforeUpdate.get(rowNum);
System.out.print("BEFORE:" + creditBeforeUpdate);
final BigDecimal expectedCredit = creditBeforeUpdate.add(CREDIT_INCREASE);
System.out.print(" EXPECTED:" + expectedCredit);
if (expectedCredit.equals(rs.getBigDecimal(CREDIT_COLUMN))) {
matches.add(rs.getBigDecimal(ID_COLUMN));
}
System.out.println(" ACTUAL: " + rs.getBigDecimal(CREDIT_COLUMN));
return null;
}

47
spring-batch-samples/src/test/java/org/springframework/batch/sample/item/writer/CustomerCreditIncreaseProcessorTests.java
View File

@@ -4,50 +4,41 @@ import java.math.BigDecimal;
import junit.framework.TestCase;
import org.easymock.MockControl;
import org.springframework.batch.sample.dao.CustomerCreditDao;
import org.springframework.batch.sample.domain.CustomerCredit;
import org.springframework.batch.sample.item.writer.CustomerCreditIncreaseWriter;
/**
* Tests for {@link CustomerCreditIncreaseWriter}.
*
* @author Robert Kasanicky
*/
public class CustomerCreditIncreaseProcessorTests extends TestCase{
public class CustomerCreditIncreaseProcessorTests extends TestCase {
private CustomerCreditIncreaseWriter writer = new CustomerCreditIncreaseWriter();
private CustomerCreditDao outputSource;
private MockControl outputSourceControl = MockControl.createStrictControl(CustomerCreditDao.class);
private CustomerCredit customerCredit = new CustomerCredit();
protected void setUp() throws Exception {
customerCredit.setId(1);
customerCredit.setName("testCustomer");
outputSource = (CustomerCreditDao) outputSourceControl.getMock();
writer.setCustomerCreditDao(outputSource);
}
/**
* Increases customer's credit by fixed value
*/
public void testProcess() throws Exception {
BigDecimal oldCredit = new BigDecimal(10.54);
final BigDecimal oldCredit = new BigDecimal(10.54);
class CustomerDaoStub implements CustomerCreditDao {
public void writeCredit(CustomerCredit customerCredit) throws Exception {
BigDecimal expectedCredit = oldCredit.add(CustomerCreditIncreaseWriter.FIXED_AMOUNT);
assertTrue(customerCredit.getCredit().compareTo(expectedCredit) == 0);
}
}
CustomerCredit customerCredit = new CustomerCredit();
customerCredit.setId(1);
customerCredit.setName("testCustomer");
writer.setCustomerCreditDao(new CustomerDaoStub());
customerCredit.setCredit(oldCredit);
outputSource.writeCredit(customerCredit);
outputSourceControl.setVoidCallable();
outputSourceControl.replay();
writer.write(customerCredit);
BigDecimal newCredit = customerCredit.getCredit();
BigDecimal expectedCredit = oldCredit.add(CustomerCreditIncreaseWriter.FIXED_AMOUNT);
assertTrue(newCredit.compareTo(expectedCredit) == 0);
outputSourceControl.verify();
}
}