Spring/spring-batch
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

OPEN - issue BATCH-324: Step as factory for StepExecutor

Browse Source 
http://jira.springframework.org/browse/BATCH-324

Consolidate changes and remove unnecessary methods from interfaces
This commit is contained in:
dsyer
2008-01-29 15:48:16 +00:00
parent ea818d8401
commit d4d09d2ad8
11 changed files with 238 additions and 300 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
spring-batch-core/src/main/java/org/springframework/batch/core/domain/Step.java
View File

@@ -16,7 +16,6 @@
package org.springframework.batch.core.domain;
import org.springframework.batch.core.executor.StepExecutor;
import org.springframework.batch.core.tasklet.Tasklet;
/**
* Batch domain interface representing the configuration of a step. As with the
@@ -35,11 +34,6 @@ public interface Step {
*/
String getName();
/**
* @return the {@link Tasklet} instance to execute for each item processed.
*/
Tasklet getTasklet();
/**
* @return true if a step that is already marked as complete can be started
* again.

21
spring-batch-core/src/main/java/org/springframework/batch/core/domain/StepSupport.java
View File

@@ -16,7 +16,6 @@
package org.springframework.batch.core.domain;
import org.springframework.batch.core.executor.StepExecutor;
import org.springframework.batch.core.tasklet.Tasklet;
import org.springframework.beans.factory.BeanNameAware;
/**
@@ -33,8 +32,6 @@ public class StepSupport implements Step, BeanNameAware {
private int startLimit = Integer.MAX_VALUE;
private Tasklet tasklet;
private boolean allowStartIfComplete;
private boolean saveRestartData = false;
@@ -106,24 +103,6 @@ public class StepSupport implements Step, BeanNameAware {
this.startLimit = startLimit;
}
/*
* (non-Javadoc)
*
* @see org.springframework.batch.core.configuration.StepConfiguration#getTasklet()
*/
public Tasklet getTasklet() {
return this.tasklet;
}
/**
* Public setter for the tasklet.
*
* @param tasklet the tasklet to set
*/
public void setTasklet(Tasklet tasklet) {
this.tasklet = tasklet;
}
/*
* (non-Javadoc)
*

7
spring-batch-core/src/main/java/org/springframework/batch/core/executor/StepExecutor.java
View File

@@ -63,11 +63,4 @@ public interface StepExecutor {
StepExecution stepExecution) throws StepInterruptedException,
BatchCriticalException;
/**
* Apply the configuration by inspecting it to see if it has any relevant
* policy information. Should be called before any calls to process.
*
* @param configuration
*/
void applyConfiguration(Step configuration);
}