Spring/spring-batch
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

RESOLVED - issue BATCH-451: rename DefaultStepFactoryBean to SimpleStepFactoryBean

Browse Source 
http://jira.springframework.org/browse/BATCH-451
This commit is contained in:
robokaso
2008-03-13 12:31:07 +00:00
parent 66b61a78d8
commit d7e08ae574
7 changed files with 30 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
spring-batch-core/src/main/java/org/springframework/batch/core/step/DefaultStepFactoryBean.java → spring-batch-core/src/main/java/org/springframework/batch/core/step/SimpleStepFactoryBean.java
View File

@@ -32,10 +32,16 @@ import org.springframework.core.task.TaskExecutor;
* Most common configuration options for simple steps should be found here. Use
* this factory bean instead of creating a {@link Step} implementation manually.
*
* This factory does not support configuration of fault-tolerant behavior, use
* appropriate subclass of this factory bean to configure skip or retry.
*
* @see SkipLimitStepFactoryBean
* @see StatefulRetryStepFactoryBean
*
* @author Dave Syer
*
*/
public class DefaultStepFactoryBean extends AbstractStepFactoryBean {
public class SimpleStepFactoryBean extends AbstractStepFactoryBean {
private int commitInterval = 0;
@@ -72,7 +78,7 @@ public class DefaultStepFactoryBean extends AbstractStepFactoryBean {
public void setStreams(ItemStream[] streams) {
this.streams = streams;
}
/**
* The listeners to inject into the {@link Step}. Any instance of
* {@link BatchListener} can be used, and will then receive callbacks at the
@@ -176,7 +182,6 @@ public class DefaultStepFactoryBean extends AbstractStepFactoryBean {
BatchListenerFactoryHelper helper = new BatchListenerFactoryHelper();
if (commitInterval > 0) {
RepeatTemplate chunkOperations = new RepeatTemplate();
chunkOperations.setCompletionPolicy(new SimpleCompletionPolicy(commitInterval));
@@ -187,7 +192,6 @@ public class DefaultStepFactoryBean extends AbstractStepFactoryBean {
StepListener[] stepListeners = helper.getStepListeners(listeners);
itemReader = helper.getItemReader(itemReader, listeners);
itemWriter = helper.getItemWriter(itemWriter, listeners);
// In case they are used by subclasses:
setItemReader(itemReader);
@@ -196,7 +200,7 @@ public class DefaultStepFactoryBean extends AbstractStepFactoryBean {
step.setStepListeners(stepListeners);
stepOperations = new RepeatTemplate();
if (taskExecutor != null) {
TaskExecutorRepeatTemplate repeatTemplate = new TaskExecutorRepeatTemplate();
repeatTemplate.setTaskExecutor(taskExecutor);
@@ -211,5 +215,5 @@ public class DefaultStepFactoryBean extends AbstractStepFactoryBean {
step.setItemHandler(itemHandler);
}
}

2
spring-batch-core/src/main/java/org/springframework/batch/core/step/SkipLimitStepFactoryBean.java
View File

@@ -8,7 +8,7 @@ import org.springframework.batch.repeat.exception.SimpleLimitExceptionHandler;
* Factory bean for step that allows configuring skip limit.
*
*/
public class SkipLimitStepFactoryBean extends DefaultStepFactoryBean {
public class SkipLimitStepFactoryBean extends SimpleStepFactoryBean {
private int skipLimit = 0;

2
spring-batch-core/src/main/java/org/springframework/batch/core/step/StatefulRetryStepFactoryBean.java
View File

@@ -47,7 +47,7 @@ import org.springframework.batch.retry.support.RetryTemplate;
* @author Dave Syer
*
*/
public class StatefulRetryStepFactoryBean extends DefaultStepFactoryBean {
public class StatefulRetryStepFactoryBean extends SimpleStepFactoryBean {
private ItemKeyGenerator itemKeyGenerator;