Spring/spring-batch
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

RESOLVED - issue BATCH-1496: Expose retry-policy in namespace configuration

Browse Source
This commit is contained in:
dsyer
2010-01-30 10:28:57 +00:00
parent 5512054289
commit d8cc4d105d
6 changed files with 126 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

61
spring-batch-core/src/test/java/org/springframework/batch/core/configuration/xml/ChunkElementParserTests.java
View File

@@ -34,6 +34,7 @@ import org.springframework.batch.item.ItemStream;
import org.springframework.batch.item.support.CompositeItemStream;
import org.springframework.batch.retry.RetryListener;
import org.springframework.batch.retry.listener.RetryListenerSupport;
import org.springframework.batch.retry.policy.SimpleRetryPolicy;
import org.springframework.beans.PropertyAccessorUtils;
import org.springframework.beans.factory.BeanCreationException;
import org.springframework.context.ApplicationContext;
@@ -65,6 +66,27 @@ public class ChunkElementParserTests {
assertTrue("Wrong processor type", chunkProcessor instanceof SimpleChunkProcessor);
}
@Test
public void testRetryPolicyAttribute() throws Exception {
ConfigurableApplicationContext context = new ClassPathXmlApplicationContext(
"org/springframework/batch/core/configuration/xml/ChunkElementRetryPolicyParserTests-context.xml");
Map<Class<? extends Throwable>, Boolean> retryable = getNestedExceptionMap("s1", context,
"tasklet.chunkProcessor.batchRetryTemplate.regular.retryPolicy.exceptionClassifier",
"exceptionClassifier");
assertEquals(2, retryable.size());
assertTrue(retryable.containsKey(NullPointerException.class));
assertTrue(retryable.containsKey(ArithmeticException.class));
}
@Test
public void testRetryPolicyElement() throws Exception {
ConfigurableApplicationContext context = new ClassPathXmlApplicationContext(
"org/springframework/batch/core/configuration/xml/ChunkElementRetryPolicyParserTests-context.xml");
SimpleRetryPolicy policy = (SimpleRetryPolicy) getPolicy("s2", context,
"tasklet.chunkProcessor.batchRetryTemplate.regular.retryPolicy.exceptionClassifier");
assertEquals(2, policy.getMaxAttempts());
}
@Test
public void testSkipPolicyAttribute() throws Exception {
ConfigurableApplicationContext context = new ClassPathXmlApplicationContext(
@@ -227,19 +249,44 @@ public class ChunkElementParserTests {
@SuppressWarnings("unchecked")
private Map<Class<? extends Throwable>, Boolean> getNestedExceptionMap(String stepName, ApplicationContext ctx,
String componentName, String classifierName) throws Exception {
Object policy = getPolicy(stepName, ctx, componentName);
Object exceptionClassifier = ReflectionTestUtils.getField(policy, classifierName);
return (Map<Class<? extends Throwable>, Boolean>) ReflectionTestUtils.getField(exceptionClassifier,
"classified");
}
private Object getPolicy(String stepName, ApplicationContext ctx, String componentName) throws Exception {
@SuppressWarnings("unchecked")
SubclassClassifier<Throwable, Object> classifier = (SubclassClassifier<Throwable, Object>) getNestedPathInStep(stepName, ctx, componentName);
Object policy = classifier.classify(new Exception());
return policy;
}
@SuppressWarnings("unchecked")
private Object getNestedPathInStep(String stepName, ApplicationContext ctx, String path) throws Exception {
Map<String, Step> beans = ctx.getBeansOfType(Step.class);
assertTrue(beans.containsKey(stepName));
Object step = ctx.getBean(stepName);
assertTrue(step instanceof TaskletStep);
Object policy = step;
String path = componentName;
return getNestedPath(step, path);
}
/**
* @param object the target object
* @param path the path to the required field
* @return
*/
private Object getNestedPath(Object object, String path) {
while (StringUtils.hasText(path)) {
int index = PropertyAccessorUtils.getFirstNestedPropertySeparatorIndex(path);
if (index < 0) {
index = path.length();
}
policy = ReflectionTestUtils.getField(policy, path.substring(0, index));
object = ReflectionTestUtils.getField(object, path.substring(0, index));
if (index < path.length()) {
path = path.substring(index + 1);
}
@@ -247,13 +294,7 @@ public class ChunkElementParserTests {
path = "";
}
}
SubclassClassifier<Throwable, Object> classifier = (SubclassClassifier<Throwable, Object>) policy;
policy = classifier.classify(new Exception());
Object exceptionClassifier = ReflectionTestUtils.getField(policy, classifierName);
return (Map<Class<? extends Throwable>, Boolean>) ReflectionTestUtils.getField(exceptionClassifier,
"classified");
return object;
}
private void containsClassified(Map<Class<? extends Throwable>, Boolean> classified,