From dbd2089c4705e7968ecf4c9b5f716e6f9a527f4e Mon Sep 17 00:00:00 2001 From: Fabio Molignoni Date: Tue, 2 Apr 2024 20:37:20 +0200 Subject: [PATCH] Set default ignoreWarnings to true in JdbcCursorItemReaderBuilder Resolves #4570 --- .../database/builder/JdbcCursorItemReaderBuilder.java | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/spring-batch-infrastructure/src/main/java/org/springframework/batch/item/database/builder/JdbcCursorItemReaderBuilder.java b/spring-batch-infrastructure/src/main/java/org/springframework/batch/item/database/builder/JdbcCursorItemReaderBuilder.java index a747228fa..980ae932c 100644 --- a/spring-batch-infrastructure/src/main/java/org/springframework/batch/item/database/builder/JdbcCursorItemReaderBuilder.java +++ b/spring-batch-infrastructure/src/main/java/org/springframework/batch/item/database/builder/JdbcCursorItemReaderBuilder.java @@ -1,5 +1,5 @@ /* - * Copyright 2016-2021 the original author or authors. + * Copyright 2016-2024 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -37,6 +37,7 @@ import org.springframework.util.StringUtils; * @author Mahmoud Ben Hassine * @author Ankur Trapasiya * @author Parikshit Dutta + * @author Fabio Molignoni * @since 4.0 */ public class JdbcCursorItemReaderBuilder { @@ -49,7 +50,7 @@ public class JdbcCursorItemReaderBuilder { private int queryTimeout = AbstractCursorItemReader.VALUE_NOT_SET; - private boolean ignoreWarnings; + private boolean ignoreWarnings = true; private boolean verifyCursorPosition = true; @@ -172,6 +173,11 @@ public class JdbcCursorItemReaderBuilder { return this; } + /** + * Set whether SQLWarnings should be ignored (only logged) or exception should be + * thrown. Defaults to {@code true}. + * @param ignoreWarnings if {@code true}, warnings are ignored + */ public JdbcCursorItemReaderBuilder ignoreWarnings(boolean ignoreWarnings) { this.ignoreWarnings = ignoreWarnings;