From e0977c3e48b86a5571eb604a359e0114f91a2193 Mon Sep 17 00:00:00 2001
From: lucasward <lucasward@2e8e966d-6415-0410-94b9-dc4e65435d03>
Date: Fri, 9 Nov 2007 07:29:28 +0000
Subject: [PATCH] BATCH-184:Reverted previous change.  I thought I had it
 working locally, but bamboo proved me wrong.

---
 .../repository/dao/HibernateJobDao.java       | 25 ++++---------------
 1 file changed, 5 insertions(+), 20 deletions(-)

diff --git a/execution/src/main/java/org/springframework/batch/execution/repository/dao/HibernateJobDao.java b/execution/src/main/java/org/springframework/batch/execution/repository/dao/HibernateJobDao.java
index bb275b109..4f54c31e1 100644
--- a/execution/src/main/java/org/springframework/batch/execution/repository/dao/HibernateJobDao.java
+++ b/execution/src/main/java/org/springframework/batch/execution/repository/dao/HibernateJobDao.java
@@ -75,16 +75,10 @@ public class HibernateJobDao extends HibernateDaoSupport implements JobDao {
 		List list = this.getHibernateTemplate().executeFind(
 				new HibernateCallback() {
 					public Object doInHibernate(Session session) {
-						String type = "JobInstance";
-						
-						if (jobRuntimeInformation instanceof ScheduledJobIdentifier) {
-							type = "ScheduledJobInstance";
-						}
-						
-						Criteria criteria = session.createCriteria(type);
-						
+						Criteria criteria = session
+								.createCriteria(JobInstance.class);
 						criteria.add(Expression.eq("identifier",
-								(ScheduledJobIdentifier)jobRuntimeInformation));
+								jobRuntimeInformation));
 						return criteria.list();
 					}
 				});
@@ -152,7 +146,8 @@ public class HibernateJobDao extends HibernateDaoSupport implements JobDao {
 							+ "before it can be updated.");
 		}
 
-		if (!exists(jobExecution)) {
+		if (getHibernateTemplate()
+				.get(JobExecution.class, jobExecution.getId()) == null) {
 			throw new NoSuchBatchDomainObjectException(
 					"Invalid JobExecution, ID " + jobExecution.getId()
 							+ " not found.");
@@ -161,16 +156,6 @@ public class HibernateJobDao extends HibernateDaoSupport implements JobDao {
 		getHibernateTemplate().update(jobExecution);
 	}
 
-	private boolean exists(final JobExecution jobExecution) {
-		JobExecution execution = (JobExecution) getHibernateTemplate().get(JobExecution.class, jobExecution.getId());
-		
-		if (execution != null) {
-			getHibernateTemplate().evict(execution);
-		} 
-		
-		return (execution != null);
-	}
-	
 	public List findJobExecutions(JobInstance job) {
 
 		Assert.notNull(job, "Job cannot be null.");