diff --git a/spring-batch-infrastructure/src/main/java/org/springframework/batch/item/file/FlatFileItemReader.java b/spring-batch-infrastructure/src/main/java/org/springframework/batch/item/file/FlatFileItemReader.java index e76facd45..df63d989f 100644 --- a/spring-batch-infrastructure/src/main/java/org/springframework/batch/item/file/FlatFileItemReader.java +++ b/spring-batch-infrastructure/src/main/java/org/springframework/batch/item/file/FlatFileItemReader.java @@ -182,7 +182,7 @@ public class FlatFileItemReader extends ExecutionContextUserSupport implements R int lineCount = getReader().getPosition(); try { FieldSet tokenizedLine = tokenizer.tokenize(line); - return fieldSetMapper.mapLine(tokenizedLine, lineCount); + return fieldSetMapper.mapLine(tokenizedLine); } catch (RuntimeException ex) { // add current line count to message and re-throw diff --git a/spring-batch-infrastructure/src/main/java/org/springframework/batch/item/file/mapping/BeanWrapperFieldSetMapper.java b/spring-batch-infrastructure/src/main/java/org/springframework/batch/item/file/mapping/BeanWrapperFieldSetMapper.java index 9bd69a6f4..81ee85b4e 100644 --- a/spring-batch-infrastructure/src/main/java/org/springframework/batch/item/file/mapping/BeanWrapperFieldSetMapper.java +++ b/spring-batch-infrastructure/src/main/java/org/springframework/batch/item/file/mapping/BeanWrapperFieldSetMapper.java @@ -99,7 +99,7 @@ public class BeanWrapperFieldSetMapper extends DefaultPropertyEditorRegistrar im /** * The bean name (id) for an object that can be populated from the field set - * that will be passed into {@link #mapLine(FieldSet, int)}. Typically a + * that will be passed into {@link #mapLine(FieldSet)}. Typically a * prototype scoped bean so that a new instance is returned for each field * set mapped. * @@ -115,7 +115,7 @@ public class BeanWrapperFieldSetMapper extends DefaultPropertyEditorRegistrar im /** * Public setter for the type of bean to create instead of using a prototype * bean. An object of this type will be created from its default constructor - * for every call to {@link #mapLine(FieldSet, int)}.
+ * for every call to {@link #mapLine(FieldSet)}.
* * Either this property or the prototype bean name must be specified, but * not both. @@ -150,9 +150,9 @@ public class BeanWrapperFieldSetMapper extends DefaultPropertyEditorRegistrar im * the {@link DataBinder} from {@link #createBinder(Object)} has errors * after binding). * - * @see org.springframework.batch.item.file.mapping.FieldSetMapper#mapLine(org.springframework.batch.item.file.mapping.FieldSet, int) + * @see org.springframework.batch.item.file.mapping.FieldSetMapper#mapLine(org.springframework.batch.item.file.mapping.FieldSet) */ - public Object mapLine(FieldSet fs, int rownum) { + public Object mapLine(FieldSet fs) { Object copy = getBean(); DataBinder binder = createBinder(copy); binder.bind(new MutablePropertyValues(getBeanProperties(copy, fs.getProperties()))); diff --git a/spring-batch-infrastructure/src/main/java/org/springframework/batch/item/file/mapping/FieldSetMapper.java b/spring-batch-infrastructure/src/main/java/org/springframework/batch/item/file/mapping/FieldSetMapper.java index 28096d2fe..8db68c002 100644 --- a/spring-batch-infrastructure/src/main/java/org/springframework/batch/item/file/mapping/FieldSetMapper.java +++ b/spring-batch-infrastructure/src/main/java/org/springframework/batch/item/file/mapping/FieldSetMapper.java @@ -20,27 +20,16 @@ package org.springframework.batch.item.file.mapping; * Interface that is used to map data obtained from a {@link FieldSet} into an * object. * - * @author tomas.slanina + * @author Tomas Slanina * @author Dave Syer * */ public interface FieldSetMapper { - /** - * Constant (negative) value indicating an unknown row number. - */ - public final static int ROW_NUMBER_UNKNOWN = -1; - /** * Method used to map data obtained from a {@link FieldSet} into an object. - * Implementations can do whatever they need to to convert the input into an - * object of the desired type. Often the row number is not used, and - * sometimes it is not available anyway, in which case its value will be - * {@link #ROW_NUMBER_UNKNOWN}. * * @param fs the {@link FieldSet} to map - * @param rownum the row number for the field set in the input source (if - * known) */ - public Object mapLine(FieldSet fs, int rownum); + public Object mapLine(FieldSet fs); } diff --git a/spring-batch-infrastructure/src/main/java/org/springframework/batch/item/file/mapping/PassThroughFieldSetMapper.java b/spring-batch-infrastructure/src/main/java/org/springframework/batch/item/file/mapping/PassThroughFieldSetMapper.java index ca44e5a75..d96e5f3b1 100644 --- a/spring-batch-infrastructure/src/main/java/org/springframework/batch/item/file/mapping/PassThroughFieldSetMapper.java +++ b/spring-batch-infrastructure/src/main/java/org/springframework/batch/item/file/mapping/PassThroughFieldSetMapper.java @@ -29,7 +29,7 @@ public class PassThroughFieldSetMapper implements FieldSetMapper, FieldSetCreato * (non-Javadoc) * @see org.springframework.batch.io.file.FieldSetMapper#mapLine(org.springframework.batch.io.file.FieldSet) */ - public Object mapLine(FieldSet fs, int rownum) { + public Object mapLine(FieldSet fs) { return fs; } diff --git a/spring-batch-infrastructure/src/test/java/org/springframework/batch/item/MultiResourceItemReaderFlatFileTests.java b/spring-batch-infrastructure/src/test/java/org/springframework/batch/item/MultiResourceItemReaderFlatFileTests.java index 84590dbd2..1aac541ac 100644 --- a/spring-batch-infrastructure/src/test/java/org/springframework/batch/item/MultiResourceItemReaderFlatFileTests.java +++ b/spring-batch-infrastructure/src/test/java/org/springframework/batch/item/MultiResourceItemReaderFlatFileTests.java @@ -15,7 +15,7 @@ public class MultiResourceItemReaderFlatFileTests extends CommonItemStreamItemRe FlatFileItemReader fileReader = new FlatFileItemReader(); fileReader.setFieldSetMapper(new FieldSetMapper() { - public Object mapLine(FieldSet fs, int rownum) { + public Object mapLine(FieldSet fs) { Foo foo = new Foo(); foo.setValue(fs.readInt(0)); return foo; diff --git a/spring-batch-infrastructure/src/test/java/org/springframework/batch/item/file/FlatFileItemReaderAdvancedTests.java b/spring-batch-infrastructure/src/test/java/org/springframework/batch/item/file/FlatFileItemReaderAdvancedTests.java index 2f070100b..014075668 100644 --- a/spring-batch-infrastructure/src/test/java/org/springframework/batch/item/file/FlatFileItemReaderAdvancedTests.java +++ b/spring-batch-infrastructure/src/test/java/org/springframework/batch/item/file/FlatFileItemReaderAdvancedTests.java @@ -52,7 +52,7 @@ public class FlatFileItemReaderAdvancedTests extends TestCase { }; private FieldSetMapper fieldSetMapper = new FieldSetMapper() { - public Object mapLine(FieldSet fs, int rownum) { + public Object mapLine(FieldSet fs) { return fs; } }; diff --git a/spring-batch-infrastructure/src/test/java/org/springframework/batch/item/file/FlatFileItemReaderBasicTests.java b/spring-batch-infrastructure/src/test/java/org/springframework/batch/item/file/FlatFileItemReaderBasicTests.java index 6e84304fd..542cf625b 100644 --- a/spring-batch-infrastructure/src/test/java/org/springframework/batch/item/file/FlatFileItemReaderBasicTests.java +++ b/spring-batch-infrastructure/src/test/java/org/springframework/batch/item/file/FlatFileItemReaderBasicTests.java @@ -59,7 +59,7 @@ public class FlatFileItemReaderBasicTests extends TestCase { }; private FieldSetMapper fieldSetMapper = new FieldSetMapper() { - public Object mapLine(FieldSet fs, int rownum) { + public Object mapLine(FieldSet fs) { return fs; } }; @@ -126,7 +126,7 @@ public class FlatFileItemReaderBasicTests extends TestCase { public void testReadWithMapperError() throws Exception { itemReader.setFieldSetMapper(new FieldSetMapper() { - public Object mapLine(FieldSet fs, int rownum) { + public Object mapLine(FieldSet fs) { throw new RuntimeException("foo"); } }); diff --git a/spring-batch-infrastructure/src/test/java/org/springframework/batch/item/file/FlatFileItemReaderCommonTests.java b/spring-batch-infrastructure/src/test/java/org/springframework/batch/item/file/FlatFileItemReaderCommonTests.java index 2f708614f..b49cef499 100644 --- a/spring-batch-infrastructure/src/test/java/org/springframework/batch/item/file/FlatFileItemReaderCommonTests.java +++ b/spring-batch-infrastructure/src/test/java/org/springframework/batch/item/file/FlatFileItemReaderCommonTests.java @@ -17,7 +17,7 @@ public class FlatFileItemReaderCommonTests extends CommonItemStreamItemReaderTes Resource resource = new ByteArrayResource(FOOS.getBytes()); tested.setResource(resource); tested.setFieldSetMapper(new FieldSetMapper() { - public Object mapLine(FieldSet fs, int rownum) { + public Object mapLine(FieldSet fs) { Foo foo = new Foo(); foo.setValue(fs.readInt(0)); return foo; diff --git a/spring-batch-infrastructure/src/test/java/org/springframework/batch/item/file/mapping/BeanWrapperFieldSetMapperTests.java b/spring-batch-infrastructure/src/test/java/org/springframework/batch/item/file/mapping/BeanWrapperFieldSetMapperTests.java index 77ca7fae0..6c6c76b97 100644 --- a/spring-batch-infrastructure/src/test/java/org/springframework/batch/item/file/mapping/BeanWrapperFieldSetMapperTests.java +++ b/spring-batch-infrastructure/src/test/java/org/springframework/batch/item/file/mapping/BeanWrapperFieldSetMapperTests.java @@ -63,7 +63,7 @@ public class BeanWrapperFieldSetMapperTests extends TestCase { FieldSet fieldSet = new DefaultFieldSet(new String[] { "This is some dummy string", "true", "C" }, new String[] { "varString", "varBoolean", "varChar" }); - TestObject result = (TestObject) mapper.mapLine(fieldSet, FieldSetMapper.ROW_NUMBER_UNKNOWN); + TestObject result = (TestObject) mapper.mapLine(fieldSet); assertEquals("This is some dummy string", result.getVarString()); assertEquals(true, result.isVarBoolean()); assertEquals('C', result.getVarChar()); @@ -78,7 +78,7 @@ public class BeanWrapperFieldSetMapperTests extends TestCase { FieldSet fieldSet = new DefaultFieldSet(new String[] { "This is some dummy string", "true", "C" }, new String[] { "varString", "varBoolean", "varChar" }); - TestObject result = (TestObject) mapper.mapLine(fieldSet, FieldSetMapper.ROW_NUMBER_UNKNOWN); + TestObject result = (TestObject) mapper.mapLine(fieldSet); assertEquals("This is some dummy string", result.getVarString()); assertEquals(true, result.isVarBoolean()); assertEquals('C', result.getVarChar()); @@ -93,7 +93,7 @@ public class BeanWrapperFieldSetMapperTests extends TestCase { FieldSet fieldSet = new DefaultFieldSet(new String[] { "This is some dummy string", "true", "C" }, new String[] { "VarString", "VAR_BOOLEAN", "VAR_CHAR" }); - TestObject result = (TestObject) mapper.mapLine(fieldSet, FieldSetMapper.ROW_NUMBER_UNKNOWN); + TestObject result = (TestObject) mapper.mapLine(fieldSet); assertEquals("This is some dummy string", result.getVarString()); assertEquals(true, result.isVarBoolean()); assertEquals('C', result.getVarChar()); @@ -106,7 +106,7 @@ public class BeanWrapperFieldSetMapperTests extends TestCase { FieldSet fieldSet = new DefaultFieldSet(new String[] { "This is some dummy string", "true", "C" }, new String[] { "varString", "varBoolean", "varChar" }); - TestObject result = (TestObject) mapper.mapLine(fieldSet, FieldSetMapper.ROW_NUMBER_UNKNOWN); + TestObject result = (TestObject) mapper.mapLine(fieldSet); assertEquals("This is some dummy string", result.getVarString()); assertEquals(true, result.isVarBoolean()); assertEquals('C', result.getVarChar()); @@ -128,7 +128,7 @@ public class BeanWrapperFieldSetMapperTests extends TestCase { FieldSet fieldSet = new DefaultFieldSet(new String[] { "This is some dummy string", "1", "Another dummy", "2" }, new String[] { "valueA", "valueB", "testObjectB.valueA", "testObjectB.testObjectC.value" }); - TestNestedA result = (TestNestedA) mapper.mapLine(fieldSet, FieldSetMapper.ROW_NUMBER_UNKNOWN); + TestNestedA result = (TestNestedA) mapper.mapLine(fieldSet); assertEquals("This is some dummy string", result.getValueA()); assertEquals(1, result.getValueB()); @@ -148,7 +148,7 @@ public class BeanWrapperFieldSetMapperTests extends TestCase { FieldSet fieldSet = new DefaultFieldSet(new String[] { "This is some dummy string", "1" }, new String[] { "VALUE_A", "VALUE_B" }); - TestNestedA result = (TestNestedA) mapper.mapLine(fieldSet, FieldSetMapper.ROW_NUMBER_UNKNOWN); + TestNestedA result = (TestNestedA) mapper.mapLine(fieldSet); assertEquals("This is some dummy string", result.getValueA()); assertEquals(1, result.getValueB()); @@ -165,7 +165,7 @@ public class BeanWrapperFieldSetMapperTests extends TestCase { FieldSet fieldSet = new DefaultFieldSet(new String[] { "1" }, new String[] { "foo" }); - TestNestedC result = (TestNestedC) mapper.mapLine(fieldSet, FieldSetMapper.ROW_NUMBER_UNKNOWN); + TestNestedC result = (TestNestedC) mapper.mapLine(fieldSet); // "foo" is similar enough to "value" that it matches - but only because // nothing else does... @@ -187,7 +187,7 @@ public class BeanWrapperFieldSetMapperTests extends TestCase { FieldSet fieldSet = new DefaultFieldSet(new String[] { "Another dummy", "2" }, new String[] { "TestObjectB.ValueA", "TestObjectB.TestObjectC.Value" }); - TestNestedA result = (TestNestedA) mapper.mapLine(fieldSet, FieldSetMapper.ROW_NUMBER_UNKNOWN); + TestNestedA result = (TestNestedA) mapper.mapLine(fieldSet); assertEquals("Another dummy", result.getTestObjectB().getValueA()); assertEquals(2, result.getTestObjectB().getTestObjectC().getValue()); @@ -207,7 +207,7 @@ public class BeanWrapperFieldSetMapperTests extends TestCase { FieldSet fieldSet = new DefaultFieldSet(new String[] { "Another dummy" }, new String[] { "TestObjectB.foo" }); try { - mapper.mapLine(fieldSet, FieldSetMapper.ROW_NUMBER_UNKNOWN); + mapper.mapLine(fieldSet); fail("Expected NotWritablePropertyException"); } catch (NotWritablePropertyException e) { @@ -229,7 +229,7 @@ public class BeanWrapperFieldSetMapperTests extends TestCase { FieldSet fieldSet = new DefaultFieldSet(new String[] { "2" }, new String[] { "TestObjectA.garbage" }); try { - mapper.mapLine(fieldSet, FieldSetMapper.ROW_NUMBER_UNKNOWN); + mapper.mapLine(fieldSet); fail("Expected NotWritablePropertyException"); } catch (NotWritablePropertyException e) { @@ -269,7 +269,7 @@ public class BeanWrapperFieldSetMapperTests extends TestCase { FieldSet fieldSet = new DefaultFieldSet(new String[] { "1", "2", "3" }, new String[] { "NestedC[0].Value", "NestedC[1].Value", "NestedC[2].Value" }); - mapper.mapLine(fieldSet, FieldSetMapper.ROW_NUMBER_UNKNOWN); + mapper.mapLine(fieldSet); assertEquals(1, ((TestNestedC) nestedList.getNestedC().get(0)).getValue()); assertEquals(2, ((TestNestedC) nestedList.getNestedC().get(1)).getValue()); @@ -285,7 +285,7 @@ public class BeanWrapperFieldSetMapperTests extends TestCase { FieldSet fieldSet = new DefaultFieldSet(new String[] { "00009" }, new String[] { "varLong" }); try { - mapper.mapLine(fieldSet, FieldSetMapper.ROW_NUMBER_UNKNOWN); + mapper.mapLine(fieldSet); fail("Expected BindingException"); } catch (BindingException e) { @@ -302,7 +302,7 @@ public class BeanWrapperFieldSetMapperTests extends TestCase { mapper.setCustomEditors(Collections.singletonMap(Long.TYPE, new CustomNumberEditor(Long.class, NumberFormat .getNumberInstance(), true))); - TestObject bean = (TestObject) mapper.mapLine(fieldSet, FieldSetMapper.ROW_NUMBER_UNKNOWN); + TestObject bean = (TestObject) mapper.mapLine(fieldSet); assertEquals(9, bean.getVarLong()); } @@ -316,7 +316,7 @@ public class BeanWrapperFieldSetMapperTests extends TestCase { mapper.setCustomEditors(Collections.singletonMap(Long.TYPE, new CustomNumberEditor(Long.class, NumberFormat .getNumberInstance(), true))); - TestObject bean = (TestObject) mapper.mapLine(fieldSet, FieldSetMapper.ROW_NUMBER_UNKNOWN); + TestObject bean = (TestObject) mapper.mapLine(fieldSet); assertEquals(9, bean.getVarLong()); assertEquals(78, bean.getVarInt()); diff --git a/spring-batch-infrastructure/src/test/java/org/springframework/batch/item/file/mapping/PassThroughFieldSetMapperTests.java b/spring-batch-infrastructure/src/test/java/org/springframework/batch/item/file/mapping/PassThroughFieldSetMapperTests.java index 3aa50add1..54b8e6d42 100644 --- a/spring-batch-infrastructure/src/test/java/org/springframework/batch/item/file/mapping/PassThroughFieldSetMapperTests.java +++ b/spring-batch-infrastructure/src/test/java/org/springframework/batch/item/file/mapping/PassThroughFieldSetMapperTests.java @@ -27,11 +27,11 @@ public class PassThroughFieldSetMapperTests extends TestCase { /** * Test method for - * {@link org.springframework.batch.item.file.mapping.PassThroughFieldSetMapper#mapLine(org.springframework.batch.item.file.mapping.FieldSet, int)}. + * {@link org.springframework.batch.item.file.mapping.PassThroughFieldSetMapper#mapLine(org.springframework.batch.item.file.mapping.FieldSet)}. */ public void testMapLine() { FieldSet fieldSet = new DefaultFieldSet(new String[] { "foo", "bar" }); - assertEquals(fieldSet, mapper.mapLine(fieldSet, FieldSetMapper.ROW_NUMBER_UNKNOWN)); + assertEquals(fieldSet, mapper.mapLine(fieldSet)); } /** diff --git a/spring-batch-infrastructure/src/test/java/org/springframework/batch/repeat/support/AbstractTradeBatchTests.java b/spring-batch-infrastructure/src/test/java/org/springframework/batch/repeat/support/AbstractTradeBatchTests.java index 3a1570150..36ab5c9b8 100644 --- a/spring-batch-infrastructure/src/test/java/org/springframework/batch/repeat/support/AbstractTradeBatchTests.java +++ b/spring-batch-infrastructure/src/test/java/org/springframework/batch/repeat/support/AbstractTradeBatchTests.java @@ -60,7 +60,7 @@ public abstract class AbstractTradeBatchTests extends TestCase { } protected static class TradeMapper implements FieldSetMapper{ - public Object mapLine(FieldSet fs, int rownum) { + public Object mapLine(FieldSet fs) { return new Trade(fs); } } diff --git a/spring-batch-samples/src/main/java/org/springframework/batch/sample/item/reader/OrderItemReader.java b/spring-batch-samples/src/main/java/org/springframework/batch/sample/item/reader/OrderItemReader.java index b46172ca7..09903a47d 100644 --- a/spring-batch-samples/src/main/java/org/springframework/batch/sample/item/reader/OrderItemReader.java +++ b/spring-batch-samples/src/main/java/org/springframework/batch/sample/item/reader/OrderItemReader.java @@ -91,7 +91,7 @@ public class OrderItemReader extends DelegatingItemReader { // start a new Order if (Order.LINE_ID_HEADER.equals(lineId)) { log.debug("STARTING NEW RECORD"); - order = (Order) headerMapper.mapLine(fieldSet, FieldSetMapper.ROW_NUMBER_UNKNOWN); + order = (Order) headerMapper.mapLine(fieldSet); return; } @@ -116,7 +116,7 @@ public class OrderItemReader extends DelegatingItemReader { log.debug("MAPPING CUSTOMER"); if (order.getCustomer() == null) { - order.setCustomer((Customer) customerMapper.mapLine(fieldSet, FieldSetMapper.ROW_NUMBER_UNKNOWN)); + order.setCustomer((Customer) customerMapper.mapLine(fieldSet)); order.getCustomer().setBusinessCustomer(true); } @@ -127,7 +127,7 @@ public class OrderItemReader extends DelegatingItemReader { log.debug("MAPPING CUSTOMER"); if (order.getCustomer() == null) { - order.setCustomer((Customer) customerMapper.mapLine(fieldSet, FieldSetMapper.ROW_NUMBER_UNKNOWN)); + order.setCustomer((Customer) customerMapper.mapLine(fieldSet)); order.getCustomer().setBusinessCustomer(false); } @@ -136,25 +136,25 @@ public class OrderItemReader extends DelegatingItemReader { if (Address.LINE_ID_BILLING_ADDR.equals(lineId)) { log.debug("MAPPING BILLING ADDRESS"); - order.setBillingAddress((Address) addressMapper.mapLine(fieldSet, FieldSetMapper.ROW_NUMBER_UNKNOWN)); + order.setBillingAddress((Address) addressMapper.mapLine(fieldSet)); return; } if (Address.LINE_ID_SHIPPING_ADDR.equals(lineId)) { log.debug("MAPPING SHIPPING ADDRESS"); - order.setShippingAddress((Address) addressMapper.mapLine(fieldSet, FieldSetMapper.ROW_NUMBER_UNKNOWN)); + order.setShippingAddress((Address) addressMapper.mapLine(fieldSet)); return; } if (BillingInfo.LINE_ID_BILLING_INFO.equals(lineId)) { log.debug("MAPPING BILLING INFO"); - order.setBilling((BillingInfo) billingMapper.mapLine(fieldSet, FieldSetMapper.ROW_NUMBER_UNKNOWN)); + order.setBilling((BillingInfo) billingMapper.mapLine(fieldSet)); return; } if (ShippingInfo.LINE_ID_SHIPPING_INFO.equals(lineId)) { log.debug("MAPPING SHIPPING INFO"); - order.setShipping((ShippingInfo) shippingMapper.mapLine(fieldSet, FieldSetMapper.ROW_NUMBER_UNKNOWN)); + order.setShipping((ShippingInfo) shippingMapper.mapLine(fieldSet)); return; } @@ -165,7 +165,7 @@ public class OrderItemReader extends DelegatingItemReader { order.setLineItems(new ArrayList()); } - order.getLineItems().add(itemMapper.mapLine(fieldSet, FieldSetMapper.ROW_NUMBER_UNKNOWN)); + order.getLineItems().add(itemMapper.mapLine(fieldSet)); return; } diff --git a/spring-batch-samples/src/main/java/org/springframework/batch/sample/mapping/AddressFieldSetMapper.java b/spring-batch-samples/src/main/java/org/springframework/batch/sample/mapping/AddressFieldSetMapper.java index 7c0cbe875..4c2a4c673 100644 --- a/spring-batch-samples/src/main/java/org/springframework/batch/sample/mapping/AddressFieldSetMapper.java +++ b/spring-batch-samples/src/main/java/org/springframework/batch/sample/mapping/AddressFieldSetMapper.java @@ -33,7 +33,7 @@ public class AddressFieldSetMapper implements FieldSetMapper { public static final String COUNTRY_COLUMN = "COUNTRY"; - public Object mapLine(FieldSet fieldSet, int rownum) { + public Object mapLine(FieldSet fieldSet) { Address address = new Address(); address.setAddressee(fieldSet.readString(ADDRESSEE_COLUMN)); diff --git a/spring-batch-samples/src/main/java/org/springframework/batch/sample/mapping/BillingFieldSetMapper.java b/spring-batch-samples/src/main/java/org/springframework/batch/sample/mapping/BillingFieldSetMapper.java index fbeb6343e..f5bcbeeb0 100644 --- a/spring-batch-samples/src/main/java/org/springframework/batch/sample/mapping/BillingFieldSetMapper.java +++ b/spring-batch-samples/src/main/java/org/springframework/batch/sample/mapping/BillingFieldSetMapper.java @@ -27,7 +27,7 @@ public class BillingFieldSetMapper implements FieldSetMapper { public static final String PAYMENT_TYPE_ID_COLUMN = "PAYMENT_TYPE_ID"; public static final String PAYMENT_DESC_COLUMN = "PAYMENT_DESC"; - public Object mapLine(FieldSet fieldSet, int rownum) { + public Object mapLine(FieldSet fieldSet) { BillingInfo info = new BillingInfo(); info.setPaymentId(fieldSet.readString(PAYMENT_TYPE_ID_COLUMN)); diff --git a/spring-batch-samples/src/main/java/org/springframework/batch/sample/mapping/CustomerFieldSetMapper.java b/spring-batch-samples/src/main/java/org/springframework/batch/sample/mapping/CustomerFieldSetMapper.java index a0fe7b582..d96a4a1ca 100644 --- a/spring-batch-samples/src/main/java/org/springframework/batch/sample/mapping/CustomerFieldSetMapper.java +++ b/spring-batch-samples/src/main/java/org/springframework/batch/sample/mapping/CustomerFieldSetMapper.java @@ -34,7 +34,7 @@ public class CustomerFieldSetMapper implements FieldSetMapper { public static final String REG_ID_COLUMN = "REG_ID"; public static final String VIP_COLUMN = "VIP"; - public Object mapLine(FieldSet fieldSet, int rownum) { + public Object mapLine(FieldSet fieldSet) { Customer customer = new Customer(); if (Customer.LINE_ID_BUSINESS_CUST.equals(fieldSet.readString(LINE_ID_COLUMN))) { diff --git a/spring-batch-samples/src/main/java/org/springframework/batch/sample/mapping/GameFieldSetMapper.java b/spring-batch-samples/src/main/java/org/springframework/batch/sample/mapping/GameFieldSetMapper.java index 46f71e311..ca7a6dd90 100644 --- a/spring-batch-samples/src/main/java/org/springframework/batch/sample/mapping/GameFieldSetMapper.java +++ b/spring-batch-samples/src/main/java/org/springframework/batch/sample/mapping/GameFieldSetMapper.java @@ -6,7 +6,7 @@ import org.springframework.batch.sample.domain.Game; public class GameFieldSetMapper implements FieldSetMapper { - public Object mapLine(FieldSet fs, int rownum) { + public Object mapLine(FieldSet fs) { if(fs == null){ return null; diff --git a/spring-batch-samples/src/main/java/org/springframework/batch/sample/mapping/HeaderFieldSetMapper.java b/spring-batch-samples/src/main/java/org/springframework/batch/sample/mapping/HeaderFieldSetMapper.java index 462f130e4..61cbe7924 100644 --- a/spring-batch-samples/src/main/java/org/springframework/batch/sample/mapping/HeaderFieldSetMapper.java +++ b/spring-batch-samples/src/main/java/org/springframework/batch/sample/mapping/HeaderFieldSetMapper.java @@ -27,7 +27,7 @@ public class HeaderFieldSetMapper implements FieldSetMapper { public static final String ORDER_ID_COLUMN = "ORDER_ID"; public static final String ORDER_DATE_COLUMN = "ORDER_DATE"; - public Object mapLine(FieldSet fieldSet, int rownum) { + public Object mapLine(FieldSet fieldSet) { Order order = new Order(); order.setOrderId(fieldSet.readLong(ORDER_ID_COLUMN)); order.setOrderDate(fieldSet.readDate(ORDER_DATE_COLUMN)); diff --git a/spring-batch-samples/src/main/java/org/springframework/batch/sample/mapping/OrderItemFieldSetMapper.java b/spring-batch-samples/src/main/java/org/springframework/batch/sample/mapping/OrderItemFieldSetMapper.java index 62f669a3e..2f35d2474 100644 --- a/spring-batch-samples/src/main/java/org/springframework/batch/sample/mapping/OrderItemFieldSetMapper.java +++ b/spring-batch-samples/src/main/java/org/springframework/batch/sample/mapping/OrderItemFieldSetMapper.java @@ -33,7 +33,7 @@ public class OrderItemFieldSetMapper implements FieldSetMapper { public static final String ITEM_ID_COLUMN = "ITEM_ID"; - public Object mapLine(FieldSet fieldSet, int rownum) { + public Object mapLine(FieldSet fieldSet) { LineItem item = new LineItem(); item.setItemId(fieldSet.readLong(ITEM_ID_COLUMN)); diff --git a/spring-batch-samples/src/main/java/org/springframework/batch/sample/mapping/PlayerFieldSetMapper.java b/spring-batch-samples/src/main/java/org/springframework/batch/sample/mapping/PlayerFieldSetMapper.java index 0b1fe8895..034d11c28 100644 --- a/spring-batch-samples/src/main/java/org/springframework/batch/sample/mapping/PlayerFieldSetMapper.java +++ b/spring-batch-samples/src/main/java/org/springframework/batch/sample/mapping/PlayerFieldSetMapper.java @@ -6,7 +6,7 @@ import org.springframework.batch.sample.domain.Player; public class PlayerFieldSetMapper implements FieldSetMapper { - public Object mapLine(FieldSet fs, int rownum) { + public Object mapLine(FieldSet fs) { if(fs == null){ return null; diff --git a/spring-batch-samples/src/main/java/org/springframework/batch/sample/mapping/ShippingFieldSetMapper.java b/spring-batch-samples/src/main/java/org/springframework/batch/sample/mapping/ShippingFieldSetMapper.java index 49ed328e7..2fc8a6a45 100644 --- a/spring-batch-samples/src/main/java/org/springframework/batch/sample/mapping/ShippingFieldSetMapper.java +++ b/spring-batch-samples/src/main/java/org/springframework/batch/sample/mapping/ShippingFieldSetMapper.java @@ -28,7 +28,7 @@ public class ShippingFieldSetMapper implements FieldSetMapper { public static final String SHIPPING_TYPE_ID_COLUMN = "SHIPPING_TYPE_ID"; public static final String SHIPPER_ID_COLUMN = "SHIPPER_ID"; - public Object mapLine(FieldSet fieldSet, int rownum) { + public Object mapLine(FieldSet fieldSet) { ShippingInfo info = new ShippingInfo(); info.setShipperId(fieldSet.readString(SHIPPER_ID_COLUMN)); diff --git a/spring-batch-samples/src/main/java/org/springframework/batch/sample/mapping/TradeFieldSetMapper.java b/spring-batch-samples/src/main/java/org/springframework/batch/sample/mapping/TradeFieldSetMapper.java index 9bf56f933..c74728b26 100644 --- a/spring-batch-samples/src/main/java/org/springframework/batch/sample/mapping/TradeFieldSetMapper.java +++ b/spring-batch-samples/src/main/java/org/springframework/batch/sample/mapping/TradeFieldSetMapper.java @@ -30,7 +30,7 @@ public class TradeFieldSetMapper implements FieldSetMapper { public static final int PRICE_COLUMN = 2; public static final int CUSTOMER_COLUMN = 3; - public Object mapLine(FieldSet fieldSet, int rownum) { + public Object mapLine(FieldSet fieldSet) { if ("BEGIN".equals(fieldSet.readString(0))) { return AggregateItemReader.BEGIN_RECORD; diff --git a/spring-batch-samples/src/test/java/org/springframework/batch/sample/item/reader/OrderItemReaderTests.java b/spring-batch-samples/src/test/java/org/springframework/batch/sample/item/reader/OrderItemReaderTests.java index ce60cf0cf..7f15e3b4f 100644 --- a/spring-batch-samples/src/test/java/org/springframework/batch/sample/item/reader/OrderItemReaderTests.java +++ b/spring-batch-samples/src/test/java/org/springframework/batch/sample/item/reader/OrderItemReaderTests.java @@ -90,19 +90,19 @@ public class OrderItemReaderTests extends TestCase { mapperControl = MockControl.createControl(FieldSetMapper.class); mapper = (FieldSetMapper)mapperControl.getMock(); //set how mapper should respond - set return values for mapper - mapper.mapLine(headerFS, FieldSetMapper.ROW_NUMBER_UNKNOWN); + mapper.mapLine(headerFS); mapperControl.setReturnValue(order); - mapper.mapLine(customerFS, FieldSetMapper.ROW_NUMBER_UNKNOWN); + mapper.mapLine(customerFS); mapperControl.setReturnValue(customer); - mapper.mapLine(billingFS, FieldSetMapper.ROW_NUMBER_UNKNOWN); + mapper.mapLine(billingFS); mapperControl.setReturnValue(billing); - mapper.mapLine(shippingFS, FieldSetMapper.ROW_NUMBER_UNKNOWN); + mapper.mapLine(shippingFS); mapperControl.setReturnValue(shipping); - mapper.mapLine(billingInfoFS, FieldSetMapper.ROW_NUMBER_UNKNOWN); + mapper.mapLine(billingInfoFS); mapperControl.setReturnValue(billingInfo); - mapper.mapLine(shippingInfoFS, FieldSetMapper.ROW_NUMBER_UNKNOWN); + mapper.mapLine(shippingInfoFS); mapperControl.setReturnValue(shippingInfo); - mapper.mapLine(itemFS, FieldSetMapper.ROW_NUMBER_UNKNOWN); + mapper.mapLine(itemFS); mapperControl.setReturnValue(item,3); mapperControl.replay(); diff --git a/spring-batch-samples/src/test/java/org/springframework/batch/sample/mapping/AbstractFieldSetMapperTests.java b/spring-batch-samples/src/test/java/org/springframework/batch/sample/mapping/AbstractFieldSetMapperTests.java index 9c4b6e399..1aac6e2fd 100644 --- a/spring-batch-samples/src/test/java/org/springframework/batch/sample/mapping/AbstractFieldSetMapperTests.java +++ b/spring-batch-samples/src/test/java/org/springframework/batch/sample/mapping/AbstractFieldSetMapperTests.java @@ -35,7 +35,7 @@ public abstract class AbstractFieldSetMapperTests extends TestCase { * Assumes the domain object implements sensible equals(Object other) */ public void testRegularUse() { - assertEquals(expectedDomainObject(), fieldSetMapper().mapLine(fieldSet(), FieldSetMapper.ROW_NUMBER_UNKNOWN)); + assertEquals(expectedDomainObject(), fieldSetMapper().mapLine(fieldSet())); } } diff --git a/spring-batch-samples/src/test/java/org/springframework/batch/sample/mapping/TradeFieldSetMapperTests.java b/spring-batch-samples/src/test/java/org/springframework/batch/sample/mapping/TradeFieldSetMapperTests.java index f52b73666..834427b91 100644 --- a/spring-batch-samples/src/test/java/org/springframework/batch/sample/mapping/TradeFieldSetMapperTests.java +++ b/spring-batch-samples/src/test/java/org/springframework/batch/sample/mapping/TradeFieldSetMapperTests.java @@ -40,11 +40,11 @@ public class TradeFieldSetMapperTests extends AbstractFieldSetMapperTests{ } public void testBeginRecord() throws Exception { - assertEquals(AggregateItemReader.BEGIN_RECORD, fieldSetMapper().mapLine(new DefaultFieldSet(new String[] {"BEGIN"}), FieldSetMapper.ROW_NUMBER_UNKNOWN)); + assertEquals(AggregateItemReader.BEGIN_RECORD, fieldSetMapper().mapLine(new DefaultFieldSet(new String[] {"BEGIN"}))); } public void testEndRecord() throws Exception { - assertEquals(AggregateItemReader.END_RECORD, fieldSetMapper().mapLine(new DefaultFieldSet(new String[] {"END"}), FieldSetMapper.ROW_NUMBER_UNKNOWN)); + assertEquals(AggregateItemReader.END_RECORD, fieldSetMapper().mapLine(new DefaultFieldSet(new String[] {"END"}))); } }