BATCH-1591: add some unit tests (looks like dup of BATCH-1588)

spring-batch-core/src/test/java/org/springframework/batch/core/configuration/xml/DummyPojoStepExecutionListener.java

@@ -0,0 +1,14 @@
+package org.springframework.batch.core.configuration.xml;
+
+
+/**
+ * @author Dave Syer
+ * @since 2.1.2
+ */
+public class DummyPojoStepExecutionListener extends AbstractTestComponent {
+
+	public void execute() {
+		executed = true;
+	}
+
+}

spring-batch-core/src/test/java/org/springframework/batch/core/configuration/xml/StepListenerMethodAttributeParserTests.java

@@ -0,0 +1,72 @@
+/*
+ * Copyright 2002-2008 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.springframework.batch.core.configuration.xml;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertTrue;
+
+import java.util.ArrayList;
+import java.util.List;
+
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.springframework.aop.framework.Advised;
+import org.springframework.batch.core.Step;
+import org.springframework.batch.core.StepExecutionListener;
+import org.springframework.batch.core.step.tasklet.TaskletStep;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.beans.factory.annotation.Qualifier;
+import org.springframework.test.context.ContextConfiguration;
+import org.springframework.test.context.junit4.SpringJUnit4ClassRunner;
+import org.springframework.test.util.ReflectionTestUtils;
+
+/**
+ * @author Dan Garrette
+ * @since 2.0
+ */
+@ContextConfiguration
+@RunWith(SpringJUnit4ClassRunner.class)
+public class StepListenerMethodAttributeParserTests {
+	
+	@Autowired
+	@Qualifier("s1")
+	private Step step1;
+
+	@Test
+	public void testInheritListeners() throws Exception {
+		List<?> list = getListeners(step1);
+		assertEquals(2, list.size());
+	}
+
+	@SuppressWarnings("unchecked")
+	private List<?> getListeners(Step step) throws Exception {
+		assertTrue(step instanceof TaskletStep);
+
+		Object compositeListener = ReflectionTestUtils.getField(step, "stepExecutionListener");
+		Object composite = ReflectionTestUtils.getField(compositeListener, "list");
+		List<StepExecutionListener> proxiedListeners = (List<StepExecutionListener>) ReflectionTestUtils.getField(
+				composite, "list");
+		List<Object> r = new ArrayList<Object>();
+		for (Object listener : proxiedListeners) {
+			while (listener instanceof Advised) {
+				listener = ((Advised) listener).getTargetSource().getTarget();
+			}
+			r.add(listener);
+		}
+		return r;
+	}
+
+}

spring-batch-core/src/test/resources/org/springframework/batch/core/configuration/xml/StepListenerMethodAttributeParserTests-context.xml

@@ -0,0 +1,26 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<beans:beans xmlns="http://www.springframework.org/schema/batch" xmlns:beans="http://www.springframework.org/schema/beans"
+	xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+	xsi:schemaLocation="http://www.springframework.org/schema/batch http://www.springframework.org/schema/batch/spring-batch-2.1.xsd
+	http://www.springframework.org/schema/beans http://www.springframework.org/schema/beans/spring-beans-2.5.xsd">
+
+	<beans:import resource="common-context.xml" />
+	
+	<job id="job">
+		<step id="s1">
+			<tasklet ref="dummyTasklet">
+				<listeners merge="true">
+					<listener after-step-method="execute">
+						<beans:bean class="org.springframework.batch.core.configuration.xml.DummyPojoStepExecutionListener"/>
+					</listener>
+					<listener ref="toplevel1"/>
+				</listeners>
+			</tasklet>
+		</step>
+	</job>
+	
+	<step-listener id="toplevel1" after-step-method="execute">
+		<beans:bean class="org.springframework.batch.core.configuration.xml.DummyPojoStepExecutionListener"/>
+	</step-listener>
+
+</beans:beans>