diff --git a/spring-batch-infrastructure/src/main/java/org/springframework/batch/item/support/CompositeItemWriter.java b/spring-batch-infrastructure/src/main/java/org/springframework/batch/item/support/CompositeItemWriter.java index ff7cffb2a..233034fa5 100644 --- a/spring-batch-infrastructure/src/main/java/org/springframework/batch/item/support/CompositeItemWriter.java +++ b/spring-batch-infrastructure/src/main/java/org/springframework/batch/item/support/CompositeItemWriter.java @@ -15,9 +15,9 @@ import org.springframework.batch.item.ItemWriter; */ public class CompositeItemWriter implements ItemWriter { - private List> delegates; + private List> delegates; - public void setDelegates(List> delegates) { + public void setDelegates(List> delegates) { this.delegates = delegates; } @@ -25,19 +25,19 @@ public class CompositeItemWriter implements ItemWriter { * Calls injected ItemProcessors in order. */ public void write(T item) throws Exception { - for (ItemWriter writer : delegates) { + for (ItemWriter writer : delegates) { writer.write(item); } } public void clear() throws ClearFailedException { - for (ItemWriter writer : delegates) { + for (ItemWriter writer : delegates) { writer.clear(); } } public void flush() throws FlushFailedException { - for (ItemWriter writer : delegates) { + for (ItemWriter writer : delegates) { writer.flush(); } } diff --git a/spring-batch-infrastructure/src/main/java/org/springframework/batch/item/transform/ItemTransformer.java b/spring-batch-infrastructure/src/main/java/org/springframework/batch/item/transform/ItemTransformer.java index 55f9c47c5..190c7f662 100644 --- a/spring-batch-infrastructure/src/main/java/org/springframework/batch/item/transform/ItemTransformer.java +++ b/spring-batch-infrastructure/src/main/java/org/springframework/batch/item/transform/ItemTransformer.java @@ -5,7 +5,7 @@ package org.springframework.batch.item.transform; * * @author Robert Kasanicky */ -public interface ItemTransformer { +public interface ItemTransformer { - Object transform(Object item) throws Exception; + O transform(I item) throws Exception; } diff --git a/spring-batch-infrastructure/src/main/java/org/springframework/batch/item/transform/ItemTransformerItemWriter.java b/spring-batch-infrastructure/src/main/java/org/springframework/batch/item/transform/ItemTransformerItemWriter.java index 09a39d3d8..c185e89b1 100644 --- a/spring-batch-infrastructure/src/main/java/org/springframework/batch/item/transform/ItemTransformerItemWriter.java +++ b/spring-batch-infrastructure/src/main/java/org/springframework/batch/item/transform/ItemTransformerItemWriter.java @@ -10,14 +10,14 @@ import org.springframework.util.Assert; * * @author Robert Kasanicky */ -public class ItemTransformerItemWriter extends DelegatingItemWriter { +public class ItemTransformerItemWriter extends DelegatingItemWriter { - private ItemTransformer itemTransformer; + private ItemTransformer itemTransformer; /** * Transform the item using the {@link #setItemTransformer(ItemTransformer)}. */ - protected Object doProcess(Object item) throws Exception { + protected O doProcess(I item) throws Exception { return itemTransformer.transform(item); } @@ -25,7 +25,7 @@ public class ItemTransformerItemWriter extends DelegatingItemWriter { * @param itemTransformer will transform the item before * it is passed to {@link ItemWriter}. */ - public void setItemTransformer(ItemTransformer itemTransformer) { + public void setItemTransformer(ItemTransformer itemTransformer) { this.itemTransformer = itemTransformer; } diff --git a/spring-batch-infrastructure/src/test/java/org/springframework/batch/item/support/CompositeItemWriterTests.java b/spring-batch-infrastructure/src/test/java/org/springframework/batch/item/support/CompositeItemWriterTests.java index 22c174d80..84da253a8 100644 --- a/spring-batch-infrastructure/src/test/java/org/springframework/batch/item/support/CompositeItemWriterTests.java +++ b/spring-batch-infrastructure/src/test/java/org/springframework/batch/item/support/CompositeItemWriterTests.java @@ -16,7 +16,7 @@ import org.springframework.batch.item.ItemWriter; public class CompositeItemWriterTests extends TestCase { // object under test - private CompositeItemWriter itemProcessor = new CompositeItemWriter(); + private CompositeItemWriter itemProcessor = new CompositeItemWriter(); /** * Regular usage scenario. @@ -24,13 +24,13 @@ public class CompositeItemWriterTests extends TestCase { */ public void testProcess() throws Exception { - final int NUMBER_OF_PROCESSORS = 10; + final int NUMBER_OF_WRITERS = 10; Object data = new Object(); - List controls = new ArrayList(NUMBER_OF_PROCESSORS); - List writers = new ArrayList(NUMBER_OF_PROCESSORS); + List controls = new ArrayList(NUMBER_OF_WRITERS); + List> writers = new ArrayList>(NUMBER_OF_WRITERS); - for (int i = 0; i < NUMBER_OF_PROCESSORS; i++) { + for (int i = 0; i < NUMBER_OF_WRITERS; i++) { MockControl control = MockControl.createStrictControl(ItemWriter.class); ItemWriter writer = (ItemWriter) control.getMock(); diff --git a/spring-batch-infrastructure/src/test/java/org/springframework/batch/item/support/DelegatingItemWriterTests.java b/spring-batch-infrastructure/src/test/java/org/springframework/batch/item/support/DelegatingItemWriterTests.java index ae7e11046..e60947b58 100644 --- a/spring-batch-infrastructure/src/test/java/org/springframework/batch/item/support/DelegatingItemWriterTests.java +++ b/spring-batch-infrastructure/src/test/java/org/springframework/batch/item/support/DelegatingItemWriterTests.java @@ -27,9 +27,9 @@ import org.springframework.batch.item.support.DelegatingItemWriter; */ public class DelegatingItemWriterTests extends TestCase { - MockControl writerControl = MockControl.createControl(ItemWriter.class); - ItemWriter itemWriter; - DelegatingItemWriter delegatingWriter; + MockControl writerControl = MockControl.createControl(ItemWriter.class); + ItemWriter itemWriter; + DelegatingItemWriter delegatingWriter; /* (non-Javadoc) * @see junit.framework.TestCase#setUp() @@ -37,8 +37,8 @@ public class DelegatingItemWriterTests extends TestCase { protected void setUp() throws Exception { super.setUp(); - itemWriter = (ItemWriter)writerControl.getMock(); - delegatingWriter = new DelegatingItemWriter(); + itemWriter = writerControl.getMock(); + delegatingWriter = new DelegatingItemWriter(); delegatingWriter.setDelegate(itemWriter); } diff --git a/spring-batch-infrastructure/src/test/java/org/springframework/batch/item/transform/ItemTransformerItemWriterTests.java b/spring-batch-infrastructure/src/test/java/org/springframework/batch/item/transform/ItemTransformerItemWriterTests.java index f2eaeae20..1dc81b8c5 100644 --- a/spring-batch-infrastructure/src/test/java/org/springframework/batch/item/transform/ItemTransformerItemWriterTests.java +++ b/spring-batch-infrastructure/src/test/java/org/springframework/batch/item/transform/ItemTransformerItemWriterTests.java @@ -12,17 +12,17 @@ import org.springframework.batch.item.ItemWriter; */ public class ItemTransformerItemWriterTests extends TestCase { - private ItemTransformerItemWriter processor = new ItemTransformerItemWriter(); + private ItemTransformerItemWriter processor = new ItemTransformerItemWriter(); - private ItemTransformer transformer; + private ItemTransformer transformer; private ItemWriter itemWriter; - private MockControl tControl = MockControl.createControl(ItemTransformer.class); - private MockControl outControl = MockControl.createControl(ItemWriter.class); + private MockControl tControl = MockControl.createControl(ItemTransformer.class); + private MockControl outControl = MockControl.createControl(ItemWriter.class); protected void setUp() throws Exception { - transformer = (ItemTransformer) tControl.getMock(); - itemWriter = (ItemWriter) outControl.getMock(); + transformer = tControl.getMock(); + itemWriter = outControl.getMock(); processor.setItemTransformer(transformer); processor.setDelegate(itemWriter); diff --git a/spring-batch-infrastructure/src/test/java/org/springframework/batch/item/xml/StaxEventItemWriterTests.java b/spring-batch-infrastructure/src/test/java/org/springframework/batch/item/xml/StaxEventItemWriterTests.java index 681db1562..895736d95 100644 --- a/spring-batch-infrastructure/src/test/java/org/springframework/batch/item/xml/StaxEventItemWriterTests.java +++ b/spring-batch-infrastructure/src/test/java/org/springframework/batch/item/xml/StaxEventItemWriterTests.java @@ -27,7 +27,7 @@ import org.springframework.xml.transform.StaxResult; public class StaxEventItemWriterTests extends TestCase { // object under test - private StaxEventItemWriter writer; + private StaxEventItemWriter writer; // output file private Resource resource; @@ -58,7 +58,7 @@ public class StaxEventItemWriterTests extends TestCase { public void testFlush() throws Exception { writer.open(executionContext); InputCheckMarshaller marshaller = new InputCheckMarshaller(); - MarshallingEventWriterSerializer serializer = new MarshallingEventWriterSerializer(marshaller); + MarshallingEventWriterSerializer serializer = new MarshallingEventWriterSerializer(marshaller); writer.setSerializer(serializer); // see asserts in the marshaller @@ -274,12 +274,12 @@ public class StaxEventItemWriterTests extends TestCase { /** * @return new instance of fully configured writer */ - private StaxEventItemWriter createItemWriter() throws Exception { - StaxEventItemWriter source = new StaxEventItemWriter(); + private StaxEventItemWriter createItemWriter() throws Exception { + StaxEventItemWriter source = new StaxEventItemWriter(); source.setResource(resource); Marshaller marshaller = new SimpleMarshaller(); - MarshallingEventWriterSerializer serializer = new MarshallingEventWriterSerializer(marshaller); + MarshallingEventWriterSerializer serializer = new MarshallingEventWriterSerializer(marshaller); source.setSerializer(serializer); source.setEncoding("UTF-8"); diff --git a/spring-batch-infrastructure/src/test/java/org/springframework/batch/item/xml/oxm/MarshallingObjectToXmlSerializerTests.java b/spring-batch-infrastructure/src/test/java/org/springframework/batch/item/xml/oxm/MarshallingObjectToXmlSerializerTests.java index e967024d4..90b72a9fb 100644 --- a/spring-batch-infrastructure/src/test/java/org/springframework/batch/item/xml/oxm/MarshallingObjectToXmlSerializerTests.java +++ b/spring-batch-infrastructure/src/test/java/org/springframework/batch/item/xml/oxm/MarshallingObjectToXmlSerializerTests.java @@ -38,7 +38,7 @@ import org.springframework.oxm.XmlMappingException; */ public class MarshallingObjectToXmlSerializerTests extends TestCase { - MarshallingEventWriterSerializer xmlSerializer; + MarshallingEventWriterSerializer xmlSerializer; MockMarshaller mockMarshaller = new MockMarshaller(); @@ -47,7 +47,7 @@ public class MarshallingObjectToXmlSerializerTests extends TestCase { protected void setUp() throws Exception { super.setUp(); - xmlSerializer = new MarshallingEventWriterSerializer(mockMarshaller); + xmlSerializer = new MarshallingEventWriterSerializer(mockMarshaller); writer = new StubXmlEventWriter(); } diff --git a/spring-batch-infrastructure/src/test/java/org/springframework/batch/repeat/callback/ItemReaderRepeatCallbackTests.java b/spring-batch-infrastructure/src/test/java/org/springframework/batch/repeat/callback/ItemReaderRepeatCallbackTests.java index 36e2ce856..ffd281b91 100644 --- a/spring-batch-infrastructure/src/test/java/org/springframework/batch/repeat/callback/ItemReaderRepeatCallbackTests.java +++ b/spring-batch-infrastructure/src/test/java/org/springframework/batch/repeat/callback/ItemReaderRepeatCallbackTests.java @@ -33,8 +33,8 @@ public class ItemReaderRepeatCallbackTests extends TestCase { public void testDoWithRepeat() throws Exception { callback = new ItemReaderRepeatCallback(new ListItemReader(Arrays.asList(new String[] { "foo", "bar" })), - new AbstractItemWriter() { - public void write(Object data) { + new AbstractItemWriter() { + public void write(String data) { list.add(data); } });