From e8e3f5da085c6fedad54094b5d410b06f57f1594 Mon Sep 17 00:00:00 2001 From: Mahmoud Ben Hassine Date: Thu, 25 Nov 2021 14:13:58 +0100 Subject: [PATCH] Reactivate LdifReader tests These tests were ignored in 5dc17b19 due to a runtime issue with spring-ldap. This issue has been fixed in https://github.com/spring-projects/spring-ldap/issues/590. --- .../springframework/batch/core/test/ldif/LdifReaderTests.java | 2 -- .../batch/core/test/ldif/MappingLdifReaderTests.java | 2 -- .../batch/core/test/ldif/builder/LdifReaderBuilderTests.java | 2 -- .../core/test/ldif/builder/MappingLdifReaderBuilderTests.java | 2 -- 4 files changed, 8 deletions(-) diff --git a/spring-batch-core/src/test/java/org/springframework/batch/core/test/ldif/LdifReaderTests.java b/spring-batch-core/src/test/java/org/springframework/batch/core/test/ldif/LdifReaderTests.java index eb4cd82f6..d6acf0ac0 100644 --- a/spring-batch-core/src/test/java/org/springframework/batch/core/test/ldif/LdifReaderTests.java +++ b/spring-batch-core/src/test/java/org/springframework/batch/core/test/ldif/LdifReaderTests.java @@ -23,7 +23,6 @@ import java.io.FileReader; import java.net.MalformedURLException; import org.junit.Before; -import org.junit.Ignore; import org.junit.Test; import org.junit.runner.RunWith; import org.springframework.batch.core.ExitStatus; @@ -40,7 +39,6 @@ import org.springframework.test.context.ContextConfiguration; import org.springframework.test.context.junit4.SpringJUnit4ClassRunner; import org.springframework.util.Assert; -@Ignore @RunWith(SpringJUnit4ClassRunner.class) @ContextConfiguration(locations = {"/simple-job-launcher-context.xml", "/applicationContext-test1.xml"}) public class LdifReaderTests { diff --git a/spring-batch-core/src/test/java/org/springframework/batch/core/test/ldif/MappingLdifReaderTests.java b/spring-batch-core/src/test/java/org/springframework/batch/core/test/ldif/MappingLdifReaderTests.java index 4ac375378..e1eee49da 100644 --- a/spring-batch-core/src/test/java/org/springframework/batch/core/test/ldif/MappingLdifReaderTests.java +++ b/spring-batch-core/src/test/java/org/springframework/batch/core/test/ldif/MappingLdifReaderTests.java @@ -22,7 +22,6 @@ import java.io.InputStreamReader; import java.net.MalformedURLException; import org.junit.Before; -import org.junit.Ignore; import org.junit.Test; import org.junit.runner.RunWith; import org.slf4j.Logger; @@ -42,7 +41,6 @@ import org.springframework.test.context.ContextConfiguration; import org.springframework.test.context.junit4.SpringJUnit4ClassRunner; import org.springframework.util.Assert; -@Ignore @RunWith(SpringJUnit4ClassRunner.class) @ContextConfiguration(locations = {"/simple-job-launcher-context.xml", "/applicationContext-test2.xml"}) public class MappingLdifReaderTests { diff --git a/spring-batch-core/src/test/java/org/springframework/batch/core/test/ldif/builder/LdifReaderBuilderTests.java b/spring-batch-core/src/test/java/org/springframework/batch/core/test/ldif/builder/LdifReaderBuilderTests.java index 84b11cb12..36152f402 100644 --- a/spring-batch-core/src/test/java/org/springframework/batch/core/test/ldif/builder/LdifReaderBuilderTests.java +++ b/spring-batch-core/src/test/java/org/springframework/batch/core/test/ldif/builder/LdifReaderBuilderTests.java @@ -17,7 +17,6 @@ package org.springframework.batch.core.test.ldif.builder; import org.junit.After; -import org.junit.Ignore; import org.junit.Test; import org.junit.runner.RunWith; @@ -40,7 +39,6 @@ import static org.junit.Assert.fail; * @author Glenn Renfro * @author Mahmoud Ben Hassine */ -@Ignore @RunWith(SpringRunner.class) public class LdifReaderBuilderTests { diff --git a/spring-batch-core/src/test/java/org/springframework/batch/core/test/ldif/builder/MappingLdifReaderBuilderTests.java b/spring-batch-core/src/test/java/org/springframework/batch/core/test/ldif/builder/MappingLdifReaderBuilderTests.java index b54a0bfc5..f5c9383a2 100644 --- a/spring-batch-core/src/test/java/org/springframework/batch/core/test/ldif/builder/MappingLdifReaderBuilderTests.java +++ b/spring-batch-core/src/test/java/org/springframework/batch/core/test/ldif/builder/MappingLdifReaderBuilderTests.java @@ -17,7 +17,6 @@ package org.springframework.batch.core.test.ldif.builder; import org.junit.After; -import org.junit.Ignore; import org.junit.Test; import org.junit.runner.RunWith; @@ -42,7 +41,6 @@ import static org.junit.Assert.fail; * @author Glenn Renfro * @author Mahmoud Ben Hassine */ -@Ignore @RunWith(SpringRunner.class) public class MappingLdifReaderBuilderTests { @Autowired