OPEN - issue BATCH-378: RepeatListener is confusing and too generic to use for 'intercepting' a step

http://jira.springframework.org/browse/BATCH-378

Replace RepeatListener with StepListener in TaskletStep.
This commit is contained in:
dsyer
2008-02-28 14:23:24 +00:00
parent 2a25a7a636
commit e9d74d0088
8 changed files with 302 additions and 56 deletions

View File

@@ -0,0 +1,86 @@
/*
* Copyright 2006-2007 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.springframework.batch.core.interceptor;
import java.util.ArrayList;
import java.util.List;
import junit.framework.TestCase;
import org.springframework.batch.core.domain.StepListener;
import org.springframework.batch.item.ExecutionContext;
import org.springframework.batch.repeat.ExitStatus;
/**
* @author Dave Syer
*
*/
public class CompositeStepListenerTests extends TestCase {
private CompositeStepListener listener = new CompositeStepListener();
private List list = new ArrayList();
/**
* Test method for
* {@link org.springframework.batch.core.interceptor.CompositeStepListener#setListeners(org.springframework.batch.core.domain.StepListener[])}.
*/
public void testSetListeners() {
listener.setListeners(new StepListener[] { new StepListenerSupport() {
public ExitStatus close() {
list.add("fail");
return ExitStatus.FAILED;
}
}, new StepListenerSupport() {
public ExitStatus close() {
list.add("continue");
return ExitStatus.CONTINUABLE;
}
} });
assertFalse(listener.close().isContinuable());
assertEquals(2, list.size());
}
/**
* Test method for
* {@link org.springframework.batch.core.interceptor.CompositeStepListener#setListener(org.springframework.batch.core.domain.StepListener)}.
*/
public void testSetListener() {
listener.setListener(new StepListenerSupport() {
public ExitStatus close() {
list.add("fail");
return ExitStatus.FAILED;
}
});
assertFalse(listener.close().isContinuable());
assertEquals(1, list.size());
}
/**
* Test method for
* {@link org.springframework.batch.core.interceptor.CompositeStepListener#open(org.springframework.batch.item.ExecutionContext)}.
*/
public void testOpen() {
listener.setListener(new StepListenerSupport() {
public void open(ExecutionContext executionContext) {
list.add("foo");
}
});
listener.open(new ExecutionContext());
assertEquals(1, list.size());
}
}