From f1cbb9daee0c9ecd0857ad888fc6017874d2c736 Mon Sep 17 00:00:00 2001 From: Philippe Marschall Date: Mon, 3 Aug 2015 07:42:39 +0200 Subject: [PATCH] BATCH-2411 Remove @SuppressWarnings("unchecked") The source code contains various @SuppressWarnings("unchecked") that are no longer unnecessary since the relevant APIs have been upgraded to support Java 5 generics. - remove @SuppressWarnings("unchecked") where no longer unnecessary Issue: BATCH-2411 --- .../test/java/test/jdbc/datasource/DataSourceInitializer.java | 1 - .../springframework/batch/sample/quartz/JobLauncherDetails.java | 1 - .../batch/sample/CompositeItemWriterSampleFunctionalTests.java | 2 +- .../org/springframework/batch/test/DataSourceInitializer.java | 1 - 4 files changed, 1 insertion(+), 4 deletions(-) diff --git a/spring-batch-infrastructure-tests/src/test/java/test/jdbc/datasource/DataSourceInitializer.java b/spring-batch-infrastructure-tests/src/test/java/test/jdbc/datasource/DataSourceInitializer.java index eb78cbbd4..7c3870e72 100644 --- a/spring-batch-infrastructure-tests/src/test/java/test/jdbc/datasource/DataSourceInitializer.java +++ b/spring-batch-infrastructure-tests/src/test/java/test/jdbc/datasource/DataSourceInitializer.java @@ -105,7 +105,6 @@ public class DataSourceInitializer implements InitializingBean, DisposableBean { final JdbcTemplate jdbcTemplate = new JdbcTemplate(dataSource); String[] scripts; try { - @SuppressWarnings("unchecked") String[] list = StringUtils.delimitedListToStringArray(stripComments(IOUtils.readLines(scriptResource .getInputStream())), ";"); scripts = list; diff --git a/spring-batch-samples/src/main/java/org/springframework/batch/sample/quartz/JobLauncherDetails.java b/spring-batch-samples/src/main/java/org/springframework/batch/sample/quartz/JobLauncherDetails.java index 71de3d117..d38ecd229 100644 --- a/spring-batch-samples/src/main/java/org/springframework/batch/sample/quartz/JobLauncherDetails.java +++ b/spring-batch-samples/src/main/java/org/springframework/batch/sample/quartz/JobLauncherDetails.java @@ -63,7 +63,6 @@ public class JobLauncherDetails extends QuartzJobBean { } @Override - @SuppressWarnings("unchecked") protected void executeInternal(JobExecutionContext context) { Map jobDataMap = context.getMergedJobDataMap(); String jobName = (String) jobDataMap.get(JOB_NAME); diff --git a/spring-batch-samples/src/test/java/org/springframework/batch/sample/CompositeItemWriterSampleFunctionalTests.java b/spring-batch-samples/src/test/java/org/springframework/batch/sample/CompositeItemWriterSampleFunctionalTests.java index 59dc5c668..cfae81500 100644 --- a/spring-batch-samples/src/test/java/org/springframework/batch/sample/CompositeItemWriterSampleFunctionalTests.java +++ b/spring-batch-samples/src/test/java/org/springframework/batch/sample/CompositeItemWriterSampleFunctionalTests.java @@ -104,7 +104,7 @@ public class CompositeItemWriterSampleFunctionalTests { } private void checkOutputFile(String fileName) throws IOException { - @SuppressWarnings({ "unchecked", "resource" }) + @SuppressWarnings("resource") List outputLines = IOUtils.readLines(new FileInputStream(fileName)); String output = ""; diff --git a/spring-batch-test/src/main/java/org/springframework/batch/test/DataSourceInitializer.java b/spring-batch-test/src/main/java/org/springframework/batch/test/DataSourceInitializer.java index aa5a9d176..9c18f1ce6 100755 --- a/spring-batch-test/src/main/java/org/springframework/batch/test/DataSourceInitializer.java +++ b/spring-batch-test/src/main/java/org/springframework/batch/test/DataSourceInitializer.java @@ -122,7 +122,6 @@ public class DataSourceInitializer implements InitializingBean, DisposableBean { transactionTemplate.execute(new TransactionCallback() { @Override - @SuppressWarnings("unchecked") public Void doInTransaction(TransactionStatus status) { JdbcTemplate jdbcTemplate = new JdbcTemplate(dataSource); String[] scripts;