Spring/spring-batch
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

OPEN - issue BATCH-398: That old stateful / stateless thing again....

Browse Source 
http://jira.springframework.org/browse/BATCH-398

Fix delegate job (duplicate job regsitry).
This commit is contained in:
dsyer
2008-03-01 08:35:12 +00:00
parent 6f6ea2d70e
commit f2129d4ea7
9 changed files with 66 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
spring-batch-execution/src/main/java/org/springframework/batch/execution/configuration/MapJobRegistry.java
View File

@@ -88,9 +88,9 @@ public class MapJobRegistry implements ListableJobRegistry {
/* (non-Javadoc)
* @see org.springframework.batch.container.common.configuration.ListableJobConfigurationRegistry#getJobConfigurations()
*/
public Collection getJobConfigurations() {
public Collection getJobNames() {
synchronized (map) {
return Collections.unmodifiableCollection(new HashSet(map.values()));
return Collections.unmodifiableCollection(new HashSet(map.keySet()));
}
}

2
spring-batch-execution/src/test/java/org/springframework/batch/execution/configuration/JobRegistryBeanPostProcessorTests.java
View File

@@ -101,7 +101,7 @@ public class JobRegistryBeanPostProcessorTests extends TestCase {
"test-context.xml", getClass());
MapJobRegistry registry = (MapJobRegistry) context
.getBean("registry");
Collection configurations = registry.getJobConfigurations();
Collection configurations = registry.getJobNames();
// System.err.println(configurations);
String[] names = context.getBeanNamesForType(JobSupport.class);
int count = names.length;

6
spring-batch-execution/src/test/java/org/springframework/batch/execution/configuration/MapJobRegistryTests.java
View File

@@ -81,16 +81,16 @@ public class MapJobRegistryTests extends TestCase {
}
/**
* Test method for {@link org.springframework.batch.execution.configuration.MapJobRegistry#getJobConfigurations()}.
* Test method for {@link org.springframework.batch.execution.configuration.MapJobRegistry#getJobNames()}.
* @throws Exception
*/
public void testGetJobConfigurations() throws Exception {
Job configuration = new JobSupport("foo");
registry.register(configuration);
registry.register(new JobSupport("bar"));
Collection configurations = registry.getJobConfigurations();
Collection configurations = registry.getJobNames();
assertEquals(2, configurations.size());
assertTrue(configurations.contains(configuration));
assertTrue(configurations.contains(configuration.getName()));
}
}