Spring/spring-batch
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix ignored tests

Browse Source
This commit is contained in:
Mahmoud Ben Hassine
2020-12-03 16:03:49 +01:00
parent 12926b46c9
commit f8f5cf2fb4
4 changed files with 16 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
spring-batch-core/src/test/java/org/springframework/batch/core/listener/ItemListenerErrorTests.java
View File

@@ -1,5 +1,5 @@
/*
* Copyright 2015-2019 the original author or authors.
* Copyright 2015-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -21,7 +21,6 @@ import java.util.Collections;
import java.util.List;
import org.junit.Before;
import org.junit.Ignore;
import org.junit.Test;
import org.junit.runner.RunWith;
@@ -31,6 +30,7 @@ import org.springframework.batch.core.Job;
import org.springframework.batch.core.JobExecution;
import org.springframework.batch.core.JobParameters;
import org.springframework.batch.core.Step;
import org.springframework.batch.core.StepExecution;
import org.springframework.batch.core.configuration.annotation.EnableBatchProcessing;
import org.springframework.batch.core.configuration.annotation.JobBuilderFactory;
import org.springframework.batch.core.configuration.annotation.StepBuilderFactory;
@@ -52,6 +52,7 @@ import org.springframework.test.context.junit4.SpringJUnit4ClassRunner;
* BATCH-2322
*
* @author Michael Minella
* @author Mahmoud Ben Hassine
*/
@RunWith(SpringJUnit4ClassRunner.class)
@ContextConfiguration(classes = {ItemListenerErrorTests.BatchConfiguration.class})
@@ -93,7 +94,6 @@ public class ItemListenerErrorTests {
assertEquals(BatchStatus.COMPLETED, execution.getStatus());
}
@Ignore
@Test
@DirtiesContext
public void testOnReadError() throws Exception {
@@ -101,7 +101,16 @@ public class ItemListenerErrorTests {
reader.setGoingToFail(true);
JobExecution execution = jobLauncher.run(job, new JobParameters());
assertEquals(BatchStatus.COMPLETED, execution.getStatus());
assertEquals(BatchStatus.FAILED, execution.getStatus());
StepExecution stepExecution = execution.getStepExecutions().iterator().next();
assertEquals(0, stepExecution.getReadCount());
assertEquals(50, stepExecution.getReadSkipCount());
List<Throwable> failureExceptions = stepExecution.getFailureExceptions();
assertEquals(1, failureExceptions.size());
Throwable failureException = failureExceptions.iterator().next();
assertEquals("Skip limit of '50' exceeded", failureException.getMessage());
assertEquals("Error in onReadError.", failureException.getCause().getMessage());
assertEquals("onReadError caused this Exception", failureException.getCause().getCause().getMessage());
}
@Test

4
spring-batch-core/src/test/java/org/springframework/batch/core/step/item/FaultTolerantStepFactoryBeanUnexpectedRollbackTests.java
View File

@@ -1,5 +1,5 @@
/*
* Copyright 2010-2014 the original author or authors.
* Copyright 2010-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -17,7 +17,6 @@ package org.springframework.batch.core.step.item;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
import org.junit.Ignore;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.springframework.batch.core.BatchStatus;
@@ -56,7 +55,6 @@ public class FaultTolerantStepFactoryBeanUnexpectedRollbackTests {
private DataSource dataSource;
@Test
@Ignore //FIXME
public void testTransactionException() throws Exception {
final SkipWriterStub<String> writer = new SkipWriterStub<>();