diff --git a/spring-batch-samples/src/main/java/org/springframework/batch/sample/domain/trade/internal/TradeRowMapper.java b/spring-batch-samples/src/main/java/org/springframework/batch/sample/domain/trade/internal/TradeRowMapper.java index 8ca36055f..b2451ada6 100644 --- a/spring-batch-samples/src/main/java/org/springframework/batch/sample/domain/trade/internal/TradeRowMapper.java +++ b/spring-batch-samples/src/main/java/org/springframework/batch/sample/domain/trade/internal/TradeRowMapper.java @@ -38,7 +38,7 @@ public class TradeRowMapper implements RowMapper { trade.setQuantity(rs.getLong(QUANTITY_COLUMN)); trade.setPrice(rs.getBigDecimal(PRICE_COLUMN)); trade.setCustomer(rs.getString(CUSTOMER_COLUMN)); - trade.setVersion(rs.getLong(VERSION_COLUMN)); + trade.setVersion(rs.getInt(VERSION_COLUMN)); return trade; } diff --git a/spring-batch-samples/src/main/resources/jobs/tradeJob.xml b/spring-batch-samples/src/main/resources/jobs/tradeJob.xml index 5e98b2e03..ae0382340 100644 --- a/spring-batch-samples/src/main/resources/jobs/tradeJob.xml +++ b/spring-batch-samples/src/main/resources/jobs/tradeJob.xml @@ -47,7 +47,7 @@ - + diff --git a/spring-batch-samples/src/test/java/org/springframework/batch/sample/TradeJobFunctionalTests.java b/spring-batch-samples/src/test/java/org/springframework/batch/sample/TradeJobFunctionalTests.java index 5d1c26019..979018e7a 100644 --- a/spring-batch-samples/src/test/java/org/springframework/batch/sample/TradeJobFunctionalTests.java +++ b/spring-batch-samples/src/test/java/org/springframework/batch/sample/TradeJobFunctionalTests.java @@ -43,7 +43,7 @@ import org.springframework.test.context.junit4.SpringJUnit4ClassRunner; @ContextConfiguration() public class TradeJobFunctionalTests extends AbstractValidatingBatchLauncherTests { - private static final String GET_TRADES = "select ISIN, QUANTITY, PRICE, CUSTOMER from TRADE order by ISIN"; + private static final String GET_TRADES = "select ISIN, QUANTITY, PRICE, CUSTOMER, ID, VERSION from TRADE order by ISIN"; private static final String GET_CUSTOMERS = "select NAME, CREDIT from CUSTOMER order by NAME"; private List customers; diff --git a/spring-batch-samples/src/test/java/org/springframework/batch/sample/domain/trade/internal/TradeRowMapperTests.java b/spring-batch-samples/src/test/java/org/springframework/batch/sample/domain/trade/internal/TradeRowMapperTests.java index 5c99f4552..25fef44c1 100644 --- a/spring-batch-samples/src/test/java/org/springframework/batch/sample/domain/trade/internal/TradeRowMapperTests.java +++ b/spring-batch-samples/src/test/java/org/springframework/batch/sample/domain/trade/internal/TradeRowMapperTests.java @@ -1,6 +1,6 @@ package org.springframework.batch.sample.domain.trade.internal; -import static org.easymock.EasyMock.*; +import static org.easymock.EasyMock.expect; import java.math.BigDecimal; import java.sql.ResultSet; @@ -31,10 +31,12 @@ public class TradeRowMapperTests extends AbstractRowMapperTests { } protected void setUpResultSetMock(ResultSet rs) throws SQLException { + expect(rs.getLong(TradeRowMapper.ID_COLUMN)).andReturn(12L); expect(rs.getString(TradeRowMapper.ISIN_COLUMN)).andReturn(ISIN); expect(rs.getLong(TradeRowMapper.QUANTITY_COLUMN)).andReturn(QUANTITY); expect(rs.getBigDecimal(TradeRowMapper.PRICE_COLUMN)).andReturn(PRICE); expect(rs.getString(TradeRowMapper.CUSTOMER_COLUMN)).andReturn(CUSTOMER); + expect(rs.getInt(TradeRowMapper.VERSION_COLUMN)).andReturn(0); } } diff --git a/spring-batch-samples/src/test/java/org/springframework/batch/sample/support/ItemTrackingItemWriterTests.java b/spring-batch-samples/src/test/java/org/springframework/batch/sample/support/ItemTrackingItemWriterTests.java index 20f58af5e..48b4d654e 100644 --- a/spring-batch-samples/src/test/java/org/springframework/batch/sample/support/ItemTrackingItemWriterTests.java +++ b/spring-batch-samples/src/test/java/org/springframework/batch/sample/support/ItemTrackingItemWriterTests.java @@ -18,6 +18,7 @@ package org.springframework.batch.sample.support; import static org.junit.Assert.assertEquals; import static org.junit.Assert.fail; +import java.io.IOException; import java.util.Arrays; import org.junit.Test; @@ -58,7 +59,7 @@ public class ItemTrackingItemWriterTests { writer.write(Arrays.asList(a, b, c)); fail("Expected Write Failure Exception"); } - catch (RuntimeException e) { + catch (IOException e) { // expected } // the failed item is removed