Spring/spring-batch
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

RESOLVED - issue BATCH-1316: JobParameters throws NullPointerException on missing key

Browse Source
This commit is contained in:
dsyer
2009-11-24 10:04:15 +00:00
parent f4b0672520
commit fc37dc27c9
5 changed files with 58 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
spring-batch-core/src/test/java/org/springframework/batch/core/JobParameterTests.java
View File

@@ -23,6 +23,12 @@ public class JobParameterTests {
assertEquals("test", jobParameter.getValue());
}
@Test
public void testNullStringParameter(){
jobParameter = new JobParameter((String)null);
assertEquals(null, jobParameter.getValue());
}
@Test
public void testLongParameter(){
jobParameter = new JobParameter(1L);
@@ -42,6 +48,12 @@ public class JobParameterTests {
assertEquals(new Date(0L), jobParameter.getValue());
}
@Test
public void testNullDateParameter(){
jobParameter = new JobParameter((Date)null);
assertEquals(null, jobParameter.getValue());
}
@Test
public void testDateParameterToString(){
Date epoch = new Date(0L);
@@ -56,4 +68,32 @@ public class JobParameterTests {
assertTrue(jobParameter.equals(testParameter));
}
@Test
public void testHashcode(){
jobParameter = new JobParameter("test");
JobParameter testParameter = new JobParameter("test");
assertEquals(testParameter.hashCode(), jobParameter.hashCode());
}
@Test
public void testEqualsWithNull(){
jobParameter = new JobParameter((String)null);
JobParameter testParameter = new JobParameter((String)null);
assertTrue(jobParameter.equals(testParameter));
}
@Test
public void testEqualsWithNullAndDifferentType(){
jobParameter = new JobParameter((String)null);
JobParameter testParameter = new JobParameter((Date)null);
assertFalse(jobParameter.equals(testParameter));
}
@Test
public void testHashcodeWithNull(){
jobParameter = new JobParameter((String)null);
JobParameter testParameter = new JobParameter((String)null);
assertEquals(testParameter.hashCode(), jobParameter.hashCode());
}
}

10
spring-batch-core/src/test/java/org/springframework/batch/core/JobParametersBuilderTests.java
View File

@@ -29,6 +29,16 @@ public class JobParametersBuilderTests extends TestCase {
assertEquals("string value", parameters.getString("STRING"));
}
public void testNullRuntimeParamters(){
parametersBuilder.addDate("SCHEDULE_DATE", null);
parametersBuilder.addLong("LONG", null);
parametersBuilder.addString("STRING", null);
JobParameters parameters = parametersBuilder.toJobParameters();
assertEquals(null, parameters.getDate("SCHEDULE_DATE"));
assertEquals(0L, parameters.getLong("LONG"));
assertEquals(null, parameters.getString("STRING"));
}
public void testCopy(){
parametersBuilder.addString("STRING", "string value");
parametersBuilder = new JobParametersBuilder(parametersBuilder.toJobParameters());