Resolved some TODOs.

This commit is contained in:
dsyer
2008-01-28 13:56:48 +00:00
parent 39ea7775bd
commit fd012bd49c
21 changed files with 36 additions and 869 deletions

View File

@@ -40,16 +40,12 @@ public class IbatisCustomerCreditWriter extends SqlMapClientDaoSupport
* @see org.springframework.batch.item.ResourceLifecycle#close()
*/
public void close() {
// TODO Auto-generated method stub
}
/* (non-Javadoc)
* @see org.springframework.batch.item.ResourceLifecycle#open()
*/
public void open() {
// TODO Auto-generated method stub
}

View File

@@ -92,28 +92,6 @@
<bean id="notificationPublisher"
class="org.springframework.batch.execution.bootstrap.JobExecutionNotificationPublisher" />
<bean id="convertingMethodInterceptor"
class="org.springframework.batch.execution.bootstrap.support.TypeConverterMethodInterceptor">
<property name="convertException" value="true" />
<property name="customEditors">
<map>
<entry
key="org.springframework.batch.core.domain.JobParameters">
<bean
class="org.springframework.batch.execution.bootstrap.support.JobParametersPropertyEditor" />
</entry>
<entry
key="org.springframework.batch.core.domain.Job">
<bean
class="org.springframework.batch.execution.bootstrap.support.JobPropertyEditor">
<property name="jobLocator"
ref="jobConfigurationRegistry" />
</bean>
</entry>
</map>
</property>
</bean>
<bean id="logAdvice"
class="org.springframework.batch.sample.advice.MethodExecutionLogAdvice" />

View File

@@ -68,16 +68,6 @@ public class HibernateFailureJobFunctionalTests extends
assertEquals(before, after);
}
/*
* (non-Javadoc)
*
* @see org.springframework.batch.sample.AbstractCustomerCreditIncreaseTests#validatePostConditions()
*/
protected void validatePostConditions() throws Exception {
// TODO: fix so that the postconditions in super class are true
super.validatePostConditions();
}
/*
* (non-Javadoc)
*

View File

@@ -21,12 +21,10 @@ public class JdbcPlayerDaoIntegrationTests extends AbstractTransactionalDataSour
private static final String GET_PLAYER = "SELECT * from PLAYERS";
protected String[] getConfigLocations() {
// TODO Auto-generated method stub
return new String[] {"data-source-context.xml"};
}
protected void onSetUpBeforeTransaction() throws Exception {
// TODO Auto-generated method stub
super.onSetUpBeforeTransaction();
playerDao = new JdbcPlayerDao();