Spring/spring-batch
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

RESOLVED - issue BATCH-554: *StepFactoryBeans should have a list of exceptions that do and don't cause rollback.

Browse Source 
Removed the list of exceptions in favour of tx attributes (use +ExceptionType in config file)
This commit is contained in:
dsyer
2008-06-23 13:06:07 +00:00
parent f328615102
commit fd07883253
5 changed files with 63 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
spring-batch-core/src/test/java/org/springframework/batch/core/step/item/SkipLimitStepFactoryBeanTests.java
View File

@@ -29,6 +29,7 @@ import org.springframework.batch.item.UnexpectedInputException;
import org.springframework.batch.item.support.ListItemReader;
import org.springframework.batch.support.transaction.ResourcelessTransactionManager;
import org.springframework.batch.support.transaction.TransactionAwareProxyFactory;
import org.springframework.transaction.interceptor.DefaultTransactionAttribute;
import org.springframework.util.StringUtils;
/**
@@ -97,10 +98,14 @@ public class SkipLimitStepFactoryBeanTests extends TestCase {
/**
* Check skippable write exception does not cause rollback when included on
* {@link SkipLimitStepFactoryBean#setNoRollbackForExceptionClasses(Class[])}.
* transaction attributes as "no rollback for".
*/
public void testSkipWithoutRethrow() throws Exception {
factory.setNoRollbackForExceptionClasses(new Class[] { SkippableRuntimeException.class });
factory.setTransactionAttribute(new DefaultTransactionAttribute() {
public boolean rollbackOn(Throwable ex) {
return !(ex instanceof SkippableRuntimeException);
};
});
AbstractStep step = (AbstractStep) factory.getObject();
StepExecution stepExecution = new StepExecution(step.getName(), jobExecution);