Spring/spring-batch
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
415 Commits 16 Branches 0 Tags
44463f393abdb2764223a5ae3f9d02fbc2ea7220
Commit Graph

158 Commits

Author SHA1 Message Date
dsyer
44463f393a RESOLVED - issue BATCH-199: ExceptionHandler in SImpleStepConfiguration ignored by SimpleStepConfigurationFactory 
http://opensource.atlassian.com/projects/spring/browse/BATCH-199

Moved ExecptionHandler to the step operations.

It seemed to me that the responsibility for doing this should be encapsulated in the StepExecutor - also prevents a nasty package cycle.  The only way to do this and keep everyone honest was to add an applyConfiguration() method to the StepExecutor interface.  I am open to suggestion about how to do this more cleanly, but for now that is probably enough.
 2007-11-23 15:45:00 +00:00
dsyer
3915aeb1e9 IN PROGRESS - issue BATCH-194: Incorrect exception handling when using Hibernate 
http://opensource.atlassian.com/projects/spring/browse/BATCH-194

Implemented a pretty good workaround in HibernateCreditWriter, which can probably be tightened up and made into a base class HibernateItemWriter.  Also had to make HibernateCursorInputSource Skippable (and it isn't yet Restartable so it's kind of broken - work in progress).  Plus the samples were configured to use SimpleStepExecutor which doesn't skip by default (makes me wonder if the restart sample actually does anything sensible).
 2007-11-22 13:51:53 +00:00
dsyer
d7744aafb8 IN PROGRESS - issue BATCH-194: Incorrect exception handling when using Hibernate 
http://opensource.atlassian.com/projects/spring/browse/BATCH-194

Added step operations to RepeatContextHolder (and changed name of implementation so it isn't tied to chunks).  This was needed anyway, otherwise you can't control the exception handling in the step operations properly.
 2007-11-22 09:54:44 +00:00
dsyer
c3bf46f098 replace missing DDL (Subclipse again) 2007-11-21 12:52:42 +00:00
dsyer
761a89b3eb RESOLVED - issue BATCH-207: exit_message too short for holding long exceptions 
http://opensource.atlassian.com/projects/spring/browse/BATCH-207

JOB_KEY needed to be extended as well (not truncated as yet - just made more space in DDL).
 2007-11-21 12:51:08 +00:00
dsyer
edff6be9b3 OPEN - issue BATCH-207: exit_message too short for holding long exceptions 
http://opensource.atlassian.com/projects/spring/browse/BATCH-207

Added onFlushDirty to the entity interceptor in hibernate (and changed its name so not specific to entity name - BatchHibernateInterceptor).  Also truncating in Sql*Dao.  Only exit description is given special treatment for now, and the length is fixed at 250 - hard-coded and tightly coupled with the hibernate mapping and DDL).  Should be good enough for most scenarios.
 2007-11-21 12:34:57 +00:00
dsyer
83ea77d669 update description of statistics (http://forum.springframework.org/showthread.php?t=46482). 2007-11-21 08:33:59 +00:00
dsyer
07be8cf6d8 IN PROGRESS - issue BATCH-201: Move responsibility for deciding if an exception terminates a batch to ExceptionHandler 
http://opensource.atlassian.com/projects/spring/browse/BATCH-201

Nearly finished - ExceptionHandler is the owner of abnormal termination.
 2007-11-20 18:55:15 +00:00
dsyer
1c95e5a625 RESOLVED - issue BATCH-203: HibernateDao incorrectly returns an existing job. 
http://opensource.atlassian.com/projects/spring/browse/BATCH-203
 2007-11-14 08:49:48 +00:00
dsyer
dbf9336e60 Change logging level of error in RepeatTemplate 2007-11-14 08:48:08 +00:00
dsyer
645b882ff3 Fix SqlJobDao for DefaultJobIdentifier 2007-11-13 17:51:08 +00:00
dsyer
f8956695f4 Fix exception messages 2007-11-13 17:42:44 +00:00
dsyer
c23620bc2a Include backport in dependencies for samples 2007-11-13 16:30:06 +00:00
dsyer
120c9cc512 RESOLVED - issue BATCH-199: ExceptionHandler in SImpleStepConfiguration ignored by SimpleStepConfigurationFactory 
http://opensource.atlassian.com/projects/spring/browse/BATCH-199
 2007-11-13 15:49:51 +00:00
dsyer
a541e280aa RESOLVED - issue BATCH-199: ExceptionHandler in SImpleStepConfiguration ignored by SimpleStepConfigurationFactory 
http://opensource.atlassian.com/projects/spring/browse/BATCH-199
 2007-11-13 15:48:50 +00:00
dsyer
d33065b15c RESOLVED - issue BATCH-184: sample jobs don't work with hibernate repository 
http://opensource.atlassian.com/projects/spring/browse/BATCH-184
 2007-11-13 14:16:07 +00:00
dsyer
4f8489c145 RESOLVED - issue BATCH-195: JobIdentifier with simple string key 
http://opensource.atlassian.com/projects/spring/browse/BATCH-195

Missing commit.
 2007-11-09 17:06:46 +00:00
dsyer
ec63a1c1a1 RESOLVED - issue BATCH-195: JobIdentifier with simple string key 
http://opensource.atlassian.com/projects/spring/browse/BATCH-195
 2007-11-09 16:50:28 +00:00
dsyer
dc9d04e705 RESOLVED - issue BATCH-181: When trying to re-run a Job that already executed successfully the JobExecutorFacade returns ExitStatus.FAILED 
http://opensource.atlassian.com/projects/spring/browse/BATCH-181
 2007-11-09 15:03:29 +00:00
lucasward
e0977c3e48 BATCH-184:Reverted previous change. I thought I had it working locally, but bamboo proved me wrong. 2007-11-09 07:29:28 +00:00
lucasward
80f6c02e55 BATCH-184:Applied patch to prevent NonUniqueJobException by clearing the returned execution from the cache. 2007-11-09 07:03:32 +00:00
dsyer
fd38ac3d14 Add new addExitDescription() to ExitStatus and make sure a message is set if no steps are run. 2007-11-07 11:49:04 +00:00
dsyer
82f753e18f Weird problem with eclipse build - was it just the .classpath entries not being exported? 2007-11-07 08:04:07 +00:00
dsyer
c7b8d038e7 Internal API change for StepExecutors 2007-11-05 17:17:33 +00:00
dsyer
875d1383b4 Add explicit types to update queries. 2007-11-05 17:16:42 +00:00
dsyer
621250dd79 IN PROGRESS - issue BATCH-159: JobExecutor should return a JobExecution (which itself contains the ExitStatus) 
http://opensource.atlassian.com/projects/spring/browse/BATCH-159

Change JobExecutorFacade interface - it makes more sense to stop an execution.
 2007-11-05 12:51:22 +00:00
dsyer
9810bf7223 Remove cycle 2007-11-05 11:45:34 +00:00
dsyer
7f09f4214c IN PROGRESS - issue BATCH-159: JobExecutor should return a JobExecution (which itself contains the ExitStatus) 
http://opensource.atlassian.com/projects/spring/browse/BATCH-159

Make sure JobExecution has an ID (it is saved before being passed back to client).
 2007-11-03 13:51:56 +00:00
dsyer
626f01f8f5 Copy testcase base class to execution module (fix broken build). 2007-11-03 11:25:28 +00:00
dsyer
0cf5cb4bb2 IN PROGRESS - issue BATCH-159: JobExecutor should return a JobExecution (which itself contains the ExitStatus) 
http://opensource.atlassian.com/projects/spring/browse/BATCH-159

APIs all pretty much in place now - JobLauncher returns JobExecution from the run methods.  There is some polishing and test coverage work to do.
 2007-11-03 11:18:00 +00:00
dsyer
3e72e7b565 Remove convenience accessor for job.getIdentifier() 2007-11-02 16:03:38 +00:00
dsyer
f66d163275 IN PROGRESS - issue BATCH-159: JobExecutor should return a JobExecution (which itself contains the ExitStatus) 
http://opensource.atlassian.com/projects/spring/browse/BATCH-159

Fix broken test case for misconfigured launcher
 2007-11-02 15:51:31 +00:00
dsyer
4a00848fce IN PROGRESS - issue BATCH-159: JobExecutor should return a JobExecution (which itself contains the ExitStatus) 
http://opensource.atlassian.com/projects/spring/browse/BATCH-159

Refactored JobExecutorFacade into a package private interface - it's still useful in testing.
 2007-11-02 12:29:18 +00:00
dsyer
5b2b92da18 IN PROGRESS - issue BATCH-159: JobExecutor should return a JobExecution (which itself contains the ExitStatus) 
http://opensource.atlassian.com/projects/spring/browse/BATCH-159

Merged JobLauncher implementations together and separated out thread interruption and JMX notification responsibilities to separate collaborators.
 2007-10-24 17:35:05 +00:00
dsyer
1981dedbf0 IN PROGRESS - issue BATCH-159: JobExecutor should return a JobExecution (which itself contains the ExitStatus) 
http://opensource.atlassian.com/projects/spring/browse/BATCH-159

Move JobExecutionListener to core and add some Javadocs.
 2007-10-23 18:45:48 +00:00
dsyer
dcdeeb7b6f Delete unused test case (curse to Subclipse) 2007-10-23 13:16:46 +00:00
dsyer
e41d046165 IN PROGRESS - issue BATCH-159: JobExecutor should return a JobExecution (which itself contains the ExitStatus) 
http://opensource.atlassian.com/projects/spring/browse/BATCH-159

Rollback previous change...
 2007-10-23 13:05:47 +00:00
dsyer
045e476ab5 IN PROGRESS - issue BATCH-159: JobExecutor should return a JobExecution (which itself contains the ExitStatus) 
http://opensource.atlassian.com/projects/spring/browse/BATCH-159

Use package access instead of reflection to get to registry inside facade
 2007-10-23 13:04:16 +00:00
dsyer
1d97a14dc8 IN PROGRESS - issue BATCH-159: JobExecutor should return a JobExecution (which itself contains the ExitStatus) 
http://opensource.atlassian.com/projects/spring/browse/BATCH-159

Remove JobExecutionRegistry abstraction (not used).
 2007-10-23 12:57:37 +00:00
dsyer
82e8f47ef7 OPEN - issue BATCH-159: JobExecutor should return a JobExecution (which itself contains the ExitStatus) 
http://opensource.atlassian.com/projects/spring/browse/BATCH-159

Add listeners to JobExecutionFacade
 2007-10-22 19:46:21 +00:00
dsyer
089ac8f171 RESOLVED - issue BATCH-180: JobConfigurations do not get their names set if they are child beans 
http://opensource.atlassian.com/projects/spring/browse/BATCH-180

Removed setName() from *Configuration - you have to use the bean id or setBeanName().
 2007-10-21 15:10:41 +00:00
lucasward
2c5c74a4a6 BATCH-172 - Added additional error checking to HibernateDao 2007-10-16 16:41:30 +00:00
lucasward
0997e173d6 BATCH-172- HibernateDao not persisting Identifier details. 
I added some additional tests to the HibernateJobDaoTests in an attempt to replicate, but all tests pass successfully.
 2007-10-16 16:39:41 +00:00
lucasward
eab243ff3f BATCH 144 and BATCH 150: create Hibernate and iBatis input sources with sample jobs. 2007-10-15 05:23:37 +00:00
dsyer
30302f3d1f Stop job broken (stop All works) because Timestamp!=Date. Fixed in ScheduledJobIdentifier.equals() and unit test. 2007-10-14 12:48:55 +00:00
dsyer
fafc8bdd7a RESOLVED - issue BATCH-121: BatchResourceFactoryBean - needs to be aware of JobIdentifier strategy 
http://opensource.atlassian.com/projects/spring/browse/BATCH-121

Factored label generation out of job identifier into a separate strategy for resource factory
 2007-10-14 08:07:37 +00:00
dsyer
7f6a846120 Javadocs to clarify a little the absolute path issue. 2007-10-12 13:56:19 +00:00
dsyer
997d6f855c Remove syserr debug statements from unit test 2007-10-12 13:50:52 +00:00
dsyer
f6b0bfdb47 Fixed filepaths again for UNIX build 2007-10-12 13:49:44 +00:00
dsyer
db405df7a4 FIXED: Destruction callback not made for inner beans 2007-10-12 12:22:34 +00:00