Commit Graph

204 Commits

Author SHA1 Message Date
robokaso
4a1fb49053 RESOLVED - BATCH-558: TaskletAdapter still maps to CONTINUABLE by default
changed the default return value to ExitStatus.FINISHED
2008-04-07 08:19:22 +00:00
dsyer
7dcda664c3 RESOLVED - issue BATCH-546: pull duplicates from TaskletStep and ItemOrientedStep into AbstractStep
Tidied up by changing visibility of some methods and fields.
2008-04-04 16:54:29 +00:00
robokaso
9a222286b8 RESOLVED - issue BATCH-546: pull duplicates from TaskletStep and ItemOrientedStep into AbstractStep 2008-04-04 14:57:27 +00:00
robokaso
1b659fe744 IN PROGRESS - issue BATCH-546: pull duplicates from TaskletStep and ItemOrientedStep into AbstractStep
pulled up jobRepository property
2008-04-03 11:23:21 +00:00
dsyer
4ce2a39f30 RESOLVED - issue BATCH-551: Put some checks in skip so that poor key generation algorithms do not cause weird looking failures.
Added skipCacheCapacity as configurable for skip limit factory bean.
2008-04-03 11:09:13 +00:00
robokaso
986baed232 IN PROGRESS - issue BATCH-546: pull duplicates from TaskletStep and ItemOrientedStep into AbstractStep
pulled up listener registration to AbstractStep
2008-04-03 09:08:41 +00:00
robokaso
27ce423bea RESOLVED - issue BATCH-542: StatefulRetryStepFactoryBean still uses a local variable that refers to item provider 2008-04-02 08:18:42 +00:00
dsyer
b050f95f03 RESOLVED - issue BATCH-537: Bad ItemKeyGenerator strategy can lead to infinite loop in retry
Some changes to account for retry exceptions and force a failure if strange hashCode/equals are detected.
2008-04-01 20:09:51 +00:00
robokaso
bff748f576 RESOLVED - issue BATCH-532: StepExecutionListener can influence exit status but not status of step execution
removed the try/catch block around listener.afterStep()
updated javadoc for StepExecutionListener#afterStep(..)
2008-04-01 11:40:59 +00:00
robokaso
7746cfc304 RESOLVED - issue BATCH-529: StepExecutionListener.afterStep() should only be called on success
RESOLVED - issue BATCH-532: StepExecutionListener can influence exit status but not status of step execution

listener.afterStep() call moved from catch block to the end of the try block
2008-04-01 11:07:53 +00:00
robokaso
4f74d0c9f7 RESOLVED - issue BATCH-527: StepExecutionResourceProxy toString() should delegate to delegate.toString() 2008-03-31 14:05:03 +00:00
robokaso
973e146aa3 RESOLVED - issue BATCH-533: prefix in the JobRepositoryFactoryBean does not apply to the sequences 2008-03-31 12:52:44 +00:00
dsyer
0ada1fcaaa RESOLVED - issue BATCH-486: Users must choose between skip and retry
Tweak the retry policy to account for fatal exceptions as well (they should not be retryable).
2008-03-28 12:14:45 +00:00
lucasward
c736462553 Reverted back to original prepared statement setter. The ExecutionContext wasn't doing much good in it, since other database reader changes weren't committed. However, being able to set the JobParameters still provides value for the cursor item reader. 2008-03-28 05:32:08 +00:00
dsyer
9007a61f5e RESOLVED - issue BATCH-486: Users must choose between skip and retry
Remove duplicate key generator property from factory beans.
2008-03-27 17:30:24 +00:00
dsyer
e4c3048414 RESOLVED - issue BATCH-486: Users must choose between skip and retry
Used inheritance to mix retry and skip in a factory bean.
2008-03-27 17:23:36 +00:00
dsyer
37f59f3fab OPEN - issue BATCH-486: Users must choose between skip and retry 2008-03-27 16:08:16 +00:00
dsyer
0f84d3064a OPEN - issue BATCH-486: Users must choose between skip and retry
Removed itemReader from retry callback - simplifies stateful retry and makes the ugly exception handling problem go away.
2008-03-27 15:21:20 +00:00
dsyer
d983eba1c5 RESOLVED - issue BATCH-511: read failures cause rollback
Renamed "commit*" in StepContribution to "combine*".  Fixed broken test (forgot to combine skip counts).
2008-03-27 10:48:04 +00:00
dsyer
e46c972d8e REOPENED - issue BATCH-511: read failures cause rollback 2008-03-27 10:30:06 +00:00
robokaso
419fa9794d javadoc typo corrected 2008-03-27 10:02:50 +00:00
dsyer
914b9f2bed REOPENED - issue BATCH-511: read failures cause rollback
Add SkipLimitExceededException to the list of fatal exceptions for the step exception handler
2008-03-27 06:41:37 +00:00
lucasward
b876649cb9 BATCH-514:Additional small refactorings on Jdbc readers. 2008-03-27 04:37:58 +00:00
dsyer
2faea9d266 rename synchronizer with wrong spelling 2008-03-26 19:57:01 +00:00
robokaso
ca2db2c31a RESOLVED - issue BATCH-516: default to commitInterval=1 in SimpleStepFactoryBean
http://jira.springframework.org/browse/BATCH-516
2008-03-26 13:58:04 +00:00
robokaso
6989745c12 RESOLVED - issue BATCH-510: FlatFileItemWriter.restarted logic fails if step fails before first chunk commit.
http://jira.springframework.org/browse/BATCH-510

added initial save of execution context before first chunk
2008-03-26 09:45:07 +00:00
dsyer
f690e39440 RESOLVED - issue BATCH-513: CompositeItemReadListener, CompositeItemWriteListener using ChunkListeners?
Changed signature of methods
2008-03-26 06:41:44 +00:00
dsyer
08ceb9d962 RESOLVED - issue BATCH-498: Skip method should get ExecutionContext as an argument 2008-03-26 06:37:01 +00:00
dsyer
546010c887 OPEN - issue BATCH-498: Skip method should get ExecutionContext as an argument
Added SkipListener as new StepListener.
2008-03-25 19:15:00 +00:00
dsyer
dba4209d7e OPEN - issue BATCH-498: Skip method should get ExecutionContext as an argument
Handle skip internally in ItemHandler.
2008-03-25 17:11:35 +00:00
dsyer
1ac5a5296a RESOLVED - issue BATCH-506: JobListener is not a BatchListener
Changed BatchListener to StepListener and renamed existing Job/StepListener as *ExecutionListener.
2008-03-25 12:29:55 +00:00
nebhale
4f3bf4ffaf [BATCH-478] Applied patch 2008-03-25 11:08:47 +00:00
nebhale
8b8288d8d8 [BATCH-496] Added more descriptive error messages 2008-03-25 11:04:23 +00:00
robokaso
786fcd9bb9 IN PROGRESS - issue BATCH-491: checked exception handling
http://jira.springframework.org/browse/BATCH-491

exception handler signature changed to 'throws Throwable' so that it can simply rethrow without wrapping.
2008-03-25 10:01:47 +00:00
dsyer
37d35f42eb RESOLVED - issue BATCH-467: Remove ExitStatusExceptionClassifier / Rewrite SimpleExitStatusExceptionClassifier as a JobListener
Removed the interface and implementation, checked that defautl behaviour is same using unit test ItemOrientedStepTests
2008-03-25 09:08:14 +00:00
lucasward
bb42725f3f BATCH-377: A PreparedStatement can now be set on JdbcCursorItemReader. Also created a JobParametersPreparedStatementSetter, that when registered as a StepListener will set the values on a prepared statement with values from a PreparedStatement. 2008-03-21 04:11:45 +00:00
robokaso
6959c40158 IN PROGRESS - issue BATCH-495: readers must not clear buffers on mark()
http://jira.springframework.org/browse/BATCH-495

moved the initial itemHandler.mark() out of the loop
2008-03-20 16:21:18 +00:00
robokaso
4cc2e03fbd RESOLVED - issue BATCH-485: SkippableExceptionClasses should be inverted
http://jira.springframework.org/browse/BATCH-485

SkipLimitStepFactoryBean now declares setter for fatal exceptions that are never skipped and immediately rethrown by exception handlerRESOLVED - issue BATCH-485: SkippableExceptionClasses should be inverted 
http://jira.springframework.org/browse/BATCH-485

SkipLimitStepFactoryBean now declares setter for fatal exceptions that are never skipped and immediately rethrown by exception handler.
LimitCheckingItemSkipPolicy and SimpleLimitExceptionHandler were modified to recognize fatal exceptions.
2008-03-20 10:04:27 +00:00
dsyer
fc1e7debd9 RESOLVED - issue BATCH-492: CommandLineJobRunner should close the spring context 2008-03-19 14:55:58 +00:00
robokaso
d4710ab1be OPEN - issue BATCH-490: SkipLimitStepFactoryBean ignores the skippableExceptionClasses property
http://jira.springframework.org/browse/BATCH-490

fixed the obvious bug, but found deeper issue (see TODO in tests)
2008-03-19 13:58:52 +00:00
dsyer
f8a74f39ac RESOLVED - issue BATCH-489: undocumented JobExecutionException 2008-03-19 13:44:05 +00:00
robokaso
30d6e80af7 REOPENED - issue BATCH-472: Exceeding the start limit on a step will cause a vague exception type to be thrown.
http://jira.springframework.org/browse/BATCH-472

added throws StartLimitExceedException to SimpleJob#execute(..) javadoc
2008-03-19 12:31:08 +00:00
robokaso
1851025c54 REOPENED - issue BATCH-472: Exceeding the start limit on a step will cause a vague exception type to be thrown.
http://jira.springframework.org/browse/BATCH-472

StartLimitExceededException made public and moved to core package. The constructor changed to simply accept string.
2008-03-19 09:31:10 +00:00
robokaso
9f9d909b5a RESOLVED - issue BATCH-472: Exceeding the start limit on a step will cause a vague exception type to be thrown.
http://jira.springframework.org/browse/BATCH-472

added package-private StartLimitExceededException (subclass of UnexpectedJobExecutionException), that takes Step as constructor argument and creates appropriate message
2008-03-18 09:55:07 +00:00
robokaso
8768f15581 RESOLVED - issue BATCH-479: JobRepositoryFactoryBean should allow specification of JDBC table prefixes
http://jira.springframework.org/browse/BATCH-479

applied patch (with minor tweaks)
2008-03-18 09:19:31 +00:00
dsyer
4b152bbc7e Exception message tidied up. 2008-03-17 11:11:42 +00:00
robokaso
f202dd4b44 RESOLVED - issue BATCH-461: skip counting
http://jira.springframework.org/browse/BATCH-461

ItemOrientedStep now increments StepExecution's skipCount from StepContribution on rollback.
Simple assert checking the correct value of StepExecution#skipCount added to SkipLimitStepFactoryBeanTests.

Btw. renamed StepContribution#taskCount to itemCount
2008-03-17 10:20:48 +00:00
dsyer
271d6815c7 RESOLVED - issue BATCH-465: The term "exit code" is overloaded
RESOLVED - issue BATCH-468: ExitStatusExceptionClassifier, ExitCodeMapper and simple versions thereof (and others?) incorrectly moved into step.item package
2008-03-15 08:56:50 +00:00
dsyer
ff85f455de RESOLVED - issue BATCH-456: JobListener.afterJob() should be called regardless of success or failure
Added onInterrupt callback.
2008-03-14 17:43:41 +00:00
dsyer
ec2c66885d RESOLVED - issue BATCH-464: Throw exception if restart is attempted on job instance that was already completed successfully 2008-03-14 17:09:26 +00:00