Commit Graph

73 Commits

Author SHA1 Message Date
robokaso
7368aa3541 IN PROGRESS - issue BATCH-340: Refactor JobRepository for greater clarity and consistency.
http://jira.springframework.org/browse/BATCH-340

more StepInstance heritage cleaned up - StepExecution refers to Step rather than stepName string
2008-02-25 17:21:46 +00:00
robokaso
4b0edc1799 IN PROGRESS - issue BATCH-340: Refactor JobRepository for greater clarity and consistency.
http://jira.springframework.org/browse/BATCH-340

tweaking repo & dao interfaces to use domain objects instead of primitive types
2008-02-25 14:40:05 +00:00
robokaso
4e05642f98 IN PROGRESS - issue BATCH-340: Refactor JobRepository for greater clarity and consistency.
http://jira.springframework.org/browse/BATCH-340

JobInstance now has not-null Job as required constructor argument - repository no longer requires a separate Job setter
2008-02-25 13:50:53 +00:00
robokaso
8e1ad48aa6 IN PROGRESS - issue BATCH-340: Refactor JobRepository for greater clarity and consistency.
http://jira.springframework.org/browse/BATCH-340

removed redundant stepNames property from JobInstance (StepInstance heritage)
2008-02-25 12:37:24 +00:00
lucasward
70481c2c98 First attempt at adding more explicit skip handling and removing the need for 'SimpleStepExecutor'. There's still some cleanup that needs to happen, but it's moving in the right direction. 2008-02-21 04:33:25 +00:00
robokaso
96c48bcbc5 IN PROGRESS - issue BATCH-366: Do we still need StepInstance?
http://jira.springframework.org/browse/BATCH-366

Killed StepInstance - test coverage temporarily low due to commenting obsolete tests (but sample jobs work fine).
2008-02-19 15:41:26 +00:00
lucasward
dac4af1479 BATCH-220: Updated sample jobs to use 'chunkedStep' 2008-02-19 05:55:28 +00:00
dsyer
a50a0c0873 OPEN - issue BATCH-364: StepScope responsibilities can be assumed by Step (not ApplicationContext)
http://jira.springframework.org/browse/BATCH-364

restart sample was failing because of wrong manipulation of version in step execution
2008-02-18 08:17:15 +00:00
lucasward
469203f1b6 BATCH-220: Moved transactional boundary within ChunkedStep to include both 'Chunking' and 'Dechunking' 2008-02-15 23:30:30 +00:00
dsyer
7096c8c024 OPEN - issue BATCH-364: StepScope responsibilities can be assumed by Step (not ApplicationContext)
http://jira.springframework.org/browse/BATCH-364

Extend columns in attrs table -to avoid crashes resulting in optimistic lock failure.
2008-02-15 14:40:33 +00:00
dsyer
ec5379ebac OPEN - issue BATCH-364: StepScope responsibilities can be assumed by Step (not ApplicationContext)
http://jira.springframework.org/browse/BATCH-364

Make StreamManager responsible for calling open() and close().
2008-02-15 13:44:36 +00:00
robokaso
4a40b17002 RESOLVED - issue BATCH-362: Rename ExecutionAttributes to ExecutionContext
http://jira.springframework.org/browse/BATCH-362
2008-02-15 12:12:16 +00:00
dsyer
711d0c6e92 OPEN - issue BATCH-364: StepScope responsibilities can be assumed by Step (not ApplicationContext)
http://jira.springframework.org/browse/BATCH-364

Instead of lazy open, throw exception is stream is used before open().
2008-02-15 09:19:25 +00:00
lucasward
d7d17bf8d8 BATCH-220:Moved SimpleJob (formerly simpleTaskletJob) to use the ChunkedStep 2008-02-14 22:19:45 +00:00
robokaso
345b9c47db IN PROGRESS - issue BATCH-340: Refactor JobRepository for greater clarity and consistency.
http://jira.springframework.org/browse/BATCH-340

organize imports
2008-02-14 13:24:43 +00:00
robokaso
62ccc5d07a IN PROGRESS - issue BATCH-340: Refactor JobRepository for greater clarity and consistency.
http://jira.springframework.org/browse/BATCH-340

Removed no-op update(StepInstance) and update(JobInstance) repository methods
2008-02-14 13:19:51 +00:00
lucasward
d54166e607 BATCH-220:Further refinements to chunk processing. The chunker/dechunker interfaces now accept a StepExecution, so that they don't have to be instantiated anew for each chunk. They can also be wired into the ChunkedStep as well. 2008-02-14 05:45:13 +00:00
lucasward
9a830aae19 BATCH-220: More refinements to chunking, both the chunker and dechunker now return a 'result'. The chunker returns a ChunkingResult, and the Dechunker returns a DechunkingResult, allowing for the step to handle exceptions in a uniform way. 2008-02-13 21:05:42 +00:00
lucasward
1871df0539 BATCH-220:Added the 'Dechunker', as the opposite of Chunker. It assumes that some higher level class will be managing transactions. Also renamed ReadFailurePolicy to ItemSkipPolicy (Same name used by Ben in the Sandbox) once I realized that a 'ReadFailurePolicy' and 'WriteFailurePolicy' would have pretty much the same interface. 2008-02-12 06:07:40 +00:00
dsyer
2b87124b85 RESOLVED - issue BATCH-241: Support for JobLauncher.stop() on job that hasn't started yet (delayed execution)
http://jira.springframework.org/browse/BATCH-241

Since SimpleJobLauncher no longer has a stop method, we have to do the check on execution, lower down the stack.  Added explicit check for STOPPED status in SimpleJob and JoBExecution.
2008-02-11 19:54:21 +00:00
lucasward
7a2cdadf8c BATCH-220: Committed the read part of chunking, without adding it to the StepExecutor. It should be noted that I used 'Chunker' instead of 'ChunkReader', since there's already precedence in the java world, and it isn't reading chunk so much as making a chunk out of items. I have also added skipCount to StepExecution, since it's reasonable that this type of data A) should be persisted and B) the domain object is the most logical place for this type of state. 2008-02-11 03:17:58 +00:00
dsyer
c43c1b4466 OPEN - issue BATCH-339: ItemStream.mark() and reset() should throw a checked exception
http://jira.springframework.org/browse/BATCH-339

Introduce MrakFailedException and ResetFailedException (unchecked for now).  ResetFailedException has to be dealt with specially in the StepExecutor.
2008-02-08 13:46:11 +00:00
nebhale
55f5e36293 [BATCH-85] Polishing 2008-02-08 08:38:30 +00:00
lucasward
a0c4af8351 BATCH-337:No *Instance domain objects (or their respective tables) contain a 'status'. Instead, they contain the 'last execution', which can be used to determinte the status. RestartData is also no longer necessary, as everything can be 'restored' by calling stepInstance.getLastExecution().getExecutionAttributes(). Also changed all 'ID' columns to be complete, such as 'JOB_INSTANCE_ID' rather than just 'ID'. 2008-02-06 03:44:19 +00:00
dsyer
8c1cb2808f Purge StreamContext some more 2008-02-05 09:34:13 +00:00
dsyer
1479d4c53d Purge StreamContext 2008-02-05 08:51:54 +00:00
lucasward
96a11b3bb7 BATCH-219 and BATCH-330: Created ExecutionAttributes, which are stored in the table BATCH_STEP_EXECUTION_ATTRIBUTES. 2008-02-05 02:32:58 +00:00
dsyer
2d1ccb0cc6 IN PROGRESS - issue BATCH-7: Remove transaction synchronization and state management from input/output sources (formerly buffering)
http://jira.springframework.org/browse/BATCH-7

Remove GenericStreamContext
2008-02-02 15:16:20 +00:00
dsyer
4267462395 IN PROGRESS - issue BATCH-7: Remove transaction synchronization and state management from input/output sources (formerly buffering)
http://jira.springframework.org/browse/BATCH-7

Remove some references to Statistics
2008-01-31 14:11:52 +00:00
dsyer
15cffeb925 IN PROGRESS - issue BATCH-7: Remove transaction synchronization and state management from input/output sources (formerly buffering)
http://jira.springframework.org/browse/BATCH-7

Lazy-initialisation solution to the "who's in step scope" issue
2008-01-31 09:54:38 +00:00
dsyer
11708012b5 BATCH-7: Remove transaction synchronization and state management from input/output sources (formerly buffering)
http://jira.springframework.org/browse/BATCH-7

Moved ItemStream to item package
2008-01-30 18:01:07 +00:00
dsyer
a2117e4f22 BATCH-7: Remove transaction synchronization and state management from input/output sources (formerly buffering)
http://jira.springframework.org/browse/BATCH-7

Rename Restartable to ItemStream
2008-01-30 17:56:56 +00:00
dsyer
02f1ae5c0c OPEN - issue BATCH-324: Step as factory for StepExecutor
http://jira.springframework.org/browse/BATCH-324

run/process -> execute
2008-01-30 15:17:42 +00:00
dsyer
6ffefbc184 Introduce KeyedItemReader to push the getKey() method into a separate place. 2008-01-30 08:55:53 +00:00
dsyer
152829ba5f Send test coverage in core up to the high 90s. 2008-01-30 08:02:29 +00:00
dsyer
1cf29b8241 Missing commit (subclipse?) 2008-01-29 18:13:12 +00:00
dsyer
911e368a71 OPEN - issue BATCH-324: Step as factory for StepExecutor
http://jira.springframework.org/browse/BATCH-324

Same treatment for JobExecutor - roll it up into the Job interface
2008-01-29 18:07:57 +00:00
dsyer
f9619e345e OPEN - issue BATCH-324: Step as factory for StepExecutor
http://jira.springframework.org/browse/BATCH-324

Substantial re-org of core domain packages to align concerns
2008-01-29 16:36:16 +00:00
dsyer
d4d09d2ad8 OPEN - issue BATCH-324: Step as factory for StepExecutor
http://jira.springframework.org/browse/BATCH-324

Consolidate changes and remove unnecessary methods from interfaces
2008-01-29 15:48:16 +00:00
dsyer
ea818d8401 OPEN - issue BATCH-324: Step as factory for StepExecutor
http://jira.springframework.org/browse/BATCH-324

Remove StepExecutorFactory strategy.
2008-01-29 15:21:24 +00:00
dsyer
4da4c073d5 OPEN - issue BATCH-324: Step as factory for StepExecutor
http://jira.springframework.org/browse/BATCH-324

First pass - added factory method, resolved conflicts and cycles, got tests working.
2008-01-29 15:07:53 +00:00
dsyer
8c1210f5da Resolved some TODOs. 2008-01-28 16:47:08 +00:00
dsyer
5ad74053cd Resolved some TODOs. 2008-01-28 09:46:21 +00:00
lucasward
d8f2ccb354 BATCH-304: Modified the CommandLineJobRunner to accept a job name as an argument. Also modified the contract of JobParamterFactory to return an empty JobParameters or Properties if null is passed in, rather than throwing an IllegalArgumentException. 2008-01-24 16:19:02 +00:00
lucasward
5bc993e350 BATCH-304: Created new job launcher that does not use BeanFactoryLocator. 2008-01-24 13:40:55 +00:00
dsyer
97d5359f3c OPEN - issue BATCH-304: BatchCommandLineLauncher simplified and rename
http://jira.springframework.org/browse/BATCH-304

Date format hell - how is new Date(0) "19691231"?
2008-01-24 10:07:38 +00:00
dsyer
e749bb93a0 OPEN - issue BATCH-304: BatchCommandLineLauncher simplified and rename
http://jira.springframework.org/browse/BATCH-304

Add unit test for factory.
2008-01-24 09:54:24 +00:00
dsyer
ae37f59148 OPEN - issue BATCH-304: BatchCommandLineLauncher simplified and rename
http://jira.springframework.org/browse/BATCH-304
2008-01-24 09:00:39 +00:00
dsyer
9185795686 OPEN - issue BATCH-304: BatchCommandLineLauncher simplified and rename
http://jira.springframework.org/browse/BATCH-304

Remove Javadocs references to non-existent classes
2008-01-24 08:56:22 +00:00
dsyer
09fc32c4b9 OPEN - issue BATCH-304: BatchCommandLineLauncher simplified and rename
http://jira.springframework.org/browse/BATCH-304

Nuke JobIdentifier
2008-01-24 08:47:16 +00:00