Commit Graph

148 Commits

Author SHA1 Message Date
robokaso
840d30426a IN PROGRESS - issue BATCH-412: consistent ItemStream key prefixes
http://jira.springframework.org/browse/BATCH-412

all keys made private (not referenced outside tests)
2008-03-05 12:22:31 +00:00
robokaso
2aa867c535 IN PROGRESS - issue BATCH-412: consistent ItemStream key prefixes
http://jira.springframework.org/browse/BATCH-412

added ExecutionContextUserSupport class as superclass for those who need to save data into ExecutionContext - removes the tons of copy-pastes used to handle naming and unique key generation
2008-03-05 10:28:48 +00:00
lucasward
a7fe4db96e BATCH-413: Added a more specific exception type for when an item reader doesn't find any work. 2008-03-04 19:32:49 +00:00
lucasward
77b6a7c34c BATCH-413: DrivingQueryItemReader now throws an exception if no keys are returned from the KeyGenerator. 2008-03-04 19:14:38 +00:00
dsyer
f22e8d04b7 Javadocs for HibernateAwareItemWriter tidied up. 2008-03-04 14:50:15 +00:00
dsyer
f73ce3553c RESOLVED - issue BATCH-404: FactoryBeans for step configuration
http://jira.springframework.org/browse/BATCH-404

Tidied up listener registration and integration a bit
2008-03-04 13:16:18 +00:00
robokaso
c42a6ea147 RESOLVED - issue BATCH-393: DefaultFieldSet should not always trim whitespace from the value returned
http://jira.springframework.org/browse/BATCH-393

added readRawString(int) and readRawString(String) methods to FieldSet interface
2008-03-04 10:17:07 +00:00
lucasward
93760bd298 BATCH-407:Added repository factory to samples and created a factory for incrementers for that logic to obtain them could be unit tested. Also renamed SimpelJobRepositoryFactoryBean to just JobRepositoryFactoryBean 2008-03-03 20:23:14 +00:00
dsyer
cb3c567966 RESOLVED - issue BATCH-231: Chunk completion policy
http://jira.springframework.org/browse/BATCH-231

Added RepeatOperationsStepFactoryBean.
2008-03-03 09:16:06 +00:00
lucasward
fe9c210fa4 BATCH-378: Added code to ensure that afterStep is called at the correct time.
Also removed ExitStatusExceptionClassifier in favor of using the ExitStatus of the last executed StepExecution within SimpleJob
2008-03-03 05:00:27 +00:00
dsyer
bbeeee32d3 OPEN - issue BATCH-404: FactoryBeans for step configuration
http://jira.springframework.org/browse/BATCH-404

Let the factory bean take care of chunk and item listener callbacks.  ItemOrientedStep is much simpler as a result.
2008-03-02 15:03:12 +00:00
dsyer
108c21b187 OPEN - issue BATCH-404: FactoryBeans for step configuration
http://jira.springframework.org/browse/BATCH-404

New flag on DefaultStepFactoryBean for item skip policy (alwaysSkip=false is the default).
2008-03-02 12:04:12 +00:00
dsyer
40f5349c0e OPEN - issue BATCH-404: FactoryBeans for step configuration
http://jira.springframework.org/browse/BATCH-404

Introduce (as temporary measure) KitchenSinkStepFactoryBean.
2008-03-02 09:38:01 +00:00
dsyer
b89a68dfeb Incomplete - task 87: Refactor KeyedItemReader
Split off from ItemReader interface.
2008-03-01 15:24:06 +00:00
dsyer
b47a6e6405 Tidy up some exception class names 2008-03-01 11:59:33 +00:00
dsyer
90cb1e8ea3 Rename some packages with more logical names 2008-03-01 10:24:28 +00:00
dsyer
e5f4413101 OPEN - issue BATCH-378: RepeatListener is confusing and too generic to use for 'intercepting' a step
http://jira.springframework.org/browse/BATCH-378

Fix hibernate aware item writer - no need for listener interface now that ItemWRiter has flush/clear
2008-02-29 16:15:52 +00:00
dsyer
fca1e65bdd Upgrade to Spring 2.5.2 2008-02-29 14:05:43 +00:00
dsyer
256574358b OPEN - issue BATCH-385: Merge user attributes in StepContext with ExecutionContext
http://jira.springframework.org/browse/BATCH-385

Last delegating ItemStream tidied up.
2008-02-29 13:27:34 +00:00
dsyer
a1daad39f8 OPEN - issue BATCH-385: Merge user attributes in StepContext with ExecutionContext
http://jira.springframework.org/browse/BATCH-385

removed delegate calls to ItemStream in favour of direct registration
2008-02-29 13:04:18 +00:00
dsyer
9167c7de4c OPEN - issue BATCH-378: RepeatListener is confusing and too generic to use for 'intercepting' a step
http://jira.springframework.org/browse/BATCH-378

Add listener multicaster to ItemOrientedStep
2008-02-28 19:25:15 +00:00
dsyer
add7b2f806 OPEN - issue BATCH-378: RepeatListener is confusing and too generic to use for 'intercepting' a step
http://jira.springframework.org/browse/BATCH-378

Change contract of StepListener - JobParameters are more useful at that stage than ExecutionContext.
2008-02-28 15:44:51 +00:00
dsyer
e9d74d0088 OPEN - issue BATCH-378: RepeatListener is confusing and too generic to use for 'intercepting' a step
http://jira.springframework.org/browse/BATCH-378

Replace RepeatListener with StepListener in TaskletStep.
2008-02-28 14:23:24 +00:00
dsyer
2a25a7a636 OPEN - issue BATCH-378: RepeatListener is confusing and too generic to use for 'intercepting' a step
http://jira.springframework.org/browse/BATCH-378

Remove unnecessary listener implementations and migrate some functionality to samples.  In the process discovered that tasklet steps cannot be stopped.
2008-02-28 11:41:49 +00:00
dsyer
707e94b3c8 OPEN - issue BATCH-378: RepeatListener is confusing and too generic to use for 'intercepting' a step
http://jira.springframework.org/browse/BATCH-378

Slim down StremManager
2008-02-28 10:05:08 +00:00
dsyer
425c270da3 OPEN - issue BATCH-385: Merge user attributes in StepContext with ExecutionContext
http://jira.springframework.org/browse/BATCH-385

Make Job responsible for setting up step context.  Javadocs on StepContext to indicate that the attributes are volatile.  Add JobParametersAware (might be temporary).
2008-02-28 09:14:06 +00:00
dsyer
a35a9d79dc OPEN - issue BATCH-368: StepExecution attributes can overflow and cause spurious OptimisticLockingException
http://jira.springframework.org/browse/BATCH-368

Split the save of a StepExecution into two parts at the JobRepository level, that way we can see if the failure was in saving context or just the step execution.
Lots of exception handling and tests in step implementations.
2008-02-27 16:44:52 +00:00
robokaso
aa76ec4e26 removed the empty AbstractTransactionalIoSource 2008-02-27 13:56:26 +00:00
dsyer
e3c86285cf Tidy up streams on close in stream manager 2008-02-27 08:05:52 +00:00
lucasward
e952a55ab2 BATCH-365: ItemStream#Update and ItemStream#close now accept an ExecutionContext as an argument. I removed the local ExecutionContexts in the readers and readers, and had them use the passed in ones instead. 2008-02-26 21:22:10 +00:00
lucasward
a7b05a1778 BATCH-339: ItemWriter#flush() now throws a FlushFailedException (unchecked) and ItemWriter#clear() now throws a ClearFailedException (also unchecked) 2008-02-26 20:10:24 +00:00
dsyer
55e35eac1c Incomplete - task 84: Fix samples
Fix rollback tests as well - exception handler too complicated
2008-02-26 15:16:02 +00:00
dsyer
2b32b8d38e Incomplete - task 84: Fix samples
Fix restart sample - StepExecutionDao was not restoring execution context
2008-02-26 13:19:14 +00:00
dsyer
e2c5d1fb97 Remove unnecessary public getter from DelegatingItemReader 2008-02-26 12:21:28 +00:00
dsyer
66c4e7091b Incomplete - task 84: Fix samples
Hibernate failure fixed on flush.
2008-02-26 12:02:33 +00:00
dsyer
7f0be2826e Incomplete - task 84: Fix samples
Fix column mapping in jdbc cursor - order is important.
2008-02-26 10:41:30 +00:00
dsyer
acbcc9dc0b Incomplete - task 84: Fix samples
Better message from assertion.
2008-02-26 09:43:36 +00:00
lucasward
64506040ff BATCH-365: There should now be one ExecutionContext per step. All itemStreams will be opened with an execution context, and will be notified before it is saved, to ensure they have all state in the context. Most ItemReader/Writers should now have the logic for whether or not to put their state in the context, but a few have likely been missed. 2008-02-26 08:29:37 +00:00
dsyer
3b48ece7e5 Moved chunks to a branch (called chunks) 2008-02-26 08:06:11 +00:00
dsyer
59f884b832 RESOLVED - issue BATCH-371: FlatFileItemWriter no longer uses LineAggregator
http://jira.springframework.org/browse/BATCH-371
OPEN - issue BATCH-349: ItemStreamAdapter isn't an Adapter 
http://jira.springframework.org/browse/BATCH-349

Use *CReator instead of *Unmapper

Adapter -> Support
2008-02-25 17:08:31 +00:00
dsyer
ad6511fb94 OPEN - issue BATCH-349: ItemStreamAdapter isn't an Adapter
http://jira.springframework.org/browse/BATCH-349

Adapter -> Support (unless it was an Adapter)
2008-02-25 16:10:53 +00:00
dsyer
4f4b63b6c1 OPEN - issue BATCH-371: FlatFileItemWriter no longer uses LineAggregator
http://jira.springframework.org/browse/BATCH-371

Introduce FieldSetUnmapper for symmetry with input
2008-02-25 14:42:16 +00:00
lucasward
747a706e86 BATCH-365: Moved reset and mark to ItemReader interface. 2008-02-24 21:14:38 +00:00
lucasward
111a7c9629 BATCH-365: Added flush() and clear() to ItemWriter interface. These should be removed from ItemStream after the same is done for the ItemReader interface. 2008-02-24 01:55:48 +00:00
robokaso
455bfe2fab RESOLVED - issue BATCH-376: Problem with DelimitedLineTokenizer and empty quoted value
http://jira.springframework.org/browse/BATCH-376
2008-02-22 10:57:41 +00:00
dsyer
ee0236d657 OPEN - issue BATCH-371: FlatFileItemWriter no longer uses LineAggregator
http://jira.springframework.org/browse/BATCH-371

Extend ItemTransformer implementations that deal with field sets and arrays
2008-02-21 09:15:51 +00:00
dsyer
f6bd90fc3e OPEN - issue BATCH-371: FlatFileItemWriter no longer uses LineAggregator
http://jira.springframework.org/browse/BATCH-371

Changed the interface of LineAggregator for symmetry with LineTokenizer.
2008-02-20 08:55:35 +00:00
dsyer
91a9e94590 OPEN - issue BATCH-371: FlatFileItemWriter no longer uses LineAggregator
http://jira.springframework.org/browse/BATCH-371

Moved existing default transformer out to a top level class, and introduce lineAggregatorItemTransformer as an option.  I still don't see a good way to get a String[] in to it reliably.
2008-02-19 21:40:44 +00:00
robokaso
97317b3bbe RESOLVED - issue BATCH-367: When the samples run, all the execution attributes are of type STRING - this must be wrong.
http://jira.springframework.org/browse/BATCH-367

fixed StreamManager not to alter ExecutionContext values + added testcase
2008-02-18 10:39:33 +00:00
dsyer
ec5379ebac OPEN - issue BATCH-364: StepScope responsibilities can be assumed by Step (not ApplicationContext)
http://jira.springframework.org/browse/BATCH-364

Make StreamManager responsible for calling open() and close().
2008-02-15 13:44:36 +00:00