Commit Graph

172 Commits

Author SHA1 Message Date
nebhale
8b8288d8d8 [BATCH-496] Added more descriptive error messages 2008-03-25 11:04:23 +00:00
robokaso
786fcd9bb9 IN PROGRESS - issue BATCH-491: checked exception handling
http://jira.springframework.org/browse/BATCH-491

exception handler signature changed to 'throws Throwable' so that it can simply rethrow without wrapping.
2008-03-25 10:01:47 +00:00
dsyer
37d35f42eb RESOLVED - issue BATCH-467: Remove ExitStatusExceptionClassifier / Rewrite SimpleExitStatusExceptionClassifier as a JobListener
Removed the interface and implementation, checked that defautl behaviour is same using unit test ItemOrientedStepTests
2008-03-25 09:08:14 +00:00
lucasward
bb42725f3f BATCH-377: A PreparedStatement can now be set on JdbcCursorItemReader. Also created a JobParametersPreparedStatementSetter, that when registered as a StepListener will set the values on a prepared statement with values from a PreparedStatement. 2008-03-21 04:11:45 +00:00
robokaso
6959c40158 IN PROGRESS - issue BATCH-495: readers must not clear buffers on mark()
http://jira.springframework.org/browse/BATCH-495

moved the initial itemHandler.mark() out of the loop
2008-03-20 16:21:18 +00:00
robokaso
4cc2e03fbd RESOLVED - issue BATCH-485: SkippableExceptionClasses should be inverted
http://jira.springframework.org/browse/BATCH-485

SkipLimitStepFactoryBean now declares setter for fatal exceptions that are never skipped and immediately rethrown by exception handlerRESOLVED - issue BATCH-485: SkippableExceptionClasses should be inverted 
http://jira.springframework.org/browse/BATCH-485

SkipLimitStepFactoryBean now declares setter for fatal exceptions that are never skipped and immediately rethrown by exception handler.
LimitCheckingItemSkipPolicy and SimpleLimitExceptionHandler were modified to recognize fatal exceptions.
2008-03-20 10:04:27 +00:00
dsyer
fc1e7debd9 RESOLVED - issue BATCH-492: CommandLineJobRunner should close the spring context 2008-03-19 14:55:58 +00:00
robokaso
d4710ab1be OPEN - issue BATCH-490: SkipLimitStepFactoryBean ignores the skippableExceptionClasses property
http://jira.springframework.org/browse/BATCH-490

fixed the obvious bug, but found deeper issue (see TODO in tests)
2008-03-19 13:58:52 +00:00
dsyer
f8a74f39ac RESOLVED - issue BATCH-489: undocumented JobExecutionException 2008-03-19 13:44:05 +00:00
robokaso
30d6e80af7 REOPENED - issue BATCH-472: Exceeding the start limit on a step will cause a vague exception type to be thrown.
http://jira.springframework.org/browse/BATCH-472

added throws StartLimitExceedException to SimpleJob#execute(..) javadoc
2008-03-19 12:31:08 +00:00
robokaso
1851025c54 REOPENED - issue BATCH-472: Exceeding the start limit on a step will cause a vague exception type to be thrown.
http://jira.springframework.org/browse/BATCH-472

StartLimitExceededException made public and moved to core package. The constructor changed to simply accept string.
2008-03-19 09:31:10 +00:00
robokaso
9f9d909b5a RESOLVED - issue BATCH-472: Exceeding the start limit on a step will cause a vague exception type to be thrown.
http://jira.springframework.org/browse/BATCH-472

added package-private StartLimitExceededException (subclass of UnexpectedJobExecutionException), that takes Step as constructor argument and creates appropriate message
2008-03-18 09:55:07 +00:00
robokaso
8768f15581 RESOLVED - issue BATCH-479: JobRepositoryFactoryBean should allow specification of JDBC table prefixes
http://jira.springframework.org/browse/BATCH-479

applied patch (with minor tweaks)
2008-03-18 09:19:31 +00:00
dsyer
4b152bbc7e Exception message tidied up. 2008-03-17 11:11:42 +00:00
robokaso
f202dd4b44 RESOLVED - issue BATCH-461: skip counting
http://jira.springframework.org/browse/BATCH-461

ItemOrientedStep now increments StepExecution's skipCount from StepContribution on rollback.
Simple assert checking the correct value of StepExecution#skipCount added to SkipLimitStepFactoryBeanTests.

Btw. renamed StepContribution#taskCount to itemCount
2008-03-17 10:20:48 +00:00
dsyer
271d6815c7 RESOLVED - issue BATCH-465: The term "exit code" is overloaded
RESOLVED - issue BATCH-468: ExitStatusExceptionClassifier, ExitCodeMapper and simple versions thereof (and others?) incorrectly moved into step.item package
2008-03-15 08:56:50 +00:00
dsyer
ff85f455de RESOLVED - issue BATCH-456: JobListener.afterJob() should be called regardless of success or failure
Added onInterrupt callback.
2008-03-14 17:43:41 +00:00
dsyer
ec2c66885d RESOLVED - issue BATCH-464: Throw exception if restart is attempted on job instance that was already completed successfully 2008-03-14 17:09:26 +00:00
robokaso
db2344d2fa IN PROGRESS - issue BATCH-461: skip counting
http://jira.springframework.org/browse/BATCH-461

StepContribution#getSkipCount renamed to StepContribution#getStepSkipCount and added StepContribution#getContributionSkipCount (used by StepExecution to increment its skipCount).
2008-03-14 15:35:11 +00:00
robokaso
0a1c4f49db RESOLVED - issue BATCH-459: unused StepExecution methods
http://jira.springframework.org/browse/BATCH-459

removed unused methods
2008-03-14 15:22:26 +00:00
robokaso
099fd46c08 StepExecution#incrementTaskCount -> incrementItemCount 2008-03-14 13:30:03 +00:00
nebhale
1f4ac46f88 [BATCH 429] Moved core.repository.support.dao to core.repository.dao 2008-03-14 11:47:14 +00:00
dsyer
c645eef79d Review process: Move tasklet step package to subpackage and resolve cycle. 2008-03-14 11:46:57 +00:00
dsyer
07877a9538 Review process: Merge synch packages into support in retry / repeat. 2008-03-14 11:06:32 +00:00
dsyer
ed1680bf14 Review process. Split support package (part 1). 2008-03-14 10:55:10 +00:00
dsyer
de2715614b Review process. Split step package into item and tasklet. 2008-03-14 10:50:53 +00:00
dsyer
39755ea3a6 Review process. Consolidate tasklet packages. 2008-03-14 10:36:53 +00:00
dsyer
044bc4e192 Review process. Consolidated some related support packages in infrastructure. 2008-03-14 10:30:18 +00:00
robokaso
fe79a4dbe0 RESOLVED - issue BATCH-454: broken step's isAllowedStartIfComplete property
http://jira.springframework.org/browse/BATCH-454

job does not pass the restored context to step if the exit status of last execution is FINISHED
2008-03-14 10:18:23 +00:00
robokaso
8c281d1021 IN PROGRESS - issue BATCH-456: JobListener.afterJob() should be called regardless of success or failure
http://jira.springframework.org/browse/BATCH-456

added JobListener#onError(JobExecution, Throwable) called when job failed (not when interrupted)
2008-03-14 09:26:18 +00:00
dsyer
4fd2968e5e RESOLVED - issue BATCH-457: Error handling broken in SimpleJob
Look out for Error types explicitly and re-throw them without wrapping
2008-03-14 08:53:27 +00:00
dsyer
68562a3b29 RESOLVED - issue BATCH-455: Pass object to ItemWriteListener.afterWrite() 2008-03-13 22:18:10 +00:00
robokaso
d7e08ae574 RESOLVED - issue BATCH-451: rename DefaultStepFactoryBean to SimpleStepFactoryBean
http://jira.springframework.org/browse/BATCH-451
2008-03-13 12:31:07 +00:00
nebhale
66b61a78d8 [BATCH-447] Extracted out hard dependency on Backport Concurrent 2008-03-13 11:22:44 +00:00
robokaso
591e507421 RESOLVED - issue BATCH-449: skip synchronization between reader and writer
http://jira.springframework.org/browse/BATCH-449

SimpleItemHandler redesigned for inheritance and fixed ItemSkipPolicyItemHandler to call skip on the reader only if exception is thrown in reader
2008-03-13 10:19:26 +00:00
lucasward
070fb68cad More work on chapter 2, I completely updated the reference model and made some javadoc updates in the repository. 2008-03-13 04:28:59 +00:00
robokaso
288fd40825 IN PROGRESS - issue BATCH-422: Provide ability to specify exception types as well as skip limit in DefaultStepFactoryBean
http://jira.springframework.org/browse/BATCH-422

DefaultFactoryBean now uses SimpleItemHandler (instead of unconfigured ItemSkipPolicyItemHandler)
2008-03-12 15:07:42 +00:00
robokaso
8fff682219 IN PROGRESS - issue BATCH-422: Provide ability to specify exception types as well as skip limit in DefaultStepFactoryBean
http://jira.springframework.org/browse/BATCH-422

The desired functionality should now be there, but needs better tests
2008-03-12 13:43:39 +00:00
robokaso
637f2a61f6 IN PROGRESS - issue BATCH-422: Provide ability to specify exception types as well as skip limit in DefaultStepFactoryBean
http://jira.springframework.org/browse/BATCH-422

ItemSkipPolicyItemHandler now always rethrows exception - fixed rollbackJob that wasn't really skipping the error item although it was configured to do so.
2008-03-12 12:36:39 +00:00
robokaso
56174c7d32 IN PROGRESS - issue BATCH-422: Provide ability to specify exception types as well as skip limit in DefaultStepFactoryBean
http://jira.springframework.org/browse/BATCH-422

skip configuration moved to separate step factory subclass
2008-03-12 10:30:24 +00:00
robokaso
19aea73481 IN PROGRESS - issue BATCH-422: Provide ability to specify exception types as well as skip limit in DefaultStepFactoryBean
http://jira.springframework.org/browse/BATCH-422

SimpleLimitExceptionHandler property generalized to ExceptionHandler
2008-03-12 09:54:14 +00:00
nebhale
51ba864186 [BATCH-447] Introduced a StepExecutionSynchronizerFactory that returned the proper implementation based on Java5/Backport Concurrent. 2008-03-12 09:51:01 +00:00
robokaso
bde4cea8a7 RESOLVED - issue BATCH-446: taskCount in StepExecution should be itemCount
http://jira.springframework.org/browse/BATCH-446
2008-03-12 09:27:55 +00:00
dsyer
19348abbb3 RESOLVED - issue BATCH-443: ItemOrientedStep might not either commit or rollback transaction
Needed to flush before attempting to update step execution, then catch and attempt rollback on CommitFailedException.
2008-03-11 17:22:25 +00:00
nebhale
9f7cc87c0d [BATCH-383] Fixes to make Spring Batch 1.4 runtime compliant. 2008-03-11 13:49:17 +00:00
robokaso
f53d10d879 RESOLVED - BATCH-410 ChunkListeners called on chunkOperations open() and close() 2008-03-10 15:35:07 +00:00
robokaso
130f72a1d8 BATCH-410: fixed chunk listener registration and documented current unintuitive behavior in test 2008-03-10 11:57:47 +00:00
robokaso
21325042ef RESOLVED - BATCH-435 Tasklet step now propagates JobInterruptedException up to job 2008-03-10 09:38:43 +00:00
dsyer
6f820c5556 OPEN - issue BATCH-429: Combine the core and execution modules
Add missing package.html
2008-03-09 12:55:38 +00:00
dsyer
6d4dad0788 OPEN - issue BATCH-429: Combine the core and execution modules
Consolidate some random packages and classes with odd names.
2008-03-09 12:52:54 +00:00