Commit Graph

133 Commits

Author SHA1 Message Date
robokaso
973e146aa3 RESOLVED - issue BATCH-533: prefix in the JobRepositoryFactoryBean does not apply to the sequences 2008-03-31 12:52:44 +00:00
lucasward
c736462553 Reverted back to original prepared statement setter. The ExecutionContext wasn't doing much good in it, since other database reader changes weren't committed. However, being able to set the JobParameters still provides value for the cursor item reader. 2008-03-28 05:32:08 +00:00
dsyer
d983eba1c5 RESOLVED - issue BATCH-511: read failures cause rollback
Renamed "commit*" in StepContribution to "combine*".  Fixed broken test (forgot to combine skip counts).
2008-03-27 10:48:04 +00:00
dsyer
e46c972d8e REOPENED - issue BATCH-511: read failures cause rollback 2008-03-27 10:30:06 +00:00
dsyer
914b9f2bed REOPENED - issue BATCH-511: read failures cause rollback
Add SkipLimitExceededException to the list of fatal exceptions for the step exception handler
2008-03-27 06:41:37 +00:00
lucasward
b876649cb9 BATCH-514:Additional small refactorings on Jdbc readers. 2008-03-27 04:37:58 +00:00
robokaso
ca2db2c31a RESOLVED - issue BATCH-516: default to commitInterval=1 in SimpleStepFactoryBean
http://jira.springframework.org/browse/BATCH-516
2008-03-26 13:58:04 +00:00
robokaso
6989745c12 RESOLVED - issue BATCH-510: FlatFileItemWriter.restarted logic fails if step fails before first chunk commit.
http://jira.springframework.org/browse/BATCH-510

added initial save of execution context before first chunk
2008-03-26 09:45:07 +00:00
dsyer
f690e39440 RESOLVED - issue BATCH-513: CompositeItemReadListener, CompositeItemWriteListener using ChunkListeners?
Changed signature of methods
2008-03-26 06:41:44 +00:00
dsyer
08ceb9d962 RESOLVED - issue BATCH-498: Skip method should get ExecutionContext as an argument 2008-03-26 06:37:01 +00:00
dsyer
546010c887 OPEN - issue BATCH-498: Skip method should get ExecutionContext as an argument
Added SkipListener as new StepListener.
2008-03-25 19:15:00 +00:00
dsyer
7a513d4749 OPEN - issue BATCH-498: Skip method should get ExecutionContext as an argument
Handle skip internally in ItemHandler.
2008-03-25 17:10:26 +00:00
dsyer
1ac5a5296a RESOLVED - issue BATCH-506: JobListener is not a BatchListener
Changed BatchListener to StepListener and renamed existing Job/StepListener as *ExecutionListener.
2008-03-25 12:29:55 +00:00
nebhale
e826353866 [BATCH-478] Missed a couple of commits 2008-03-25 11:38:38 +00:00
robokaso
49b6ebe51e RESOLVED - issue BATCH-491: checked exception handling
http://jira.springframework.org/browse/BATCH-491

exception wrapping and unwrapping moved into RepeatTemplate.
2008-03-25 10:58:08 +00:00
robokaso
786fcd9bb9 IN PROGRESS - issue BATCH-491: checked exception handling
http://jira.springframework.org/browse/BATCH-491

exception handler signature changed to 'throws Throwable' so that it can simply rethrow without wrapping.
2008-03-25 10:01:47 +00:00
dsyer
37d35f42eb RESOLVED - issue BATCH-467: Remove ExitStatusExceptionClassifier / Rewrite SimpleExitStatusExceptionClassifier as a JobListener
Removed the interface and implementation, checked that defautl behaviour is same using unit test ItemOrientedStepTests
2008-03-25 09:08:14 +00:00
dsyer
49e081d9b2 Business schema for tests split out into separate file 2008-03-25 08:28:21 +00:00
dsyer
3d077f424f OPEN - issue BATCH-487: ExecutionContext and JobParameters
Added Javadocs to ExecutionContext.
2008-03-25 07:56:17 +00:00
lucasward
bd703fef34 BATCH-377: Build error should be fixed now. 2008-03-21 19:07:18 +00:00
lucasward
bb42725f3f BATCH-377: A PreparedStatement can now be set on JdbcCursorItemReader. Also created a JobParametersPreparedStatementSetter, that when registered as a StepListener will set the values on a prepared statement with values from a PreparedStatement. 2008-03-21 04:11:45 +00:00
robokaso
4cc2e03fbd RESOLVED - issue BATCH-485: SkippableExceptionClasses should be inverted
http://jira.springframework.org/browse/BATCH-485

SkipLimitStepFactoryBean now declares setter for fatal exceptions that are never skipped and immediately rethrown by exception handlerRESOLVED - issue BATCH-485: SkippableExceptionClasses should be inverted 
http://jira.springframework.org/browse/BATCH-485

SkipLimitStepFactoryBean now declares setter for fatal exceptions that are never skipped and immediately rethrown by exception handler.
LimitCheckingItemSkipPolicy and SimpleLimitExceptionHandler were modified to recognize fatal exceptions.
2008-03-20 10:04:27 +00:00
dsyer
fc1e7debd9 RESOLVED - issue BATCH-492: CommandLineJobRunner should close the spring context 2008-03-19 14:55:58 +00:00
robokaso
d4710ab1be OPEN - issue BATCH-490: SkipLimitStepFactoryBean ignores the skippableExceptionClasses property
http://jira.springframework.org/browse/BATCH-490

fixed the obvious bug, but found deeper issue (see TODO in tests)
2008-03-19 13:58:52 +00:00
robokaso
1851025c54 REOPENED - issue BATCH-472: Exceeding the start limit on a step will cause a vague exception type to be thrown.
http://jira.springframework.org/browse/BATCH-472

StartLimitExceededException made public and moved to core package. The constructor changed to simply accept string.
2008-03-19 09:31:10 +00:00
robokaso
9f9d909b5a RESOLVED - issue BATCH-472: Exceeding the start limit on a step will cause a vague exception type to be thrown.
http://jira.springframework.org/browse/BATCH-472

added package-private StartLimitExceededException (subclass of UnexpectedJobExecutionException), that takes Step as constructor argument and creates appropriate message
2008-03-18 09:55:07 +00:00
robokaso
f202dd4b44 RESOLVED - issue BATCH-461: skip counting
http://jira.springframework.org/browse/BATCH-461

ItemOrientedStep now increments StepExecution's skipCount from StepContribution on rollback.
Simple assert checking the correct value of StepExecution#skipCount added to SkipLimitStepFactoryBeanTests.

Btw. renamed StepContribution#taskCount to itemCount
2008-03-17 10:20:48 +00:00
dsyer
271d6815c7 RESOLVED - issue BATCH-465: The term "exit code" is overloaded
RESOLVED - issue BATCH-468: ExitStatusExceptionClassifier, ExitCodeMapper and simple versions thereof (and others?) incorrectly moved into step.item package
2008-03-15 08:56:50 +00:00
dsyer
ec2c66885d RESOLVED - issue BATCH-464: Throw exception if restart is attempted on job instance that was already completed successfully 2008-03-14 17:09:26 +00:00
robokaso
0a1c4f49db RESOLVED - issue BATCH-459: unused StepExecution methods
http://jira.springframework.org/browse/BATCH-459

removed unused methods
2008-03-14 15:22:26 +00:00
robokaso
099fd46c08 StepExecution#incrementTaskCount -> incrementItemCount 2008-03-14 13:30:03 +00:00
nebhale
1f4ac46f88 [BATCH 429] Moved core.repository.support.dao to core.repository.dao 2008-03-14 11:47:14 +00:00
dsyer
c645eef79d Review process: Move tasklet step package to subpackage and resolve cycle. 2008-03-14 11:46:57 +00:00
dsyer
2424c0ec39 Review process: Break cycle introduced when RetrySynchManager was moved into support package. 2008-03-14 11:33:18 +00:00
dsyer
07877a9538 Review process: Merge synch packages into support in retry / repeat. 2008-03-14 11:06:32 +00:00
dsyer
ed1680bf14 Review process. Split support package (part 1). 2008-03-14 10:55:10 +00:00
dsyer
de2715614b Review process. Split step package into item and tasklet. 2008-03-14 10:50:53 +00:00
dsyer
39755ea3a6 Review process. Consolidate tasklet packages. 2008-03-14 10:36:53 +00:00
dsyer
044bc4e192 Review process. Consolidated some related support packages in infrastructure. 2008-03-14 10:30:18 +00:00
robokaso
fe79a4dbe0 RESOLVED - issue BATCH-454: broken step's isAllowedStartIfComplete property
http://jira.springframework.org/browse/BATCH-454

job does not pass the restored context to step if the exit status of last execution is FINISHED
2008-03-14 10:18:23 +00:00
robokaso
8c281d1021 IN PROGRESS - issue BATCH-456: JobListener.afterJob() should be called regardless of success or failure
http://jira.springframework.org/browse/BATCH-456

added JobListener#onError(JobExecution, Throwable) called when job failed (not when interrupted)
2008-03-14 09:26:18 +00:00
dsyer
4fd2968e5e RESOLVED - issue BATCH-457: Error handling broken in SimpleJob
Look out for Error types explicitly and re-throw them without wrapping
2008-03-14 08:53:27 +00:00
dsyer
68562a3b29 RESOLVED - issue BATCH-455: Pass object to ItemWriteListener.afterWrite() 2008-03-13 22:18:10 +00:00
robokaso
d7e08ae574 RESOLVED - issue BATCH-451: rename DefaultStepFactoryBean to SimpleStepFactoryBean
http://jira.springframework.org/browse/BATCH-451
2008-03-13 12:31:07 +00:00
robokaso
591e507421 RESOLVED - issue BATCH-449: skip synchronization between reader and writer
http://jira.springframework.org/browse/BATCH-449

SimpleItemHandler redesigned for inheritance and fixed ItemSkipPolicyItemHandler to call skip on the reader only if exception is thrown in reader
2008-03-13 10:19:26 +00:00
robokaso
da639bdb9f IN PROGRESS - issue BATCH-422: Provide ability to specify exception types as well as skip limit in DefaultStepFactoryBean
http://jira.springframework.org/browse/BATCH-422

Added tests for skip and discovered bug in skip logic (see TODO in SkipLimitStepFactoryBeanTests).
Made DelegatingItemWriter skippable.
2008-03-12 16:42:59 +00:00
robokaso
bde4cea8a7 RESOLVED - issue BATCH-446: taskCount in StepExecution should be itemCount
http://jira.springframework.org/browse/BATCH-446
2008-03-12 09:27:55 +00:00
dsyer
19348abbb3 RESOLVED - issue BATCH-443: ItemOrientedStep might not either commit or rollback transaction
Needed to flush before attempting to update step execution, then catch and attempt rollback on CommitFailedException.
2008-03-11 17:22:25 +00:00
nebhale
9f7cc87c0d [BATCH-383] Fixes to make Spring Batch 1.4 runtime compliant. 2008-03-11 13:49:17 +00:00
robokaso
f53d10d879 RESOLVED - BATCH-410 ChunkListeners called on chunkOperations open() and close() 2008-03-10 15:35:07 +00:00