Commit Graph

122 Commits

Author SHA1 Message Date
dsyer
a35a9d79dc OPEN - issue BATCH-368: StepExecution attributes can overflow and cause spurious OptimisticLockingException
http://jira.springframework.org/browse/BATCH-368

Split the save of a StepExecution into two parts at the JobRepository level, that way we can see if the failure was in saving context or just the step execution.
Lots of exception handling and tests in step implementations.
2008-02-27 16:44:52 +00:00
robokaso
aa76ec4e26 removed the empty AbstractTransactionalIoSource 2008-02-27 13:56:26 +00:00
dsyer
e3c86285cf Tidy up streams on close in stream manager 2008-02-27 08:05:52 +00:00
lucasward
e952a55ab2 BATCH-365: ItemStream#Update and ItemStream#close now accept an ExecutionContext as an argument. I removed the local ExecutionContexts in the readers and readers, and had them use the passed in ones instead. 2008-02-26 21:22:10 +00:00
lucasward
a7b05a1778 BATCH-339: ItemWriter#flush() now throws a FlushFailedException (unchecked) and ItemWriter#clear() now throws a ClearFailedException (also unchecked) 2008-02-26 20:10:24 +00:00
dsyer
55e35eac1c Incomplete - task 84: Fix samples
Fix rollback tests as well - exception handler too complicated
2008-02-26 15:16:02 +00:00
dsyer
2b32b8d38e Incomplete - task 84: Fix samples
Fix restart sample - StepExecutionDao was not restoring execution context
2008-02-26 13:19:14 +00:00
dsyer
e2c5d1fb97 Remove unnecessary public getter from DelegatingItemReader 2008-02-26 12:21:28 +00:00
dsyer
66c4e7091b Incomplete - task 84: Fix samples
Hibernate failure fixed on flush.
2008-02-26 12:02:33 +00:00
dsyer
7f0be2826e Incomplete - task 84: Fix samples
Fix column mapping in jdbc cursor - order is important.
2008-02-26 10:41:30 +00:00
dsyer
acbcc9dc0b Incomplete - task 84: Fix samples
Better message from assertion.
2008-02-26 09:43:36 +00:00
lucasward
64506040ff BATCH-365: There should now be one ExecutionContext per step. All itemStreams will be opened with an execution context, and will be notified before it is saved, to ensure they have all state in the context. Most ItemReader/Writers should now have the logic for whether or not to put their state in the context, but a few have likely been missed. 2008-02-26 08:29:37 +00:00
dsyer
3b48ece7e5 Moved chunks to a branch (called chunks) 2008-02-26 08:06:11 +00:00
dsyer
59f884b832 RESOLVED - issue BATCH-371: FlatFileItemWriter no longer uses LineAggregator
http://jira.springframework.org/browse/BATCH-371
OPEN - issue BATCH-349: ItemStreamAdapter isn't an Adapter 
http://jira.springframework.org/browse/BATCH-349

Use *CReator instead of *Unmapper

Adapter -> Support
2008-02-25 17:08:31 +00:00
dsyer
ad6511fb94 OPEN - issue BATCH-349: ItemStreamAdapter isn't an Adapter
http://jira.springframework.org/browse/BATCH-349

Adapter -> Support (unless it was an Adapter)
2008-02-25 16:10:53 +00:00
dsyer
4f4b63b6c1 OPEN - issue BATCH-371: FlatFileItemWriter no longer uses LineAggregator
http://jira.springframework.org/browse/BATCH-371

Introduce FieldSetUnmapper for symmetry with input
2008-02-25 14:42:16 +00:00
lucasward
747a706e86 BATCH-365: Moved reset and mark to ItemReader interface. 2008-02-24 21:14:38 +00:00
lucasward
111a7c9629 BATCH-365: Added flush() and clear() to ItemWriter interface. These should be removed from ItemStream after the same is done for the ItemReader interface. 2008-02-24 01:55:48 +00:00
robokaso
455bfe2fab RESOLVED - issue BATCH-376: Problem with DelimitedLineTokenizer and empty quoted value
http://jira.springframework.org/browse/BATCH-376
2008-02-22 10:57:41 +00:00
dsyer
ee0236d657 OPEN - issue BATCH-371: FlatFileItemWriter no longer uses LineAggregator
http://jira.springframework.org/browse/BATCH-371

Extend ItemTransformer implementations that deal with field sets and arrays
2008-02-21 09:15:51 +00:00
dsyer
f6bd90fc3e OPEN - issue BATCH-371: FlatFileItemWriter no longer uses LineAggregator
http://jira.springframework.org/browse/BATCH-371

Changed the interface of LineAggregator for symmetry with LineTokenizer.
2008-02-20 08:55:35 +00:00
dsyer
91a9e94590 OPEN - issue BATCH-371: FlatFileItemWriter no longer uses LineAggregator
http://jira.springframework.org/browse/BATCH-371

Moved existing default transformer out to a top level class, and introduce lineAggregatorItemTransformer as an option.  I still don't see a good way to get a String[] in to it reliably.
2008-02-19 21:40:44 +00:00
robokaso
97317b3bbe RESOLVED - issue BATCH-367: When the samples run, all the execution attributes are of type STRING - this must be wrong.
http://jira.springframework.org/browse/BATCH-367

fixed StreamManager not to alter ExecutionContext values + added testcase
2008-02-18 10:39:33 +00:00
dsyer
ec5379ebac OPEN - issue BATCH-364: StepScope responsibilities can be assumed by Step (not ApplicationContext)
http://jira.springframework.org/browse/BATCH-364

Make StreamManager responsible for calling open() and close().
2008-02-15 13:44:36 +00:00
robokaso
4a40b17002 RESOLVED - issue BATCH-362: Rename ExecutionAttributes to ExecutionContext
http://jira.springframework.org/browse/BATCH-362
2008-02-15 12:12:16 +00:00
dsyer
711d0c6e92 OPEN - issue BATCH-364: StepScope responsibilities can be assumed by Step (not ApplicationContext)
http://jira.springframework.org/browse/BATCH-364

Instead of lazy open, throw exception is stream is used before open().
2008-02-15 09:19:25 +00:00
lucasward
30a4631c19 BATCH-220: More refinements to chunking, both the chunker and dechunker now return a 'result'. The chunker returns a ChunkingResult, and the Dechunker returns a DechunkingResult, allowing for the step to handle exceptions in a uniform way. 2008-02-13 21:05:57 +00:00
robokaso
8cecd74e3a RESOLVED - issue BATCH-352: SimpleFlatFileItemReader vs. DefaultFlatFileItemReader
http://jira.springframework.org/browse/BATCH-352

Updated javadocs and renamed test classes
2008-02-12 14:39:06 +00:00
robokaso
2277261059 IN PROGRESS - issue BATCH-352: SimpleFlatFileItemReader vs. DefaultFlatFileItemReader
http://jira.springframework.org/browse/BATCH-352

DefaultFlatFileItemReader renamed to FlatFileItemReader
2008-02-12 14:17:25 +00:00
robokaso
7ea45ca090 IN PROGRESS - issue BATCH-352: SimpleFlatFileItemReader vs. DefaultFlatFileItemReader
http://jira.springframework.org/browse/BATCH-352

Merged SimpleFlatFileItemReader into DefaultFlatFileItemReader
2008-02-12 14:00:59 +00:00
dsyer
2ce3013ac1 RESOLVED - issue BATCH-268: retry configuration for ItemOrientedTasklet
http://jira.springframework.org/browse/BATCH-268

The retry only works if you have an ItemStream as an ItemReader (so that you get a proper rollback).  Applied the patch and fixed it up to fit the new m5 way of looking at things.
2008-02-11 17:23:57 +00:00
lucasward
f7cface009 BATCH-220: Committed the read part of chunking, without adding it to the StepExecutor. It should be noted that I used 'Chunker' instead of 'ChunkReader', since there's already precedence in the java world, and it isn't reading chunk so much as making a chunk out of items. I have also added skipCount to StepExecution, since it's reasonable that this type of data A) should be persisted and B) the domain object is the most logical place for this type of state. 2008-02-11 03:18:09 +00:00
dsyer
ad71b2f56e OPEN - issue BATCH-347: aop / template interceptor class names ambiguous
http://jira.springframework.org/browse/BATCH-347

Rename Rpeat/RetryInterceptor as *Listener (and get rid of last error in samples).
2008-02-10 16:27:08 +00:00
dsyer
31818eed98 Remove close() method (not in interface) 2008-02-10 11:56:05 +00:00
dsyer
0bc8aa4493 Incomplete - task 79: Failed build with queue in repeat template
Change internals of TaskExecutorRepeatTemplate to distinguish between error condition and success in a more type-safe way.
2008-02-10 11:44:39 +00:00
dsyer
012e2634f8 Incomplete - task 79: Failed build with queue in repeat template
Prevent race that fails CI build sometimes by making put() atomic.
2008-02-09 15:09:05 +00:00
dsyer
c1d82aae5b OPEN - issue BATCH-339: ItemStream.mark() and reset() should throw a checked exception
http://jira.springframework.org/browse/BATCH-339

Make sure existing ItemStreams throw ResetFailedException where necessary.
2008-02-08 15:21:52 +00:00
dsyer
1efb6fedc9 OPEN - issue BATCH-339: ItemStream.mark() and reset() should throw a checked exception
http://jira.springframework.org/browse/BATCH-339

Missing classes
2008-02-08 13:59:25 +00:00
dsyer
c43c1b4466 OPEN - issue BATCH-339: ItemStream.mark() and reset() should throw a checked exception
http://jira.springframework.org/browse/BATCH-339

Introduce MrakFailedException and ResetFailedException (unchecked for now).  ResetFailedException has to be dealt with specially in the StepExecutor.
2008-02-08 13:46:11 +00:00
nebhale
dd53697a0e Polishing 2008-02-08 09:31:36 +00:00
dsyer
20baeef552 Removed unused interface 2008-02-06 19:36:33 +00:00
robokaso
37cf297899 RESOLVED - issue BATCH-343: close() is called twice on ItemReaders/ItemWriters
http://jira.springframework.org/browse/BATCH-343

ItemStream implementations no longer implement DisposableBean
2008-02-06 14:20:21 +00:00
dsyer
c86454fbe0 Add TODO for possible race condition 2008-02-06 07:08:18 +00:00
lucasward
6012f6ed8a BATCH-338: Added extra constructors to StreamException. 2008-02-05 16:57:19 +00:00
dsyer
05e0804020 Removed the close() method from ItemWriter - it shadows ItemStream so use that interface if needed. 2008-02-05 11:37:03 +00:00
dsyer
f41487b32b Removed the close() method from ItemReader - it shadows ItemStream so use that interface if needed. 2008-02-05 11:33:23 +00:00
dsyer
4d6d29b759 Javadocs 2008-02-05 11:26:45 +00:00
dsyer
22a1d7c254 Remove unnecessary context from mark()/reset() in ItemStream. 2008-02-05 10:37:01 +00:00
dsyer
8ac9c65b78 RESOLVED - issue BATCH-330: Modify RestartData to be a typesafe form of map
http://jira.springframework.org/browse/BATCH-330

Remove references to RestartData
2008-02-05 09:44:45 +00:00
dsyer
8c1cb2808f Purge StreamContext some more 2008-02-05 09:34:13 +00:00