Commit Graph

261 Commits

Author SHA1 Message Date
dsyer
add7b2f806 OPEN - issue BATCH-378: RepeatListener is confusing and too generic to use for 'intercepting' a step
http://jira.springframework.org/browse/BATCH-378

Change contract of StepListener - JobParameters are more useful at that stage than ExecutionContext.
2008-02-28 15:44:51 +00:00
dsyer
e9d74d0088 OPEN - issue BATCH-378: RepeatListener is confusing and too generic to use for 'intercepting' a step
http://jira.springframework.org/browse/BATCH-378

Replace RepeatListener with StepListener in TaskletStep.
2008-02-28 14:23:24 +00:00
dsyer
2a25a7a636 OPEN - issue BATCH-378: RepeatListener is confusing and too generic to use for 'intercepting' a step
http://jira.springframework.org/browse/BATCH-378

Remove unnecessary listener implementations and migrate some functionality to samples.  In the process discovered that tasklet steps cannot be stopped.
2008-02-28 11:41:49 +00:00
dsyer
707e94b3c8 OPEN - issue BATCH-378: RepeatListener is confusing and too generic to use for 'intercepting' a step
http://jira.springframework.org/browse/BATCH-378

Slim down StremManager
2008-02-28 10:05:08 +00:00
dsyer
425c270da3 OPEN - issue BATCH-385: Merge user attributes in StepContext with ExecutionContext
http://jira.springframework.org/browse/BATCH-385

Make Job responsible for setting up step context.  Javadocs on StepContext to indicate that the attributes are volatile.  Add JobParametersAware (might be temporary).
2008-02-28 09:14:06 +00:00
robokaso
77a4ca5d0a added assert to JobInstanceDao#createJobInstance(Job, JobParameters) that JobInstance does not already exist 2008-02-28 08:23:40 +00:00
lucasward
db46104307 Added additional menthod to ItemSkipPolicy to determine if a step should fail. Also added a small prototype of domain-specific interceptors. 2008-02-28 05:23:49 +00:00
robokaso
dd7c006a04 IN PROGRESS - issue BATCH-384: consolidate map dao implementations
http://jira.springframework.org/browse/BATCH-384

test coverage
2008-02-27 17:45:02 +00:00
nebhale
315f08a6c0 [BATCH-63] Added <job/> tag parsing 2008-02-27 17:35:28 +00:00
dsyer
7841e0bd41 RESOLVED - issue BATCH-368: StepExecution attributes can overflow and cause spurious OptimisticLockingException
http://jira.springframework.org/browse/BATCH-368

Removed STATISTICS column from BATCH_STEP_EXECUTION.
2008-02-27 17:08:31 +00:00
robokaso
84073c0b76 IN PROGRESS - issue BATCH-384: consolidate map dao implementations
http://jira.springframework.org/browse/BATCH-384

MapStepDao -> MapStepExecutionDao
improved test coverage for JobExecutionDao
2008-02-27 17:06:46 +00:00
dsyer
a35a9d79dc OPEN - issue BATCH-368: StepExecution attributes can overflow and cause spurious OptimisticLockingException
http://jira.springframework.org/browse/BATCH-368

Split the save of a StepExecution into two parts at the JobRepository level, that way we can see if the failure was in saving context or just the step execution.
Lots of exception handling and tests in step implementations.
2008-02-27 16:44:52 +00:00
robokaso
a25680d7f4 IN PROGRESS - issue BATCH-384: consolidate map dao implementations
http://jira.springframework.org/browse/BATCH-384

MapJobDao split to MapJobInstanceDao and MapJobExecutionDao.
JobInstanceDao now has getJobInstance(Job,Params) rather than findJobInstances(Job,Params)
2008-02-27 16:14:26 +00:00
nebhale
dc656d248d [BATCH-63] Refactoring to accomodate the new <config/> element 2008-02-27 15:43:24 +00:00
robokaso
63496ee571 RESOLVED - issue BATCH-321: Throw exception if attempt to create duplicate job instance occurs (based on job parameters)
http://jira.springframework.org/browse/BATCH-321

repository now throws exception if JobInstance already exists for non-restartable job. Had to tweak sample junit launcher to allow parameter setting because HibernateJob is run twice.
2008-02-27 13:34:04 +00:00
robokaso
2f3cf7bec0 RESOLVED - issue BATCH-287: add double job parameter type
http://jira.springframework.org/browse/BATCH-287
2008-02-27 11:19:45 +00:00
robokaso
8c68677dcb IN PROGRESS - issue BATCH-384: consolidate map dao implementations
http://jira.springframework.org/browse/BATCH-384

half way there - commiting changes made previously and switching to M5 priority issues
2008-02-27 09:28:31 +00:00
lucasward
6eb8883139 BATCH-392:removed saveExecutionContext from step (it's handled at a lower level now) 2008-02-27 03:27:39 +00:00
lucasward
ed2bbf96e6 BATCH-365: ItemStream#Update and ItemStream#close now accept an ExecutionContext as an argument. I removed the local ExecutionContexts in the readers and readers, and had them use the passed in ones instead. 2008-02-26 21:22:54 +00:00
lucasward
3292ab3ae0 BATCH-339: ItemWriter#flush() now throws a FlushFailedException (unchecked) and ItemWriter#clear() now throws a ClearFailedException (also unchecked) 2008-02-26 20:10:32 +00:00
dsyer
22c63e6fb9 OPEN - issue BATCH-151: add support for some sort of 'final' method to existing or new ItemProcessor implementation and related tasklets
http://jira.springframework.org/browse/BATCH-151

Organise imports.
2008-02-26 17:23:33 +00:00
dsyer
09545ba367 OPEN - issue BATCH-151: add support for some sort of 'final' method to existing or new ItemProcessor implementation and related tasklets
http://jira.springframework.org/browse/BATCH-151

Encapsulate step context identifier to prevent step from forgetting to set it up.
2008-02-26 17:08:22 +00:00
nebhale
37bfe92d62 [BATCH-63] <step/> tag of namespace complete 2008-02-26 16:41:24 +00:00
dsyer
71c61496be RESOLVED - issue BATCH-380: Step Scope problem in TaskletStep
http://jira.springframework.org/browse/BATCH-380
2008-02-26 16:27:21 +00:00
dsyer
2338565010 RESOLVED - issue BATCH-344: A JobExecution does not need a start time until it actually starts
http://jira.springframework.org/browse/BATCH-344
2008-02-26 15:48:14 +00:00
dsyer
55e35eac1c Incomplete - task 84: Fix samples
Fix rollback tests as well - exception handler too complicated
2008-02-26 15:16:02 +00:00
dsyer
ee2c20f568 Incomplete - task 84: Fix samples
ItemSkipPolicy doesn't need to know about StepContribution
2008-02-26 14:44:07 +00:00
dsyer
a1c6bd488e Incomplete - task 84: Fix samples
Expect exception in skip test
2008-02-26 14:34:29 +00:00
dsyer
42ba209b11 Incomplete - task 84: Fix samples
Fix skip policy so it responds to subclasses
2008-02-26 14:29:27 +00:00
dsyer
2b32b8d38e Incomplete - task 84: Fix samples
Fix restart sample - StepExecutionDao was not restoring execution context
2008-02-26 13:19:14 +00:00
dsyer
5e09d034e0 Incomplete - task 84: Fix samples
Switch default skip policy to Never
2008-02-26 12:26:39 +00:00
dsyer
2edf00947f Incomplete - task 84: Fix samples
Fix execution tests broken by default skip policy
2008-02-26 12:09:48 +00:00
dsyer
66c4e7091b Incomplete - task 84: Fix samples
Hibernate failure fixed on flush.
2008-02-26 12:02:33 +00:00
dsyer
8aea7deb45 Incomplete - task 84: Fix samples
Unused imports.
2008-02-26 10:56:41 +00:00
dsyer
7f0be2826e Incomplete - task 84: Fix samples
Fix column mapping in jdbc cursor - order is important.
2008-02-26 10:41:30 +00:00
robokaso
d20c76b0a7 Fixed Object attribute handling in JdbcStepExecutionDao (were being put as Longs into execution context) 2008-02-26 09:50:39 +00:00
dsyer
0333e8cd2f Incomplete - task 84: Fix samples
Infinite loop in stax sample averted by opening the stream only once
2008-02-26 09:41:29 +00:00
lucasward
38c486e449 BATCH-365: There should now be one ExecutionContext per step. All itemStreams will be opened with an execution context, and will be notified before it is saved, to ensure they have all state in the context. Most ItemReader/Writers should now have the logic for whether or not to put their state in the context, but a few have likely been missed. 2008-02-26 08:29:48 +00:00
dsyer
3b48ece7e5 Moved chunks to a branch (called chunks) 2008-02-26 08:06:11 +00:00
lucasward
23ab7d3783 Fixed the types on SAVE_STEP_EXECUTION.....Step name was using INTEGER instead of VARCHAR 2008-02-25 22:20:12 +00:00
dsyer
85806724a5 Remove RepeatOperationsStep 2008-02-25 17:54:36 +00:00
dsyer
949324c751 Remove RepeatOperationsHolder (not necessary). 2008-02-25 17:37:03 +00:00
dsyer
b41415001a Move RepeatOperationsStep up to live with other step implementations 2008-02-25 17:29:41 +00:00
robokaso
7368aa3541 IN PROGRESS - issue BATCH-340: Refactor JobRepository for greater clarity and consistency.
http://jira.springframework.org/browse/BATCH-340

more StepInstance heritage cleaned up - StepExecution refers to Step rather than stepName string
2008-02-25 17:21:46 +00:00
dsyer
ad6511fb94 OPEN - issue BATCH-349: ItemStreamAdapter isn't an Adapter
http://jira.springframework.org/browse/BATCH-349

Adapter -> Support (unless it was an Adapter)
2008-02-25 16:10:53 +00:00
robokaso
4b0edc1799 IN PROGRESS - issue BATCH-340: Refactor JobRepository for greater clarity and consistency.
http://jira.springframework.org/browse/BATCH-340

tweaking repo & dao interfaces to use domain objects instead of primitive types
2008-02-25 14:40:05 +00:00
robokaso
4e05642f98 IN PROGRESS - issue BATCH-340: Refactor JobRepository for greater clarity and consistency.
http://jira.springframework.org/browse/BATCH-340

JobInstance now has not-null Job as required constructor argument - repository no longer requires a separate Job setter
2008-02-25 13:50:53 +00:00
dsyer
1244264e50 Classpath issues on build 2008-02-25 13:08:06 +00:00
robokaso
8e1ad48aa6 IN PROGRESS - issue BATCH-340: Refactor JobRepository for greater clarity and consistency.
http://jira.springframework.org/browse/BATCH-340

removed redundant stepNames property from JobInstance (StepInstance heritage)
2008-02-25 12:37:24 +00:00
lucasward
fb98433034 BATCH-365: Moved reset and mark to ItemReader interface. 2008-02-24 21:14:51 +00:00