Commit Graph

1473 Commits

Author SHA1 Message Date
Mahmoud Ben Hassine
efdb59e570 Replace hardcoded charsets with StandardCharsets 2023-07-05 08:03:48 +02:00
Mahmoud Ben Hassine
f0137bc54c Remove redundant modifiers 2023-07-05 08:03:48 +02:00
Mahmoud Ben Hassine
0a1cdb095f Mark fields as final where appropriate 2023-07-05 08:03:48 +02:00
Mahmoud Ben Hassine
241e37e672 Remove concatenation with empty string 2023-07-05 08:03:47 +02:00
Mahmoud Ben Hassine
b5e7269847 Remove unnecessary return statements 2023-07-04 21:17:42 +02:00
Mahmoud Ben Hassine
5c8cb7663f Make inner classes static 2023-07-04 21:03:55 +02:00
Mahmoud Ben Hassine
167f3c427d Remove usage of raw parametrized types 2023-07-04 19:03:18 +02:00
Mahmoud Ben Hassine
5585749925 Use Map.computeIfAbsent where appropriate 2023-07-04 18:58:23 +02:00
Mahmoud Ben Hassine
d0be13e995 Use Comparator.comparingInt where appropriate 2023-07-04 18:56:34 +02:00
Mahmoud Ben Hassine
5a6fff032d Replace for loops with enhanced for loops 2023-07-04 18:52:19 +02:00
Mahmoud Ben Hassine
96f8d6bd35 Replace anonymous types with lambda expressions or method references 2023-07-04 18:50:16 +02:00
Mahmoud Ben Hassine
018fcf4799 Refactor tests in spring-batch-core
- Remove unused resources
- Fix logging libraries conflicts
- Merge duplicate data source configuration
- Merge scattered DDL scripts
- Replace usage of DataSourceInitializer with Spring JDBC test utilities
2023-06-23 11:30:04 +02:00
Mahmoud Ben Hassine
8aea17f21d Refactor tests in spring-batch-infrastructure
- Remove unused resources
- Fix logging libraries conflicts
- Merge duplicate data source configuration
- Merge scattered DDL scripts
- Replace usage of DataSourceInitializer with Spring JDBC test utilities
2023-06-23 08:52:08 +02:00
Mahmoud Ben Hassine
e6e9c4e7a2 Refactor ReflectionUtils 2023-06-22 16:17:23 +02:00
Mahmoud Ben Hassine
ee30af4789 Remove redundant "extends Object" 2023-06-22 11:17:13 +02:00
Mahmoud Ben Hassine
93d911e100 Use lambdas and method references where appropriate 2023-06-12 16:43:46 +02:00
Mahmoud Ben Hassine
c5b4f1a777 Remove unnecessary boxing/unboxing 2023-06-12 16:17:32 +02:00
Mahmoud Ben Hassine
7babb341f5 Replace for loops with enhanced for loop where appropriate 2023-06-12 16:05:44 +02:00
Mahmoud Ben Hassine
8c5456cff6 Replace for loops with String.repeat where appropriate 2023-06-12 16:00:45 +02:00
Mahmoud Ben Hassine
a63755b546 Use Files.readString where appropriate 2023-06-12 15:59:30 +02:00
Mahmoud Ben Hassine
53f4912991 Use enhanced switch statements where appropriate 2023-06-12 15:57:05 +02:00
Mahmoud Ben Hassine
a193fc3688 Replace String concatenation with text blocks where appropriate 2023-06-12 15:55:32 +02:00
Mahmoud Ben Hassine
0f44e2bad1 Use pattern matching variables where appropriate 2023-06-12 15:47:57 +02:00
Mahmoud Ben Hassine
a2be6ba0c3 Replace unmodifiable collection creation with collection factory methods 2023-06-12 15:42:02 +02:00
Dimitrios Liapis
f0787454f8 Fix thread usage in SynchronizedItemStreamReaderTests
along with its builder test class SynchronizedItemStreamReaderBuilderTests

Resolves #837
2023-06-12 14:22:03 +02:00
Mahmoud Ben Hassine
0bfe31e569 Remove stack traces from tests 2023-06-07 15:54:19 +02:00
Mahmoud Ben Hassine
7f80b7230b Remove System.err.println from tests 2023-06-07 15:47:56 +02:00
Mahmoud Ben Hassine
98c426ca4f Remove System.out.println from tests 2023-06-07 15:47:56 +02:00
Mahmoud Ben Hassine
92159cbc2b Use diamond operator where appropriate 2023-06-05 13:48:49 +02:00
Mahmoud Ben Hassine
0dc5b63469 Replace identical catch sections with multi-catch blocks 2023-06-05 13:30:23 +02:00
Mahmoud Ben Hassine
8070751da8 Improve String concatenation where appropriate 2023-06-05 13:19:28 +02:00
Mahmoud Ben Hassine
6d3e48a0bc Simplify assertions in tests 2023-06-05 13:08:15 +02:00
Mahmoud Ben Hassine
c25cd55901 Upgrade spring-javaformat maven plugin to version 0.0.39 2023-06-05 11:11:48 +02:00
jinwoo-Bae
30e8766faa Move equals/hashcode from ChunkIterator to Chunk class
Those methods were mistakenly added in ChunkIterator.

Issue #4314
2023-05-11 10:23:40 +02:00
Mahmoud Ben Hassine
2374a5ac11 Document thread-safety of item readers and writers
This commit also adds a sample of how to use the
synchronized decorators of item readers and writers.

Resolves #3646
2023-05-09 11:55:32 +02:00
Mahmoud Ben Hassine
118be5e002 Make KafkaItemWriter extensible and document its thread-safety
Resolves #3970
2023-05-09 10:18:30 +02:00
Mahmoud Ben Hassine
8a93b6bd47 Fix code formatting 2023-05-05 07:18:47 +02:00
Mahmoud Ben Hassine
5c257d0996 Disable flaky tests
Resolves #3847
2023-05-05 06:57:52 +02:00
Henning Poettker
4faa842bb1 Upgrade to Mockito 5
Issue #4366
2023-05-04 00:09:11 +02:00
Minsoo Kim
4a971a0764 Enhance switch statements
Issue #4365
2023-05-03 23:59:16 +02:00
Mahmoud Ben Hassine
7460c5f9a1 Update Javadoc of JdbcPagingItemReaderBuilder 2023-05-03 23:46:29 +02:00
Jonas
bb337c6b2f Change visibility of properties to protected in JdbcPagingItemReaderBuilder
There are cases, when you want to extend the JdbcPagingItemReader
by adding some custom fields and behaviours, but want to stay in
the normal way of creating this class via a Builder class.

If you want to do it, you currently have to reimplement the whole
class just for adding some fields because there is no non-ugly way
to access the fields. This commit makes those properties protected,
so one can override the default build() method behaviour in the
derived class and still have access to the properties.

Issue #4331
2023-05-03 23:28:57 +02:00
Mahmoud Ben Hassine
21bc4d582b Allow StaxEventItemReader to auto-detect the input file encoding
Before this commit, it was not possible to pass a null encoding
to the StaxEventItemReader, which prevents the XML event reader
to auto-detect the file encoding.

This commits makes the encoding setter more lenient by accepting
a null value.

Resolves #4101
2023-04-27 20:52:37 +02:00
Mahmoud Ben Hassine
ec161f8429 Reload test context before each method in AsynchronousTests
Resolves #4095
2023-04-25 23:30:26 +02:00
Mahmoud Ben Hassine
972951a40a Remove unused imports and apply imports code style 2023-04-11 16:28:36 +02:00
Henning Poettker
e61065ab00 Reduce use of deprecated APIs 2023-03-29 15:34:48 +02:00
Henning Poettker
2b536578c9 Add SafeVarargs annotations 2023-03-29 15:23:51 +02:00
Mahmoud Ben Hassine
dbdbf787e6 Update Javadocs 2023-03-21 17:51:53 +01:00
drow724
89e76164af Add default component name in constructor of AvroItemReader
Issue #4285
2023-02-21 18:08:46 +01:00
Mahmoud Ben Hassine
4ea54388e7 Fix inconsistent state validation rules in RepositoryItemReader
Before this commit, state validation rules in RepositoryItemReader
were not consistent with those applied in its builder.

This commit makes validation rules consistent between the two ways
of creating a RepositoryItemReader. This commit also adds a getter
for the component name in ExecutionContextUserSupport to be able to
assert on it where appropriate down the hierarchy.

Resolves #4276
2023-02-18 04:46:47 +01:00