Commit Graph

99 Commits

Author SHA1 Message Date
dsyer
f73ce3553c RESOLVED - issue BATCH-404: FactoryBeans for step configuration
http://jira.springframework.org/browse/BATCH-404

Tidied up listener registration and integration a bit
2008-03-04 13:16:18 +00:00
robokaso
9065b6ba25 RESOLVED - issue BATCH-406: jobInstance properties lastExecution and executionCount are useless
http://jira.springframework.org/browse/BATCH-406

removed lastExecution property and createExecution method
2008-03-04 11:46:38 +00:00
lucasward
f5a85589c9 BATCH-402: Removed startLimit from Job. Also removed executionCount from JobExecution. 2008-03-03 17:16:05 +00:00
dsyer
e5cccef3d1 OPEN - issue BATCH-404: FactoryBeans for step configuration
http://jira.springframework.org/browse/BATCH-404

Remove references to KitchenSinkStepFactoryBean - use StatefulRetryStepFactoryBean for remaining sample.
2008-03-02 13:07:04 +00:00
dsyer
b47a6e6405 Tidy up some exception class names 2008-03-01 11:59:33 +00:00
dsyer
90cb1e8ea3 Rename some packages with more logical names 2008-03-01 10:24:28 +00:00
dsyer
0eb239c9cb RESOLVED - issue BATCH-398: That old stateful / stateless thing again....
http://jira.springframework.org/browse/BATCH-398

Fix JMX demo using an application context per job execution.
2008-03-01 09:59:01 +00:00
dsyer
f2129d4ea7 OPEN - issue BATCH-398: That old stateful / stateless thing again....
http://jira.springframework.org/browse/BATCH-398

Fix delegate job (duplicate job regsitry).
2008-03-01 08:35:12 +00:00
dsyer
840ea77b7f OPEN - issue BATCH-398: That old stateful / stateless thing again....
http://jira.springframework.org/browse/BATCH-398

New XML configuration convention for samples tests (similar to JUnit 4 support in Spring 2.5).  This enables us to keep the job configurations separate.
2008-02-29 18:35:37 +00:00
dsyer
8326d88cda 2008-02-29 12:37:05 +00:00
robokaso
c89f67b7b6 javadoc updates for Tasklet and JobInstance 2008-02-29 12:32:53 +00:00
lucasward
347f62241f BATCH-378:Moved and renamed packages for listeners, added support objects, and tests, and removed the ItemFailureHandler. 2008-02-29 06:41:07 +00:00
lucasward
a519db7f38 BATCH-378: Added ChunkListener, ItemReadListener, and ItemWriterListener. Also added them to the ListenerMulticaster. 2008-02-29 00:53:00 +00:00
dsyer
9167c7de4c OPEN - issue BATCH-378: RepeatListener is confusing and too generic to use for 'intercepting' a step
http://jira.springframework.org/browse/BATCH-378

Add listener multicaster to ItemOrientedStep
2008-02-28 19:25:15 +00:00
dsyer
04f641d321 OPEN - issue BATCH-378: RepeatListener is confusing and too generic to use for 'intercepting' a step
http://jira.springframework.org/browse/BATCH-378

Add JobListener to SimpleJob.  Change StepListener method names.
2008-02-28 16:56:36 +00:00
dsyer
e9f0b41eed OPEN - issue BATCH-378: RepeatListener is confusing and too generic to use for 'intercepting' a step
http://jira.springframework.org/browse/BATCH-378

Open StepListsner with StepExecution.
2008-02-28 16:24:46 +00:00
dsyer
add7b2f806 OPEN - issue BATCH-378: RepeatListener is confusing and too generic to use for 'intercepting' a step
http://jira.springframework.org/browse/BATCH-378

Change contract of StepListener - JobParameters are more useful at that stage than ExecutionContext.
2008-02-28 15:44:51 +00:00
dsyer
e9d74d0088 OPEN - issue BATCH-378: RepeatListener is confusing and too generic to use for 'intercepting' a step
http://jira.springframework.org/browse/BATCH-378

Replace RepeatListener with StepListener in TaskletStep.
2008-02-28 14:23:24 +00:00
dsyer
2a25a7a636 OPEN - issue BATCH-378: RepeatListener is confusing and too generic to use for 'intercepting' a step
http://jira.springframework.org/browse/BATCH-378

Remove unnecessary listener implementations and migrate some functionality to samples.  In the process discovered that tasklet steps cannot be stopped.
2008-02-28 11:41:49 +00:00
lucasward
52ccced24a Added additional menthod to ItemSkipPolicy to determine if a step should fail. Also added a small prototype of domain-specific interceptors. 2008-02-28 05:23:44 +00:00
dsyer
a35a9d79dc OPEN - issue BATCH-368: StepExecution attributes can overflow and cause spurious OptimisticLockingException
http://jira.springframework.org/browse/BATCH-368

Split the save of a StepExecution into two parts at the JobRepository level, that way we can see if the failure was in saving context or just the step execution.
Lots of exception handling and tests in step implementations.
2008-02-27 16:44:52 +00:00
robokaso
2f3cf7bec0 RESOLVED - issue BATCH-287: add double job parameter type
http://jira.springframework.org/browse/BATCH-287
2008-02-27 11:19:45 +00:00
lucasward
1527494b58 BATCH-392:removed saveExecutionContext from step (it's handled at a lower level now) 2008-02-27 03:27:14 +00:00
dsyer
2338565010 RESOLVED - issue BATCH-344: A JobExecution does not need a start time until it actually starts
http://jira.springframework.org/browse/BATCH-344
2008-02-26 15:48:14 +00:00
dsyer
ee2c20f568 Incomplete - task 84: Fix samples
ItemSkipPolicy doesn't need to know about StepContribution
2008-02-26 14:44:07 +00:00
dsyer
3b48ece7e5 Moved chunks to a branch (called chunks) 2008-02-26 08:06:11 +00:00
robokaso
7368aa3541 IN PROGRESS - issue BATCH-340: Refactor JobRepository for greater clarity and consistency.
http://jira.springframework.org/browse/BATCH-340

more StepInstance heritage cleaned up - StepExecution refers to Step rather than stepName string
2008-02-25 17:21:46 +00:00
robokaso
4b0edc1799 IN PROGRESS - issue BATCH-340: Refactor JobRepository for greater clarity and consistency.
http://jira.springframework.org/browse/BATCH-340

tweaking repo & dao interfaces to use domain objects instead of primitive types
2008-02-25 14:40:05 +00:00
robokaso
4e05642f98 IN PROGRESS - issue BATCH-340: Refactor JobRepository for greater clarity and consistency.
http://jira.springframework.org/browse/BATCH-340

JobInstance now has not-null Job as required constructor argument - repository no longer requires a separate Job setter
2008-02-25 13:50:53 +00:00
robokaso
8e1ad48aa6 IN PROGRESS - issue BATCH-340: Refactor JobRepository for greater clarity and consistency.
http://jira.springframework.org/browse/BATCH-340

removed redundant stepNames property from JobInstance (StepInstance heritage)
2008-02-25 12:37:24 +00:00
lucasward
70481c2c98 First attempt at adding more explicit skip handling and removing the need for 'SimpleStepExecutor'. There's still some cleanup that needs to happen, but it's moving in the right direction. 2008-02-21 04:33:25 +00:00
robokaso
96c48bcbc5 IN PROGRESS - issue BATCH-366: Do we still need StepInstance?
http://jira.springframework.org/browse/BATCH-366

Killed StepInstance - test coverage temporarily low due to commenting obsolete tests (but sample jobs work fine).
2008-02-19 15:41:26 +00:00
lucasward
dac4af1479 BATCH-220: Updated sample jobs to use 'chunkedStep' 2008-02-19 05:55:28 +00:00
dsyer
a50a0c0873 OPEN - issue BATCH-364: StepScope responsibilities can be assumed by Step (not ApplicationContext)
http://jira.springframework.org/browse/BATCH-364

restart sample was failing because of wrong manipulation of version in step execution
2008-02-18 08:17:15 +00:00
lucasward
469203f1b6 BATCH-220: Moved transactional boundary within ChunkedStep to include both 'Chunking' and 'Dechunking' 2008-02-15 23:30:30 +00:00
dsyer
7096c8c024 OPEN - issue BATCH-364: StepScope responsibilities can be assumed by Step (not ApplicationContext)
http://jira.springframework.org/browse/BATCH-364

Extend columns in attrs table -to avoid crashes resulting in optimistic lock failure.
2008-02-15 14:40:33 +00:00
dsyer
ec5379ebac OPEN - issue BATCH-364: StepScope responsibilities can be assumed by Step (not ApplicationContext)
http://jira.springframework.org/browse/BATCH-364

Make StreamManager responsible for calling open() and close().
2008-02-15 13:44:36 +00:00
robokaso
4a40b17002 RESOLVED - issue BATCH-362: Rename ExecutionAttributes to ExecutionContext
http://jira.springframework.org/browse/BATCH-362
2008-02-15 12:12:16 +00:00
dsyer
711d0c6e92 OPEN - issue BATCH-364: StepScope responsibilities can be assumed by Step (not ApplicationContext)
http://jira.springframework.org/browse/BATCH-364

Instead of lazy open, throw exception is stream is used before open().
2008-02-15 09:19:25 +00:00
lucasward
d7d17bf8d8 BATCH-220:Moved SimpleJob (formerly simpleTaskletJob) to use the ChunkedStep 2008-02-14 22:19:45 +00:00
robokaso
345b9c47db IN PROGRESS - issue BATCH-340: Refactor JobRepository for greater clarity and consistency.
http://jira.springframework.org/browse/BATCH-340

organize imports
2008-02-14 13:24:43 +00:00
robokaso
62ccc5d07a IN PROGRESS - issue BATCH-340: Refactor JobRepository for greater clarity and consistency.
http://jira.springframework.org/browse/BATCH-340

Removed no-op update(StepInstance) and update(JobInstance) repository methods
2008-02-14 13:19:51 +00:00
lucasward
d54166e607 BATCH-220:Further refinements to chunk processing. The chunker/dechunker interfaces now accept a StepExecution, so that they don't have to be instantiated anew for each chunk. They can also be wired into the ChunkedStep as well. 2008-02-14 05:45:13 +00:00
lucasward
9a830aae19 BATCH-220: More refinements to chunking, both the chunker and dechunker now return a 'result'. The chunker returns a ChunkingResult, and the Dechunker returns a DechunkingResult, allowing for the step to handle exceptions in a uniform way. 2008-02-13 21:05:42 +00:00
lucasward
1871df0539 BATCH-220:Added the 'Dechunker', as the opposite of Chunker. It assumes that some higher level class will be managing transactions. Also renamed ReadFailurePolicy to ItemSkipPolicy (Same name used by Ben in the Sandbox) once I realized that a 'ReadFailurePolicy' and 'WriteFailurePolicy' would have pretty much the same interface. 2008-02-12 06:07:40 +00:00
dsyer
2b87124b85 RESOLVED - issue BATCH-241: Support for JobLauncher.stop() on job that hasn't started yet (delayed execution)
http://jira.springframework.org/browse/BATCH-241

Since SimpleJobLauncher no longer has a stop method, we have to do the check on execution, lower down the stack.  Added explicit check for STOPPED status in SimpleJob and JoBExecution.
2008-02-11 19:54:21 +00:00
lucasward
7a2cdadf8c BATCH-220: Committed the read part of chunking, without adding it to the StepExecutor. It should be noted that I used 'Chunker' instead of 'ChunkReader', since there's already precedence in the java world, and it isn't reading chunk so much as making a chunk out of items. I have also added skipCount to StepExecution, since it's reasonable that this type of data A) should be persisted and B) the domain object is the most logical place for this type of state. 2008-02-11 03:17:58 +00:00
dsyer
c43c1b4466 OPEN - issue BATCH-339: ItemStream.mark() and reset() should throw a checked exception
http://jira.springframework.org/browse/BATCH-339

Introduce MrakFailedException and ResetFailedException (unchecked for now).  ResetFailedException has to be dealt with specially in the StepExecutor.
2008-02-08 13:46:11 +00:00
nebhale
55f5e36293 [BATCH-85] Polishing 2008-02-08 08:38:30 +00:00
lucasward
a0c4af8351 BATCH-337:No *Instance domain objects (or their respective tables) contain a 'status'. Instead, they contain the 'last execution', which can be used to determinte the status. RestartData is also no longer necessary, as everything can be 'restored' by calling stepInstance.getLastExecution().getExecutionAttributes(). Also changed all 'ID' columns to be complete, such as 'JOB_INSTANCE_ID' rather than just 'ID'. 2008-02-06 03:44:19 +00:00