From 532599aa2aa7ae92d014c61b0fbd703ab267c6f8 Mon Sep 17 00:00:00 2001 From: John Blum Date: Thu, 1 Aug 2019 14:01:31 -0700 Subject: [PATCH] Fix bug in CalculatorService incorrectly capturing the 'operand' of the mathematical function. --- .../example/app/caching/inline/service/CalculatorService.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/spring-geode-samples/caching/inline/src/main/java/example/app/caching/inline/service/CalculatorService.java b/spring-geode-samples/caching/inline/src/main/java/example/app/caching/inline/service/CalculatorService.java index 75542f2d..09558160 100644 --- a/spring-geode-samples/caching/inline/src/main/java/example/app/caching/inline/service/CalculatorService.java +++ b/spring-geode-samples/caching/inline/src/main/java/example/app/caching/inline/service/CalculatorService.java @@ -57,13 +57,14 @@ public class CalculatorService extends AbstractCacheableService { return ResultHolder.of(number, Operator.FACTORIAL, number == 2 ? 2 : 1); } + int operand = number; int result = number; while (--number > 1) { result *= number; } - return ResultHolder.of(number, Operator.FACTORIAL, result); + return ResultHolder.of(operand, Operator.FACTORIAL, result); } @Cacheable(value = "SquareRoots", keyGenerator = "resultKeyGenerator")