Spring/spring-boot-data-geode
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Add descriptive convertJsonToPdx(..) conversion method.

Browse Source 
Add protected jsonFormatterFromJson(..) method to encapsulate the invocation of the JSONFormatter.fromJSON(..) method.

Add wrap(:PdxInstance) method to wrap the PdxInstance generated from JSON in a new instance of PdxInstanceWrapper.

Resolves gh-67.
This commit is contained in:
John Blum
2020-05-12 19:33:14 -07:00
parent eba12bad17
commit 8fe13e01fb
3 changed files with 41 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
spring-geode/src/test/java/org/springframework/geode/data/json/converter/support/JSONFormatterJsonToPdxConverterUnitTests.java
View File

@@ -27,6 +27,8 @@ import org.junit.Test;
import org.apache.geode.pdx.PdxInstance;
import org.springframework.geode.pdx.PdxInstanceWrapper;
/**
* Unit Tests for {@link JSONFormatterJsonToPdxConverter}.
*
@@ -35,6 +37,7 @@ import org.apache.geode.pdx.PdxInstance;
* @see org.mockito.Mockito
* @see org.apache.geode.pdx.PdxInstance
* @see org.springframework.geode.data.json.converter.support.JSONFormatterJsonToPdxConverter
* @see org.springframework.geode.pdx.PdxInstanceWrapper
* @since 1.3.0
*/
public class JSONFormatterJsonToPdxConverterUnitTests {
@@ -48,10 +51,15 @@ public class JSONFormatterJsonToPdxConverterUnitTests {
JSONFormatterJsonToPdxConverter converter = spy(new JSONFormatterJsonToPdxConverter());
doReturn(mockPdxInstance).when(converter).convertJsonToPdx(json);
doReturn(mockPdxInstance).when(converter).jsonFormatterFromJson(json);
assertThat(converter.convert(json)).isEqualTo(mockPdxInstance);
PdxInstance pdx = converter.convert(json);
assertThat(pdx).isInstanceOf(PdxInstanceWrapper.class);
assertThat(((PdxInstanceWrapper) pdx).getDelegate()).isEqualTo(mockPdxInstance);
verify(converter, times(1)).convertJsonToPdx(eq(json));
verify(converter, times(1)).jsonFormatterFromJson(eq(json));
verify(converter, times(1)).wrap(eq(mockPdxInstance));
}
}