From a0827eebf8f148792ed39b09274cfe76fb70445b Mon Sep 17 00:00:00 2001 From: John Blum Date: Tue, 23 Mar 2021 12:41:29 -0700 Subject: [PATCH] Fix compiler warnings. Make Function instance fields final. --- ...NameAutoConfigurationIntegrationTests.java | 4 +-- ...onalOnMissingPropertyIntegrationTests.java | 29 ++++++++++--------- 2 files changed, 18 insertions(+), 15 deletions(-) diff --git a/spring-geode-autoconfigure/src/test/java/org/springframework/geode/boot/autoconfigure/cache/CacheNameAutoConfigurationIntegrationTests.java b/spring-geode-autoconfigure/src/test/java/org/springframework/geode/boot/autoconfigure/cache/CacheNameAutoConfigurationIntegrationTests.java index 298ae572..4dfc5682 100644 --- a/spring-geode-autoconfigure/src/test/java/org/springframework/geode/boot/autoconfigure/cache/CacheNameAutoConfigurationIntegrationTests.java +++ b/spring-geode-autoconfigure/src/test/java/org/springframework/geode/boot/autoconfigure/cache/CacheNameAutoConfigurationIntegrationTests.java @@ -53,13 +53,13 @@ public class CacheNameAutoConfigurationIntegrationTests extends SpringBootApplic private Function springApplicationBuilderFunction = Function.identity(); - private Function springApplicationNamePropertyFunction = + private final Function springApplicationNamePropertyFunction = builder -> { builder.properties(Collections.singletonMap("spring.application.name", "SpringApplicationNameTest")); return builder; }; - private Function springDataGemFireNamePropertyFunction = + private final Function springDataGemFireNamePropertyFunction = builder -> { builder.properties(Collections.singletonMap("spring.data.gemfire.name", "SpringDataGemFireNameTest")); return builder; diff --git a/spring-geode-autoconfigure/src/test/java/org/springframework/geode/boot/autoconfigure/condition/ConditionalOnMissingPropertyIntegrationTests.java b/spring-geode-autoconfigure/src/test/java/org/springframework/geode/boot/autoconfigure/condition/ConditionalOnMissingPropertyIntegrationTests.java index e1919cd7..d3d3275f 100644 --- a/spring-geode-autoconfigure/src/test/java/org/springframework/geode/boot/autoconfigure/condition/ConditionalOnMissingPropertyIntegrationTests.java +++ b/spring-geode-autoconfigure/src/test/java/org/springframework/geode/boot/autoconfigure/condition/ConditionalOnMissingPropertyIntegrationTests.java @@ -46,21 +46,24 @@ public class ConditionalOnMissingPropertyIntegrationTests extends SpringBootAppl private Function springApplicationBuilderFunction = Function.identity(); - private Function allMatchingPropertiesFunction = builder -> { - builder.properties(Collections.singletonMap("example.app.config.propOne", "")); - builder.properties(Collections.singletonMap("example.app.config.propTwo", "test")); - return builder; - }; + private final Function allMatchingPropertiesFunction = + builder -> { + builder.properties(Collections.singletonMap("example.app.config.propOne", "")); + builder.properties(Collections.singletonMap("example.app.config.propTwo", "test")); + return builder; + }; - private Function nonMatchingPropertyFunction = builder -> { - builder.properties(Collections.singletonMap("example.app.cfg.propertyOne", "")); - return builder; - }; + private final Function nonMatchingPropertyFunction = + builder -> { + builder.properties(Collections.singletonMap("example.app.cfg.propertyOne", "")); + return builder; + }; - private Function singleMatchingPropertyFunction = builder -> { - builder.properties(Collections.singletonMap("example.app.config.propTwo", "test")); - return builder; - }; + private final Function singleMatchingPropertyFunction = + builder -> { + builder.properties(Collections.singletonMap("example.app.config.propTwo", "test")); + return builder; + }; @Override protected SpringApplicationBuilder processBeforeBuild(SpringApplicationBuilder springApplicationBuilder) {