Polish

spring-boot-samples/spring-boot-sample-data-gemfire/src/main/java/sample/data/gemfire/service/GemstoneServiceImpl.java

@@ -16,15 +16,14 @@
 
 package sample.data.gemfire.service;
 
-import java.util.ArrayList;
 import java.util.Arrays;
+import java.util.Collections;
 import java.util.List;
 
 import javax.annotation.PostConstruct;
 
 import sample.data.gemfire.domain.Gemstone;
 
-import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.stereotype.Service;
 import org.springframework.transaction.annotation.Transactional;
 import org.springframework.util.Assert;
@@ -39,14 +38,18 @@ import org.springframework.util.Assert;
 @Service("gemstoneService")
 public class GemstoneServiceImpl implements GemstoneService {
 
-	protected static final List<String> APPROVED_GEMS = new ArrayList<String>(
-			Arrays.asList("ALEXANDRITE", "AQUAMARINE", "DIAMOND", "OPAL", "PEARL", "RUBY",
-					"SAPPHIRE", "SPINEL", "TOPAZ"));
+	protected static final List<String> APPROVED_GEMS;
 
-	private final GemstoneRepository gemstoneRepository;
+	static {
+		APPROVED_GEMS = Collections.unmodifiableList(
+				Arrays.asList("ALEXANDRITE,AQUAMARINE,DIAMOND,OPAL,PEARL,"
+						+ "RUBY,SAPPHIRE,SPINEL,TOPAZ".split(",")));
+	}
+
+	private final GemstoneRepository repository;
 
 	public GemstoneServiceImpl(GemstoneRepository gemstoneRepository) {
-		this.gemstoneRepository = gemstoneRepository;
+		this.repository = gemstoneRepository;
 	}
 
 	@PostConstruct
@@ -56,20 +59,16 @@ public class GemstoneServiceImpl implements GemstoneService {
 
 	/**
 	 * Returns a count of the number of Gemstones in the GemFire Cache.
-	 * <p/>
-	 *
 	 * @return a long value indicating the number of Gemstones in the GemFire Cache.
 	 */
 	@Override
 	@Transactional(readOnly = true)
 	public long count() {
-		return this.gemstoneRepository.count();
+		return this.repository.count();
 	}
 
 	/**
 	 * Gets a Gemstone by ID.
-	 * <p/>
-	 *
 	 * @param id a long value indicating the identifier of the Gemstone.
 	 * @return a Gemstone with ID, or null if no Gemstone exists with ID.
 	 * @see sample.data.gemfire.domain.Gemstone
@@ -77,13 +76,11 @@ public class GemstoneServiceImpl implements GemstoneService {
 	@Override
 	@Transactional(readOnly = true)
 	public Gemstone get(Long id) {
-		return this.gemstoneRepository.findOne(id);
+		return this.repository.findOne(id);
 	}
 
 	/**
 	 * Gets a Gemstone by name.
-	 * <p/>
-	 *
 	 * @param name a String value indicating the name of the Gemstone.
 	 * @return a Gemstone with name, or null if no Gemstone exists with name.
 	 * @see sample.data.gemfire.domain.Gemstone
@@ -91,13 +88,11 @@ public class GemstoneServiceImpl implements GemstoneService {
 	@Override
 	@Transactional(readOnly = true)
 	public Gemstone get(String name) {
-		return this.gemstoneRepository.findByName(name);
+		return this.repository.findByName(name);
 	}
 
 	/**
 	 * Return a listing of Gemstones currently stored in the GemFire Cache.
-	 * <p/>
-	 *
 	 * @return an Iterable object to iterate over the list of Gemstones currently stored
 	 * in the GemFire Cache.
 	 * @see java.lang.Iterable
@@ -106,13 +101,11 @@ public class GemstoneServiceImpl implements GemstoneService {
 	@Override
 	@Transactional(readOnly = true)
 	public Iterable<Gemstone> list() {
-		return this.gemstoneRepository.findAll();
+		return this.repository.findAll();
 	}
 
 	/**
 	 * Saves the specified Gemstone to the GemFire Cache.
-	 * <p/>
-	 *
 	 * @param gemstone the Gemstone to save in the GemFire Cache.
 	 * @return the saved Gemstone.
 	 * @see sample.data.gemfire.domain.Gemstone
@@ -122,17 +115,13 @@ public class GemstoneServiceImpl implements GemstoneService {
 	public Gemstone save(Gemstone gemstone) {
 		Assert.notNull(gemstone, "The Gemstone to save must not be null!");
 		Assert.notNull(gemstone.getName(), "The name of the Gemstone must be specified!");
-
-		// NOTE deliberately (& naively) validate the Gemstone after mutating data access in
-		// GemFire rather than before to demonstrate transactions in GemFire.
-		Gemstone savedGemstone = validate(this.gemstoneRepository.save(gemstone));
-
-		Assert.state(savedGemstone.equals(get(gemstone.getId())), String.format(
-				"Failed to find Gemstone (%1$s) in GemFire's Cache Region 'Gemstones'!",
-				gemstone));
-
+		// NOTE deliberately (& naively) validate the Gemstone after mutating data access
+		// in GemFire rather than before to demonstrate transactions in GemFire.
+		Gemstone savedGemstone = validate(this.repository.save(gemstone));
+		Assert.state(savedGemstone.equals(get(gemstone.getId())),
+				String.format("Failed to find Gemstone (%1$s) in "
+						+ "GemFire's Cache Region 'Gemstones'!", gemstone));
 		System.out.printf("Saved Gemstone [%1$s]%n", savedGemstone.getName());
-
 		return gemstone;
 	}
 
@@ -144,16 +133,7 @@ public class GemstoneServiceImpl implements GemstoneService {
 			throw new IllegalGemstoneException(
 					String.format("[%1$s] is not a valid Gemstone!", gemstone.getName()));
 		}
-
 		return gemstone;
 	}
 
-	public static final class IllegalGemstoneException extends IllegalArgumentException {
-
-		public IllegalGemstoneException(String message) {
-			super(message);
-		}
-
-	}
-
 }

spring-boot-samples/spring-boot-sample-data-gemfire/src/main/java/sample/data/gemfire/service/IllegalGemstoneException.java

@@ -0,0 +1,30 @@
+/*
+ * Copyright 2012-2016 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package sample.data.gemfire.service;
+
+/**
+ * Exception thrown from {@link GemstoneService}.
+ *
+ * @author John Blum
+ */
+public class IllegalGemstoneException extends IllegalArgumentException {
+
+	public IllegalGemstoneException(String message) {
+		super(message);
+	}
+
+}