Spring/spring-boot
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Switch to Yahoo for OIDC as Google's cert is not yet trusted by Java 11

Browse Source 
Until the fix for JDK-8209506 [1] is available in Java 11 builds,
SSL connections to services using Google's SSL certificate do not work
due to a lack of trust. This affects both our OAuth2 client samples
which were using https://accounts.google.com as an OpenID Connect
provider.

This commit switches the two samples to use Yahoo in place of Google.

See gh-14028

[1] https://bugs.openjdk.java.net/browse/JDK-8209506
This commit is contained in:
Andy Wilkinson
2018-08-15 14:21:22 +01:00
parent 4a68e2e4a1
commit 0ba6d8da4a
4 changed files with 16 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
spring-boot-samples/spring-boot-sample-oauth2-client/src/test/java/sample/oauth2/client/SampleOAuth2ClientApplicationTests.java
View File

@@ -34,8 +34,8 @@ import static org.assertj.core.api.Assertions.assertThat;
@RunWith(SpringRunner.class)
@SpringBootTest(webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT, properties = {
"APP-CLIENT-ID=my-client-id", "APP-CLIENT-SECRET=my-client-secret",
"GOOGLE-CLIENT-ID=my-google-client-id",
"GOOGLE-CLIENT-SECRET=my-google-client-secret" })
"YAHOO-CLIENT-ID=my-yahoo-client-id",
"YAHOO-CLIENT-SECRET=my-yahooo-client-secret" })
public class SampleOAuth2ClientApplicationTests {
@LocalServerPort
@@ -57,7 +57,7 @@ public class SampleOAuth2ClientApplicationTests {
ResponseEntity<String> entity = this.restTemplate.getForEntity("/login",
String.class);
assertThat(entity.getStatusCode()).isEqualTo(HttpStatus.OK);
assertThat(entity.getBody()).contains("/oauth2/authorization/google");
assertThat(entity.getBody()).contains("/oauth2/authorization/yahoo");
assertThat(entity.getBody()).contains("/oauth2/authorization/github-client-1");
assertThat(entity.getBody()).contains("/oauth2/authorization/github-client-2");
}