Spring/spring-boot
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Use CollectionUtils.isEmpty() and StringUtils.hasLength()

Browse Source 
See gh-40645
This commit is contained in:
Yanming Zhou
2024-05-09 15:15:51 +08:00
committed by Moritz Halbritter
parent a67c8e4bbd
commit 0e450d602d
9 changed files with 24 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
spring-boot-project/spring-boot-tools/spring-boot-gradle-plugin/src/main/java/org/springframework/boot/gradle/tasks/bundling/BootBuildImage.java
View File

@@ -49,6 +49,7 @@ import org.springframework.boot.buildpack.platform.docker.type.ImageName;
import org.springframework.boot.buildpack.platform.docker.type.ImageReference;
import org.springframework.boot.buildpack.platform.io.ZipFileTarArchive;
import org.springframework.boot.gradle.util.VersionExtractor;
import org.springframework.util.CollectionUtils;
import org.springframework.util.StringUtils;
/**
@@ -348,7 +349,7 @@ public abstract class BootBuildImage extends DefaultTask {
private BuildRequest customizeEnvironment(BuildRequest request) {
Map<String, String> environment = getEnvironment().getOrNull();
if (environment != null && !environment.isEmpty()) {
if (!CollectionUtils.isEmpty(environment)) {
request = request.withEnv(environment);
}
return request;
@@ -377,7 +378,7 @@ public abstract class BootBuildImage extends DefaultTask {
private BuildRequest customizeBuildpacks(BuildRequest request) {
List<String> buildpacks = getBuildpacks().getOrNull();
if (buildpacks != null && !buildpacks.isEmpty()) {
if (!CollectionUtils.isEmpty(buildpacks)) {
return request.withBuildpacks(buildpacks.stream().map(BuildpackReference::of).toList());
}
return request;
@@ -385,7 +386,7 @@ public abstract class BootBuildImage extends DefaultTask {
private BuildRequest customizeBindings(BuildRequest request) {
List<String> bindings = getBindings().getOrNull();
if (bindings != null && !bindings.isEmpty()) {
if (!CollectionUtils.isEmpty(bindings)) {
return request.withBindings(bindings.stream().map(Binding::of).toList());
}
return request;
@@ -393,7 +394,7 @@ public abstract class BootBuildImage extends DefaultTask {
private BuildRequest customizeTags(BuildRequest request) {
List<String> tags = getTags().getOrNull();
if (tags != null && !tags.isEmpty()) {
if (!CollectionUtils.isEmpty(tags)) {
return request.withTags(tags.stream().map(ImageReference::of).toList());
}
return request;

4
spring-boot-project/spring-boot-tools/spring-boot-gradle-plugin/src/main/java/org/springframework/boot/gradle/tasks/bundling/LaunchScriptConfiguration.java
View File

@@ -30,6 +30,8 @@ import org.gradle.api.tasks.PathSensitive;
import org.gradle.api.tasks.PathSensitivity;
import org.gradle.api.tasks.bundling.AbstractArchiveTask;
import org.springframework.util.StringUtils;
/**
* Encapsulates the configuration of the launch script for an executable jar or war.
*
@@ -111,7 +113,7 @@ public class LaunchScriptConfiguration implements Serializable {
private void putIfMissing(Map<String, String> properties, String key, String... valueCandidates) {
if (!properties.containsKey(key)) {
for (String candidate : valueCandidates) {
if (candidate != null && !candidate.isEmpty()) {
if (StringUtils.hasLength(candidate)) {
properties.put(key, candidate);
return;
}