Merge branch '3.2.x'

Closes gh-39093
This commit is contained in:
Andy Wilkinson
2024-01-11 11:25:26 +00:00
151 changed files with 354 additions and 349 deletions

View File

@@ -1,5 +1,5 @@
/*
* Copyright 2012-2023 the original author or authors.
* Copyright 2012-2024 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -101,7 +101,7 @@ final class BuildpackLayersMetadata extends MappedObject {
return new BuildpackLayersMetadata(node);
}
private static class Buildpacks {
private static final class Buildpacks {
private final Map<String, BuildpackVersions> buildpacks = new HashMap<>();
@@ -126,7 +126,7 @@ final class BuildpackLayersMetadata extends MappedObject {
}
private static class BuildpackVersions {
private static final class BuildpackVersions {
private final Map<String, BuildpackLayerDetails> versions = new HashMap<>();

View File

@@ -1,5 +1,5 @@
/*
* Copyright 2012-2023 the original author or authors.
* Copyright 2012-2024 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -331,7 +331,7 @@ class Lifecycle implements Closeable {
/**
* Common directories used by the various phases.
*/
private static class Directory {
private static final class Directory {
/**
* The directory used by buildpacks to write their layer contributions. A new

View File

@@ -1,5 +1,5 @@
/*
* Copyright 2012-2023 the original author or authors.
* Copyright 2012-2024 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -500,7 +500,7 @@ public class DockerApi {
/**
* {@link UpdateListener} used to capture the image digest.
*/
private static class DigestCaptureUpdateListener implements UpdateListener<ProgressUpdateEvent> {
private static final class DigestCaptureUpdateListener implements UpdateListener<ProgressUpdateEvent> {
private static final String PREFIX = "Digest:";
@@ -521,7 +521,7 @@ public class DockerApi {
/**
* {@link UpdateListener} used to ensure an image load response stream.
*/
private static class StreamCaptureUpdateListener implements UpdateListener<LoadImageUpdateEvent> {
private static final class StreamCaptureUpdateListener implements UpdateListener<LoadImageUpdateEvent> {
private String stream;
@@ -540,7 +540,7 @@ public class DockerApi {
* {@link UpdateListener} used to capture the details of an error in a response
* stream.
*/
private static class ErrorCaptureUpdateListener implements UpdateListener<PushImageUpdateEvent> {
private static final class ErrorCaptureUpdateListener implements UpdateListener<PushImageUpdateEvent> {
@Override
public void onUpdate(PushImageUpdateEvent event) {

View File

@@ -1,5 +1,5 @@
/*
* Copyright 2012-2023 the original author or authors.
* Copyright 2012-2024 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -88,7 +88,7 @@ final class LocalHttpClientTransport extends HttpClientTransport {
/**
* {@link DnsResolver} that ensures only the loopback address is used.
*/
private static class LocalDnsResolver implements DnsResolver {
private static final class LocalDnsResolver implements DnsResolver {
private static final InetAddress LOOPBACK = InetAddress.getLoopbackAddress();
@@ -136,7 +136,7 @@ final class LocalHttpClientTransport extends HttpClientTransport {
/**
* {@link HttpRoutePlanner} for local Docker.
*/
private static class LocalRoutePlanner implements HttpRoutePlanner {
private static final class LocalRoutePlanner implements HttpRoutePlanner {
@Override
public HttpRoute determineRoute(HttpHost target, HttpContext context) {

View File

@@ -1,5 +1,5 @@
/*
* Copyright 2012-2023 the original author or authors.
* Copyright 2012-2024 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -157,7 +157,7 @@ public abstract class DomainSocket extends AbstractSocket {
/**
* {@link InputStream} returned from the {@link DomainSocket}.
*/
private class DomainSocketInputStream extends InputStream {
private final class DomainSocketInputStream extends InputStream {
@Override
public int read() throws IOException {
@@ -180,7 +180,7 @@ public abstract class DomainSocket extends AbstractSocket {
/**
* {@link OutputStream} returned from the {@link DomainSocket}.
*/
private class DomainSocketOutputStream extends OutputStream {
private final class DomainSocketOutputStream extends OutputStream {
@Override
public void write(int b) throws IOException {

View File

@@ -1,5 +1,5 @@
/*
* Copyright 2012-2023 the original author or authors.
* Copyright 2012-2024 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -159,7 +159,7 @@ public class NamedPipeSocket extends Socket {
return this.fileChannel.isOpen();
}
private static class CompletableFutureHandler extends CompletableFuture<Integer>
private static final class CompletableFutureHandler extends CompletableFuture<Integer>
implements CompletionHandler<Integer, Object> {
@Override
@@ -183,7 +183,7 @@ public class NamedPipeSocket extends Socket {
/**
* Waits for the name pipe file using a simple sleep.
*/
private static class SleepAwaiter implements Consumer<String> {
private static final class SleepAwaiter implements Consumer<String> {
@Override
public void accept(String path) {
@@ -200,7 +200,7 @@ public class NamedPipeSocket extends Socket {
/**
* Waits for the name pipe file using Windows specific logic.
*/
private static class WindowsAwaiter implements Consumer<String> {
private static final class WindowsAwaiter implements Consumer<String> {
@Override
public void accept(String path) {

View File

@@ -1,5 +1,5 @@
/*
* Copyright 2012-2023 the original author or authors.
* Copyright 2012-2024 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -145,7 +145,7 @@ public class OptionHandler {
return this.optionHelp;
}
private static class OptionHelpFormatter implements HelpFormatter {
private static final class OptionHelpFormatter implements HelpFormatter {
private final List<OptionHelp> help = new ArrayList<>();

View File

@@ -1,5 +1,5 @@
/*
* Copyright 2012-2023 the original author or authors.
* Copyright 2012-2024 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -101,7 +101,7 @@ class ConstructorParameterPropertyDescriptor extends PropertyDescriptor<Variable
return (coercedValue != null) ? coercedValue : value;
}
private static class DefaultValueCoercionTypeVisitor extends TypeKindVisitor8<Object, String> {
private static final class DefaultValueCoercionTypeVisitor extends TypeKindVisitor8<Object, String> {
private static final DefaultValueCoercionTypeVisitor INSTANCE = new DefaultValueCoercionTypeVisitor();
@@ -161,7 +161,7 @@ class ConstructorParameterPropertyDescriptor extends PropertyDescriptor<Variable
}
private static class DefaultPrimitiveTypeVisitor extends TypeKindVisitor8<Object, Void> {
private static final class DefaultPrimitiveTypeVisitor extends TypeKindVisitor8<Object, Void> {
private static final DefaultPrimitiveTypeVisitor INSTANCE = new DefaultPrimitiveTypeVisitor();

View File

@@ -1,5 +1,5 @@
/*
* Copyright 2012-2020 the original author or authors.
* Copyright 2012-2024 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -57,7 +57,7 @@ public class JavaCompilerFieldValuesParser implements FieldValuesParser {
/**
* {@link TreeVisitor} to collect fields.
*/
private static class FieldCollector implements TreeVisitor {
private static final class FieldCollector implements TreeVisitor {
private static final Map<String, Class<?>> WRAPPER_TYPES;

View File

@@ -1,5 +1,5 @@
/*
* Copyright 2012-2023 the original author or authors.
* Copyright 2012-2024 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -163,7 +163,7 @@ class JsonConverter {
return defaultValue;
}
private static class ItemMetadataComparator implements Comparator<ItemMetadata> {
private static final class ItemMetadataComparator implements Comparator<ItemMetadata> {
private static final Comparator<ItemMetadata> GROUP = Comparator.comparing(ItemMetadata::getName)
.thenComparing(ItemMetadata::getSourceType, Comparator.nullsFirst(Comparator.naturalOrder()));

View File

@@ -1,5 +1,5 @@
/*
* Copyright 2012-2023 the original author or authors.
* Copyright 2012-2024 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -109,7 +109,7 @@ public abstract class AbstractFieldValuesProcessorTests {
@SupportedAnnotationTypes({ "org.springframework.boot.configurationsample.ConfigurationProperties" })
@SupportedSourceVersion(SourceVersion.RELEASE_6)
private class TestProcessor extends AbstractProcessor {
private final class TestProcessor extends AbstractProcessor {
private FieldValuesParser processor;

View File

@@ -1,5 +1,5 @@
/*
* Copyright 2012-2023 the original author or authors.
* Copyright 2012-2024 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -217,7 +217,7 @@ class ExtractCommandTests {
return FileCopyUtils.copyToString(reader);
}
private static class TestLayers implements Layers {
private static final class TestLayers implements Layers {
@Override
public Iterator<String> iterator() {

View File

@@ -1,5 +1,5 @@
/*
* Copyright 2012-2023 the original author or authors.
* Copyright 2012-2024 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -129,7 +129,7 @@ public class RandomAccessDataFile implements RandomAccessData {
/**
* {@link InputStream} implementation for the {@link RandomAccessDataFile}.
*/
private class DataInputStream extends InputStream {
private final class DataInputStream extends InputStream {
private int position;

View File

@@ -1,5 +1,5 @@
/*
* Copyright 2012-2023 the original author or authors.
* Copyright 2012-2024 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -64,7 +64,7 @@ class LauncherJarModeTests {
assertThat(out).contains("Unsupported jarmode 'idontexist'");
}
private static class TestLauncher extends Launcher {
private static final class TestLauncher extends Launcher {
@Override
protected String getMainClass() throws Exception {

View File

@@ -1,5 +1,5 @@
/*
* Copyright 2012-2022 the original author or authors.
* Copyright 2012-2024 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -38,7 +38,7 @@ public abstract class LogbackInitializer {
}
}
private static class Initializer {
private static final class Initializer {
void setRootLogLevel() {
ILoggerFactory factory = LoggerFactory.getILoggerFactory();

View File

@@ -1,5 +1,5 @@
/*
* Copyright 2012-2020 the original author or authors.
* Copyright 2012-2024 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -261,7 +261,7 @@ public abstract class MainClassFinder {
}
}
private static class ClassEntryComparator implements Comparator<JarEntry> {
private static final class ClassEntryComparator implements Comparator<JarEntry> {
@Override
public int compare(JarEntry o1, JarEntry o2) {

View File

@@ -1,5 +1,5 @@
/*
* Copyright 2012-2023 the original author or authors.
* Copyright 2012-2024 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -566,7 +566,7 @@ public abstract class Packager {
* An {@link UnpackHandler} that determines that an entry needs to be unpacked if
* a library that requires unpacking has a matching entry name.
*/
private class PackagedLibrariesUnpackHandler implements UnpackHandler {
private final class PackagedLibrariesUnpackHandler implements UnpackHandler {
@Override
public boolean requiresUnpack(String name) {

View File

@@ -1,5 +1,5 @@
/*
* Copyright 2012-2023 the original author or authors.
* Copyright 2012-2024 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -399,7 +399,7 @@ final class JarUrlConnection extends java.net.JarURLConnection {
* Empty {@link URLStreamHandler} used to prevent the wrong JAR Handler from being
* Instantiated and cached.
*/
private static class EmptyUrlStreamHandler extends URLStreamHandler {
private static final class EmptyUrlStreamHandler extends URLStreamHandler {
@Override
protected URLConnection openConnection(URL url) {

View File

@@ -1,5 +1,5 @@
/*
* Copyright 2012-2023 the original author or authors.
* Copyright 2012-2024 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -142,7 +142,7 @@ class UrlJarFiles {
/**
* Internal cache.
*/
private static class Cache {
private static final class Cache {
private final Map<String, JarFile> jarFileUrlToJarFile = new HashMap<>();

View File

@@ -1,5 +1,5 @@
/*
* Copyright 2012-2023 the original author or authors.
* Copyright 2012-2024 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -74,7 +74,7 @@ class LauncherTests {
}
private static class TestLauncher extends Launcher {
private static final class TestLauncher extends Launcher {
@Override
protected String getMainClass() throws Exception {

View File

@@ -1,5 +1,5 @@
/*
* Copyright 2012-2023 the original author or authors.
* Copyright 2012-2024 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -112,7 +112,7 @@ class LazyDelegatingInputStreamTests {
assertThat(this.inputStream.count).isOne();
}
private class TestLazyDelegatingInputStream extends LazyDelegatingInputStream {
private final class TestLazyDelegatingInputStream extends LazyDelegatingInputStream {
private int count;

View File

@@ -1,5 +1,5 @@
/*
* Copyright 2012-2023 the original author or authors.
* Copyright 2012-2024 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -55,7 +55,7 @@ class AssertFileChannelDataBlocksClosedExtension implements BeforeEachCallback,
FileChannelDataBlock.tracker = null;
}
private static class OpenFilesTracker implements Tracker {
private static final class OpenFilesTracker implements Tracker {
private final Set<Path> paths = new LinkedHashSet<>();

View File

@@ -1,5 +1,5 @@
/*
* Copyright 2012-2020 the original author or authors.
* Copyright 2012-2024 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -59,7 +59,7 @@ public class SampleApplication {
}
static class SpringApplicationAdmin implements SpringApplicationAdminMXBean {
static final class SpringApplicationAdmin implements SpringApplicationAdminMXBean {
private boolean ready;

View File

@@ -1,5 +1,5 @@
/*
* Copyright 2012-2023 the original author or authors.
* Copyright 2012-2024 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -120,7 +120,7 @@ final class CommandLineBuilder {
/**
* Format System properties.
*/
private static class SystemPropertyFormatter {
private static final class SystemPropertyFormatter {
static String format(String key, String value) {
if (key == null) {