Merge branch '2.0.x' into 2.1.x
Closes gh-17078
This commit is contained in:
@@ -1,5 +1,5 @@
|
||||
/*
|
||||
* Copyright 2012-2018 the original author or authors.
|
||||
* Copyright 2012-2019 the original author or authors.
|
||||
*
|
||||
* Licensed under the Apache License, Version 2.0 (the "License");
|
||||
* you may not use this file except in compliance with the License.
|
||||
@@ -35,15 +35,12 @@ import org.springframework.web.client.RestTemplate;
|
||||
@Service
|
||||
public class RemoteVehicleDetailsService implements VehicleDetailsService {
|
||||
|
||||
private static final Log logger = LogFactory
|
||||
.getLog(RemoteVehicleDetailsService.class);
|
||||
private static final Log logger = LogFactory.getLog(RemoteVehicleDetailsService.class);
|
||||
|
||||
private final RestTemplate restTemplate;
|
||||
|
||||
public RemoteVehicleDetailsService(ServiceProperties properties,
|
||||
RestTemplateBuilder restTemplateBuilder) {
|
||||
this.restTemplate = restTemplateBuilder
|
||||
.rootUri(properties.getVehicleServiceRootUrl()).build();
|
||||
public RemoteVehicleDetailsService(ServiceProperties properties, RestTemplateBuilder restTemplateBuilder) {
|
||||
this.restTemplate = restTemplateBuilder.rootUri(properties.getVehicleServiceRootUrl()).build();
|
||||
}
|
||||
|
||||
@Override
|
||||
@@ -52,8 +49,7 @@ public class RemoteVehicleDetailsService implements VehicleDetailsService {
|
||||
Assert.notNull(vin, "VIN must not be null");
|
||||
logger.debug("Retrieving vehicle data for: " + vin);
|
||||
try {
|
||||
return this.restTemplate.getForObject("/vehicle/{vin}/details",
|
||||
VehicleDetails.class, vin);
|
||||
return this.restTemplate.getForObject("/vehicle/{vin}/details", VehicleDetails.class, vin);
|
||||
}
|
||||
catch (HttpStatusCodeException ex) {
|
||||
if (HttpStatus.NOT_FOUND.equals(ex.getStatusCode())) {
|
||||
|
||||
@@ -1,5 +1,5 @@
|
||||
/*
|
||||
* Copyright 2012-2018 the original author or authors.
|
||||
* Copyright 2012-2019 the original author or authors.
|
||||
*
|
||||
* Licensed under the Apache License, Version 2.0 (the "License");
|
||||
* you may not use this file except in compliance with the License.
|
||||
@@ -33,8 +33,7 @@ public class VehicleDetails {
|
||||
private final String model;
|
||||
|
||||
@JsonCreator
|
||||
public VehicleDetails(@JsonProperty("make") String make,
|
||||
@JsonProperty("model") String model) {
|
||||
public VehicleDetails(@JsonProperty("make") String make, @JsonProperty("model") String model) {
|
||||
Assert.notNull(make, "Make must not be null");
|
||||
Assert.notNull(model, "Model must not be null");
|
||||
this.make = make;
|
||||
|
||||
@@ -1,5 +1,5 @@
|
||||
/*
|
||||
* Copyright 2012-2018 the original author or authors.
|
||||
* Copyright 2012-2019 the original author or authors.
|
||||
*
|
||||
* Licensed under the Apache License, Version 2.0 (the "License");
|
||||
* you may not use this file except in compliance with the License.
|
||||
@@ -31,8 +31,7 @@ public class VehicleIdentificationNumberNotFoundException extends RuntimeExcepti
|
||||
this(vin, null);
|
||||
}
|
||||
|
||||
public VehicleIdentificationNumberNotFoundException(VehicleIdentificationNumber vin,
|
||||
Throwable cause) {
|
||||
public VehicleIdentificationNumberNotFoundException(VehicleIdentificationNumber vin, Throwable cause) {
|
||||
super("Unable to find VehicleIdentificationNumber " + vin, cause);
|
||||
this.vehicleIdentificationNumber = vin;
|
||||
}
|
||||
|
||||
@@ -1,5 +1,5 @@
|
||||
/*
|
||||
* Copyright 2012-2016 the original author or authors.
|
||||
* Copyright 2012-2019 the original author or authors.
|
||||
*
|
||||
* Licensed under the Apache License, Version 2.0 (the "License");
|
||||
* you may not use this file except in compliance with the License.
|
||||
@@ -37,15 +37,13 @@ public class UserVehicleService {
|
||||
|
||||
private final VehicleDetailsService vehicleDetailsService;
|
||||
|
||||
public UserVehicleService(UserRepository userRepository,
|
||||
VehicleDetailsService vehicleDetailsService) {
|
||||
public UserVehicleService(UserRepository userRepository, VehicleDetailsService vehicleDetailsService) {
|
||||
this.userRepository = userRepository;
|
||||
this.vehicleDetailsService = vehicleDetailsService;
|
||||
}
|
||||
|
||||
public VehicleDetails getVehicleDetails(String username)
|
||||
throws UserNameNotFoundException,
|
||||
VehicleIdentificationNumberNotFoundException {
|
||||
throws UserNameNotFoundException, VehicleIdentificationNumberNotFoundException {
|
||||
Assert.notNull(username, "Username must not be null");
|
||||
User user = this.userRepository.findByUsername(username);
|
||||
if (user == null) {
|
||||
|
||||
Reference in New Issue
Block a user