Broaden exceptions that include ServiceConnection name hint
See gh-35168
This commit is contained in:
@@ -27,6 +27,7 @@ import org.springframework.beans.factory.support.RootBeanDefinition;
|
||||
import org.springframework.boot.autoconfigure.service.connection.ConnectionDetails;
|
||||
import org.springframework.boot.autoconfigure.service.connection.ConnectionDetailsFactories;
|
||||
import org.springframework.boot.autoconfigure.service.connection.ConnectionDetailsFactoryNotFoundException;
|
||||
import org.springframework.boot.autoconfigure.service.connection.ConnectionDetailsNotFoundException;
|
||||
import org.springframework.boot.origin.Origin;
|
||||
import org.springframework.core.annotation.MergedAnnotation;
|
||||
|
||||
@@ -73,6 +74,17 @@ class ConnectionDetailsRegistrarTests {
|
||||
.withMessage("fail. You may need to add a 'name' to your @ServiceConnection annotation");
|
||||
}
|
||||
|
||||
@Test
|
||||
void registerBeanDefinitionsWhenConnectionDetailsNotFoundExceptionAndNoConnectionNameThrowsExceptionWithBetterMessage() {
|
||||
DefaultListableBeanFactory beanFactory = new DefaultListableBeanFactory();
|
||||
ConnectionDetailsRegistrar registrar = new ConnectionDetailsRegistrar(beanFactory, this.factories);
|
||||
given(this.factories.getConnectionDetails(this.source, true))
|
||||
.willThrow(new ConnectionDetailsNotFoundException("fail"));
|
||||
assertThatExceptionOfType(ConnectionDetailsNotFoundException.class)
|
||||
.isThrownBy(() -> registrar.registerBeanDefinitions(beanFactory, this.source))
|
||||
.withMessage("fail. You may need to add a 'name' to your @ServiceConnection annotation");
|
||||
}
|
||||
|
||||
@Test
|
||||
void registerBeanDefinitionsWhenExistingBeanSkipsRegistration() {
|
||||
DefaultListableBeanFactory beanFactory = new DefaultListableBeanFactory();
|
||||
|
||||
Reference in New Issue
Block a user