diff --git a/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/endpoint/EndpointAutoConfiguration.java b/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/endpoint/EndpointAutoConfiguration.java index 56f71c3d36..3ace88daee 100644 --- a/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/endpoint/EndpointAutoConfiguration.java +++ b/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/endpoint/EndpointAutoConfiguration.java @@ -63,7 +63,7 @@ public class EndpointAutoConfiguration { static class EndpointWebConfiguration { private static final List MEDIA_TYPES = Arrays - .asList(ActuatorMediaType.V2_JSON_VALUE, "application/json"); + .asList(ActuatorMediaType.V2_JSON, "application/json"); private final ApplicationContext applicationContext; diff --git a/spring-boot-actuator/src/main/java/org/springframework/boot/actuate/endpoint/http/ActuatorMediaType.java b/spring-boot-actuator/src/main/java/org/springframework/boot/actuate/endpoint/http/ActuatorMediaType.java index e5a3173600..dc27627023 100644 --- a/spring-boot-actuator/src/main/java/org/springframework/boot/actuate/endpoint/http/ActuatorMediaType.java +++ b/spring-boot-actuator/src/main/java/org/springframework/boot/actuate/endpoint/http/ActuatorMediaType.java @@ -16,10 +16,8 @@ package org.springframework.boot.actuate.endpoint.http; -import org.springframework.http.MediaType; - /** - * {@link MediaType MediaTypes} that can be consumed and produced by Actuator endpoints. + * Media types that can be consumed and produced by Actuator endpoints. * * @author Andy Wilkinson * @author Madhura Bhave @@ -28,24 +26,14 @@ import org.springframework.http.MediaType; public final class ActuatorMediaType { /** - * {@link String} equivalent of {@link #V1_JSON}. + * Constant for the Actuator V1 media type. */ - public static final String V1_JSON_VALUE = "application/vnd.spring-boot.actuator.v1+json"; + public static final String V1_JSON = "application/vnd.spring-boot.actuator.v1+json"; /** - * {@link String} equivalent of {@link #V2_JSON}. + * Constant for the Actuator V2 media type. */ - public static final String V2_JSON_VALUE = "application/vnd.spring-boot.actuator.v2+json"; - - /** - * The {@code application/vnd.spring-boot.actuator.v1+json} media type. - */ - public static final MediaType V1_JSON = MediaType.valueOf(V1_JSON_VALUE); - - /** - * The {@code application/vnd.spring-boot.actuator.v2+json} media type. - */ - public static final MediaType V2_JSON = MediaType.valueOf(V2_JSON_VALUE); + public static final String V2_JSON = "application/vnd.spring-boot.actuator.v2+json"; private ActuatorMediaType() { } diff --git a/spring-boot-actuator/src/test/java/org/springframework/boot/actuate/endpoint/web/test/JerseyEndpointsRunner.java b/spring-boot-actuator/src/test/java/org/springframework/boot/actuate/endpoint/web/test/JerseyEndpointsRunner.java index 601af85b73..aeb1144412 100644 --- a/spring-boot-actuator/src/test/java/org/springframework/boot/actuate/endpoint/web/test/JerseyEndpointsRunner.java +++ b/spring-boot-actuator/src/test/java/org/springframework/boot/actuate/endpoint/web/test/JerseyEndpointsRunner.java @@ -91,7 +91,7 @@ class JerseyEndpointsRunner extends AbstractWebEndpointRunner { private void customize(ResourceConfig config) { List mediaTypes = Arrays.asList(MediaType.APPLICATION_JSON_VALUE, - ActuatorMediaType.V2_JSON_VALUE); + ActuatorMediaType.V2_JSON); WebAnnotationEndpointDiscoverer discoverer = new WebAnnotationEndpointDiscoverer( this.applicationContext, new ConversionServiceOperationParameterMapper(), (id) -> null, diff --git a/spring-boot-actuator/src/test/java/org/springframework/boot/actuate/endpoint/web/test/WebFluxEndpointsRunner.java b/spring-boot-actuator/src/test/java/org/springframework/boot/actuate/endpoint/web/test/WebFluxEndpointsRunner.java index a4afef3daf..76643d70c4 100644 --- a/spring-boot-actuator/src/test/java/org/springframework/boot/actuate/endpoint/web/test/WebFluxEndpointsRunner.java +++ b/spring-boot-actuator/src/test/java/org/springframework/boot/actuate/endpoint/web/test/WebFluxEndpointsRunner.java @@ -98,7 +98,7 @@ class WebFluxEndpointsRunner extends AbstractWebEndpointRunner { @Bean public WebFluxEndpointHandlerMapping webEndpointReactiveHandlerMapping() { List mediaTypes = Arrays.asList(MediaType.APPLICATION_JSON_VALUE, - ActuatorMediaType.V2_JSON_VALUE); + ActuatorMediaType.V2_JSON); WebAnnotationEndpointDiscoverer discoverer = new WebAnnotationEndpointDiscoverer( this.applicationContext, new ConversionServiceOperationParameterMapper(), (id) -> null, diff --git a/spring-boot-actuator/src/test/java/org/springframework/boot/actuate/endpoint/web/test/WebMvcEndpointRunner.java b/spring-boot-actuator/src/test/java/org/springframework/boot/actuate/endpoint/web/test/WebMvcEndpointRunner.java index 6051d814a6..d14d03cf2b 100644 --- a/spring-boot-actuator/src/test/java/org/springframework/boot/actuate/endpoint/web/test/WebMvcEndpointRunner.java +++ b/spring-boot-actuator/src/test/java/org/springframework/boot/actuate/endpoint/web/test/WebMvcEndpointRunner.java @@ -81,7 +81,7 @@ class WebMvcEndpointRunner extends AbstractWebEndpointRunner { @Bean public WebMvcEndpointHandlerMapping webEndpointServletHandlerMapping() { List mediaTypes = Arrays.asList(MediaType.APPLICATION_JSON_VALUE, - ActuatorMediaType.V2_JSON_VALUE); + ActuatorMediaType.V2_JSON); WebAnnotationEndpointDiscoverer discoverer = new WebAnnotationEndpointDiscoverer( this.applicationContext, new ConversionServiceOperationParameterMapper(), (id) -> null, diff --git a/spring-boot-actuator/src/test/java/org/springframework/boot/actuate/logger/LoggersEndpointWebIntegrationTests.java b/spring-boot-actuator/src/test/java/org/springframework/boot/actuate/logger/LoggersEndpointWebIntegrationTests.java index 9b8018fc49..cfc1f4be10 100644 --- a/spring-boot-actuator/src/test/java/org/springframework/boot/actuate/logger/LoggersEndpointWebIntegrationTests.java +++ b/spring-boot-actuator/src/test/java/org/springframework/boot/actuate/logger/LoggersEndpointWebIntegrationTests.java @@ -116,7 +116,7 @@ public class LoggersEndpointWebIntegrationTests { @Test public void setLoggerUsingActuatorV2JsonShouldSetLogLevel() throws Exception { client.post().uri("/application/loggers/ROOT") - .contentType(ActuatorMediaType.V2_JSON) + .contentType(MediaType.parseMediaType(ActuatorMediaType.V2_JSON)) .syncBody(Collections.singletonMap("configuredLevel", "debug")).exchange() .expectStatus().isNoContent(); verify(this.loggingSystem).setLogLevel("ROOT", LogLevel.DEBUG); @@ -134,7 +134,7 @@ public class LoggersEndpointWebIntegrationTests { @Test public void setLoggerWithNullLogLevel() throws Exception { client.post().uri("/application/loggers/ROOT") - .contentType(ActuatorMediaType.V2_JSON) + .contentType(MediaType.parseMediaType(ActuatorMediaType.V2_JSON)) .syncBody(Collections.singletonMap("configuredLevel", null)).exchange() .expectStatus().isNoContent(); verify(this.loggingSystem).setLogLevel("ROOT", null); @@ -143,8 +143,8 @@ public class LoggersEndpointWebIntegrationTests { @Test public void setLoggerWithNoLogLevel() throws Exception { client.post().uri("/application/loggers/ROOT") - .contentType(ActuatorMediaType.V2_JSON).syncBody(Collections.emptyMap()) - .exchange().expectStatus().isNoContent(); + .contentType(MediaType.parseMediaType(ActuatorMediaType.V2_JSON)) + .syncBody(Collections.emptyMap()).exchange().expectStatus().isNoContent(); verify(this.loggingSystem).setLogLevel("ROOT", null); } diff --git a/spring-boot-parent/src/checkstyle/import-control.xml b/spring-boot-parent/src/checkstyle/import-control.xml index 25f0258f8b..02cf936565 100644 --- a/spring-boot-parent/src/checkstyle/import-control.xml +++ b/spring-boot-parent/src/checkstyle/import-control.xml @@ -30,17 +30,19 @@ - + - - - + + + + +