Spring/spring-boot
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Polish "Revisit PluginXmlParserTests"

Browse Source 
See gh-20190
This commit is contained in:
Stephane Nicoll
2020-02-17 09:36:15 +01:00
parent 020ae2c7ba
commit 3ba411e04d
1 changed files with 11 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
buildSrc/src/test/java/org/springframework/boot/build/mavenplugin/PluginXmlParserTests.java
View File

@@ -1,5 +1,5 @@
/* /*
* Copyright 2019-2020 the original author or authors. * Copyright 2012-2020 the original author or authors.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@@ -16,16 +16,17 @@
package org.springframework.boot.build.mavenplugin; package org.springframework.boot.build.mavenplugin;
import org.junit.jupiter.api.Test;
import org.springframework.boot.build.mavenplugin.PluginXmlParser.Plugin;
import java.io.File; import java.io.File;
import java.io.FileNotFoundException;
import java.util.Arrays; import java.util.Arrays;
import java.util.List;
import java.util.stream.Collectors; import java.util.stream.Collectors;
import org.junit.jupiter.api.Test;
import org.springframework.boot.build.mavenplugin.PluginXmlParser.Plugin;
import static org.assertj.core.api.Assertions.assertThat; import static org.assertj.core.api.Assertions.assertThat;
import static org.junit.jupiter.api.Assertions.assertThrows; import static org.assertj.core.api.Assertions.assertThatThrownBy;
/** /**
* Tests for {@link PluginXmlParser}. * Tests for {@link PluginXmlParser}.
@@ -38,7 +39,7 @@ public class PluginXmlParserTests {
private final PluginXmlParser parser = new PluginXmlParser(); private final PluginXmlParser parser = new PluginXmlParser();
@Test @Test
void parsingAValidPluginXMLFileReturnsTheGAVForThePlugin() { void parseExistingDescriptorReturnPluginDescriptor() {
Plugin plugin = this.parser.parse(new File("src/test/resources/plugin.xml")); Plugin plugin = this.parser.parse(new File("src/test/resources/plugin.xml"));
assertThat(plugin.getGroupId()).isEqualTo("org.springframework.boot"); assertThat(plugin.getGroupId()).isEqualTo("org.springframework.boot");
assertThat(plugin.getArtifactId()).isEqualTo("spring-boot-maven-plugin"); assertThat(plugin.getArtifactId()).isEqualTo("spring-boot-maven-plugin");
@@ -49,9 +50,9 @@ public class PluginXmlParserTests {
} }
@Test @Test
void aNonExistentPluginFileThrowsARuntimeException() { void parseNonExistingFileThrowException() {
assertThrows(RuntimeException.class, () -> assertThatThrownBy(() -> this.parser.parse(new File("src/test/resources/nonexistent.xml")))
this.parser.parse(new File("src/test/resources/nonexistent.xml"))); .isInstanceOf(RuntimeException.class).hasCauseInstanceOf(FileNotFoundException.class);
} }
} }