Tweak ConfigurableEmbeddedServletContainerFactory

Update ConfigurableEmbeddedServletContainerFactory to no longer directly
extend EmbeddedServletContainerFactory.
This commit is contained in:
Phillip Webb
2014-03-03 18:39:18 -08:00
parent 9c4dc0c68f
commit 3f9ca68812
5 changed files with 26 additions and 24 deletions

View File

@@ -60,6 +60,8 @@ public class ServerPropertiesAutoConfiguration implements ApplicationContextAwar
@Override
public void customize(ConfigurableEmbeddedServletContainerFactory factory) {
// ServerProperties handles customization, this just checks we only have
// a single bean
String[] serverPropertiesBeans = this.applicationContext
.getBeanNamesForType(ServerProperties.class);
Assert.state(

View File

@@ -48,7 +48,7 @@ import static org.junit.Assert.assertNotNull;
*/
public class ServerPropertiesAutoConfigurationTests {
private static ConfigurableEmbeddedServletContainerFactory containerFactory;
private static AbstractEmbeddedServletContainerFactory containerFactory;
@Rule
public ExpectedException thrown = ExpectedException.none();
@@ -57,8 +57,7 @@ public class ServerPropertiesAutoConfigurationTests {
@Before
public void init() {
containerFactory = Mockito
.mock(ConfigurableEmbeddedServletContainerFactory.class);
containerFactory = Mockito.mock(AbstractEmbeddedServletContainerFactory.class);
}
@After
@@ -104,13 +103,12 @@ public class ServerPropertiesAutoConfigurationTests {
PropertyPlaceholderAutoConfiguration.class);
this.context.refresh();
containerFactory = this.context
.getBean(ConfigurableEmbeddedServletContainerFactory.class);
.getBean(AbstractEmbeddedServletContainerFactory.class);
ServerProperties server = this.context.getBean(ServerProperties.class);
assertNotNull(server);
// The server.port environment property was not explicitly set so the container
// factory should take precedence...
assertEquals(3000,
((AbstractEmbeddedServletContainerFactory) containerFactory).getPort());
assertEquals(3000, containerFactory.getPort());
}
@Test