Polish "Allow data unit to be specified on the constructor parameter"

See gh-21746

spring-boot-project/spring-boot-docs/src/test/java/org/springframework/boot/docs/context/properties/bind/constructor/AppSystemPropertiesTests.java

@@ -0,0 +1,81 @@
+/*
+ * Copyright 2012-2020 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.springframework.boot.docs.context.properties.bind.constructor;
+
+import java.util.function.Consumer;
+
+import org.junit.jupiter.api.Test;
+
+import org.springframework.boot.context.properties.EnableConfigurationProperties;
+import org.springframework.boot.test.context.assertj.AssertableApplicationContext;
+import org.springframework.boot.test.context.runner.ApplicationContextRunner;
+import org.springframework.boot.test.context.runner.ContextConsumer;
+import org.springframework.context.annotation.Configuration;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+/**
+ * Tests for {@link AppSystemProperties}.
+ *
+ * @author Stephane Nicoll
+ */
+class AppSystemPropertiesTests {
+
+	private final ApplicationContextRunner contextRunner = new ApplicationContextRunner()
+			.withUserConfiguration(Config.class);
+
+	@Test
+	void bindWithDefaultUnit() {
+		this.contextRunner.withPropertyValues("app.system.session-timeout=40", "app.system.read-timeout=5000")
+				.run(assertBinding((properties) -> {
+					assertThat(properties.getSessionTimeout()).hasSeconds(40);
+					assertThat(properties.getReadTimeout()).hasMillis(5000);
+				}));
+	}
+
+	@Test
+	void bindWithExplicitUnit() {
+		this.contextRunner.withPropertyValues("app.system.session-timeout=1h", "app.system.read-timeout=5s")
+				.run(assertBinding((properties) -> {
+					assertThat(properties.getSessionTimeout()).hasMinutes(60);
+					assertThat(properties.getReadTimeout()).hasMillis(5000);
+				}));
+	}
+
+	@Test
+	void bindWithIso8601Format() {
+		this.contextRunner.withPropertyValues("app.system.session-timeout=PT15S", "app.system.read-timeout=PT0.5S")
+				.run(assertBinding((properties) -> {
+					assertThat(properties.getSessionTimeout()).hasSeconds(15);
+					assertThat(properties.getReadTimeout()).hasMillis(500);
+				}));
+	}
+
+	private ContextConsumer<AssertableApplicationContext> assertBinding(Consumer<AppSystemProperties> properties) {
+		return (context) -> {
+			assertThat(context).hasSingleBean(AppSystemProperties.class);
+			properties.accept(context.getBean(AppSystemProperties.class));
+		};
+	}
+
+	@Configuration(proxyBeanMethods = false)
+	@EnableConfigurationProperties(AppSystemProperties.class)
+	static class Config {
+
+	}
+
+}

spring-boot-project/spring-boot-docs/src/test/java/org/springframework/boot/docs/context/properties/bind/javabean/AppSystemPropertiesTests.java

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-package org.springframework.boot.docs.context.properties.bind;
+package org.springframework.boot.docs.context.properties.bind.javabean;
 
 import java.util.function.Consumer;